0002014: Unable to join empty Chocolate Doom server.

(0011002)
Zalewa (developer)
2014-11-29 19:20
edited on: 2014-11-29 19:21

Fix for infinite recurrency:
'https://bitbucket.org/Blzut3/doomseeker/commits/28d63a34ac2c32b9d298a5e427f88715bdfd66a8 [^]'

More things are broken and pending fixes.

(0011011)
Zalewa (developer)
2014-11-30 17:53
edited on: 2014-11-30 17:53

trim the 'Map' string before parsing it for the 'warp' argument.

Command line builder for server setup will now use only the necessary building bricks provided by Doomseeker to avoid duplicating arguments or even having conflicting ones.

(0011012)
Zalewa (developer)
2014-11-30 17:57

When server is using custom PWADs, there's no way to automatically load them as server doesn't provide such information. In this case, should we pop-up the create server dialog without considering if the server already has players, so that everyone can load up PWADs they agreed to load through some "other means of communication"?

(0011013)
Blzut3 (administrator)
2014-11-30 20:31

I'll check with the chocolate doom folks about this, I may or may not recall this being brought up when I initially implemented it, but I don't remember the result of the discussion.

(0011024)
Blzut3 (administrator)
2014-12-01 19:55

Filed a ticket on their tracker:'https://github.com/chocolate-doom/chocolate-doom/issues/478 [^]'

In the mean time since it will probably be some time before that issue gets resolved and a fix (if any is implemented), I suppose we should send out an update with the solution you suggested. I did do some basic testing and it does look like the warp and game mode settings get communicated to clients automatically, so I think the only important thing is that the pwads get specified.

(0011060)
Zalewa (developer)
2014-12-15 17:17

I think this will do it for the time being:
'https://bitbucket.org/Blzut3/doomseeker/commits/2331c04d091c69a9128878fd3e5d5e2d4eacdc39 [^]'

Better solution would be to build all command line arguments automatically wherever possible and just display dialog box where user picks PWADs. It'd be quite easy to do in pluginapi branch as the WadsPicker widget is already available there and only needs to be exported. Perhaps we can leave it like it is now for the bugfix release and do it better for the next feature release?

(0011061)
Zalewa (developer)
2014-12-15 17:19

I wrongly set this as resolved when I meant "needs review"...

(0011067)
Blzut3 (administrator)
2014-12-16 03:11

Is there a way to get the create server dialog to fill in the proper IWAD automatically? If not then I think this solution is good to push out a stable update.

(0011073)
Zalewa (developer)
2014-12-17 15:51

'https://bitbucket.org/Blzut3/doomseeker/commits/055c304c601b1a9f7a35e9f26247654af7005957 [^]'

(0011075)
Blzut3 (administrator)
2014-12-19 22:26

Doesn't work on my system since firstLoadConfigTimer > loadConfig overwrites it.

(0011089)
Zalewa (developer)
2014-12-25 00:10

Could you check now with latest commits?

(0011312)
Blzut3 (administrator)
2015-01-06 03:18

Forgot I was planning on testing this. Yeah it works fine now, I guess it's time to push out the update then.

(0011322)
Zalewa (developer)
2015-01-07 20:28

Ok, I bumped, tagged, pushed and deployed to stable update channel.

Here's a zip with Windows build:'http://devbuilds.drdteam.org/doomseeker/doomseeker-0.12.2%20Beta-150107-1945_stable.zip [^]'

I'll open a new ticket for the feature update. I think this ticket can be closed.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2014-11-27 22:44	Zalewa	New Issue
2014-11-29 19:19	Zalewa	Assigned To	=> Zalewa
2014-11-29 19:19	Zalewa	Status	new => assigned
2014-11-29 19:20	Zalewa	Note Added: 0011002
2014-11-29 19:21	Zalewa	Note Edited: 0011002	View Revisions
2014-11-30 17:53	Zalewa	Note Added: 0011011
2014-11-30 17:53	Zalewa	Note Edited: 0011011	View Revisions
2014-11-30 17:57	Zalewa	Note Added: 0011012
2014-11-30 20:31	Blzut3	Note Added: 0011013
2014-12-01 19:55	Blzut3	Note Added: 0011024
2014-12-15 17:17	Zalewa	Note Added: 0011060
2014-12-15 17:17	Zalewa	Status	assigned => resolved
2014-12-15 17:17	Zalewa	Resolution	open => fixed
2014-12-15 17:19	Zalewa	Note Added: 0011061
2014-12-15 17:19	Zalewa	Status	resolved => needs review
2014-12-16 03:11	Blzut3	Note Added: 0011067
2014-12-17 15:51	Zalewa	Note Added: 0011073
2014-12-19 22:26	Blzut3	Note Added: 0011075
2014-12-25 00:10	Zalewa	Note Added: 0011089
2015-01-06 03:18	Blzut3	Note Added: 0011312
2015-01-07 20:28	Zalewa	Note Added: 0011322
2015-01-07 20:33	Zalewa	Relationship added	related to 0002057
2015-01-10 06:56	Blzut3	Status	needs review => resolved
2015-01-10 06:56	Blzut3	Fixed in Version	=> 0.12.2 Beta
2015-01-10 06:56	Blzut3	Target Version	=> 0.12.2 Beta
2018-09-29 14:43	WubTheCaptain	Status	resolved => closed

Notes
(0011002) Zalewa (developer) 2014-11-29 19:20 edited on: 2014-11-29 19:21	Fix for infinite recurrency: 'https://bitbucket.org/Blzut3/doomseeker/commits/28d63a34ac2c32b9d298a5e427f88715bdfd66a8 [^]' More things are broken and pending fixes.

(0011011) Zalewa (developer) 2014-11-30 17:53 edited on: 2014-11-30 17:53	trim the 'Map' string before parsing it for the 'warp' argument. Command line builder for server setup will now use only the necessary building bricks provided by Doomseeker to avoid duplicating arguments or even having conflicting ones.

(0011012) Zalewa (developer) 2014-11-30 17:57	When server is using custom PWADs, there's no way to automatically load them as server doesn't provide such information. In this case, should we pop-up the create server dialog without considering if the server already has players, so that everyone can load up PWADs they agreed to load through some "other means of communication"?

(0011013) Blzut3 (administrator) 2014-11-30 20:31	I'll check with the chocolate doom folks about this, I may or may not recall this being brought up when I initially implemented it, but I don't remember the result of the discussion.

(0011024) Blzut3 (administrator) 2014-12-01 19:55	Filed a ticket on their tracker:'https://github.com/chocolate-doom/chocolate-doom/issues/478 [^]' In the mean time since it will probably be some time before that issue gets resolved and a fix (if any is implemented), I suppose we should send out an update with the solution you suggested. I did do some basic testing and it does look like the warp and game mode settings get communicated to clients automatically, so I think the only important thing is that the pwads get specified.

(0011060) Zalewa (developer) 2014-12-15 17:17	I think this will do it for the time being: 'https://bitbucket.org/Blzut3/doomseeker/commits/2331c04d091c69a9128878fd3e5d5e2d4eacdc39 [^]' Better solution would be to build all command line arguments automatically wherever possible and just display dialog box where user picks PWADs. It'd be quite easy to do in pluginapi branch as the WadsPicker widget is already available there and only needs to be exported. Perhaps we can leave it like it is now for the bugfix release and do it better for the next feature release?

(0011061) Zalewa (developer) 2014-12-15 17:19	I wrongly set this as resolved when I meant "needs review"...

(0011067) Blzut3 (administrator) 2014-12-16 03:11	Is there a way to get the create server dialog to fill in the proper IWAD automatically? If not then I think this solution is good to push out a stable update.

(0011073) Zalewa (developer) 2014-12-17 15:51	'https://bitbucket.org/Blzut3/doomseeker/commits/055c304c601b1a9f7a35e9f26247654af7005957 [^]'

(0011075) Blzut3 (administrator) 2014-12-19 22:26	Doesn't work on my system since firstLoadConfigTimer > loadConfig overwrites it.

(0011089) Zalewa (developer) 2014-12-25 00:10	Could you check now with latest commits?

(0011312) Blzut3 (administrator) 2015-01-06 03:18	Forgot I was planning on testing this. Yeah it works fine now, I guess it's time to push out the update then.

(0011322) Zalewa (developer) 2015-01-07 20:28	Ok, I bumped, tagged, pushed and deployed to stable update channel. Here's a zip with Windows build:'http://devbuilds.drdteam.org/doomseeker/doomseeker-0.12.2%20Beta-150107-1945_stable.zip [^]' I'll open a new ticket for the feature update. I think this ticket can be closed.