0001976: Changing Use Vertex Buffer in Software causes a crash

Notes
(0010713) Watermelon (developer) 2014-10-29 17:08	Is that somewhere in Options? Or a CVAR?

(0010716) forrestmarkx (reporter) 2014-10-29 17:46	Options, In OpenGL setting under Prefrences

(0010717) WaTaKiD (updater) 2014-10-29 18:11	aka gl_usevbo 0/1/2 i can crash 100% of the time in software, with a fresh config or not, regardless of wut im changing the cvar to, or wut it was before trying to change it also when using a fresh config, if ur first startup is in software, it will actually be set to -1 (or 'unknown' in the menu) although changing it will still crash

(0010720) Dusk (developer) 2014-10-29 19:43 edited on: 2014-10-29 19:44	This is due to infinite recursion in gl_usevbo callback function. In the software renderer the !(gl.flags&RFL_VBO) expression is true, causing it set `self` to 0, recursively triggering the callback again. Does this happen in gzdoom r880? Maybe we need to backport a fix for this.

(0010723) WaTaKiD (updater) 2014-10-29 20:34	after testing gzdoom r880 and 1.8.6, this still happens, but in 1.8.7 it doesnt

(0011379) Edward-san (developer) 2015-01-15 14:14 edited on: 2015-01-15 14:14	Doesn't happen in 1.8.7 because of this commit, which removes pre GL 2.0 support.

(0011791) cobalt (updater) 2015-03-08 20:41 edited on: 2015-03-09 04:48	Issue addressed by commit 7c37e9a58eaa: Fixed: Changing gl_usevbo while using the software renderer crashed the game (fixes 1976). Committed by Benjamin Berkels [Torr Samaho] on Sunday 08 March 2015 21:39:11 Changes in files: src/gl/data/gl_vertexbuffer.cpp \| 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)

(0011795) WaTaKiD (updater) 2015-03-08 21:49	after testing with 2.0-r150308-2039, issue seems fixed

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2014-10-29 16:21	forrestmarkx	New Issue
2014-10-29 17:08	Watermelon	Note Added: 0010713
2014-10-29 17:08	Watermelon	Status	new => feedback
2014-10-29 17:46	forrestmarkx	Note Added: 0010716
2014-10-29 17:46	forrestmarkx	Status	feedback => new
2014-10-29 18:11	WaTaKiD	Note Added: 0010717
2014-10-29 19:43	Dusk	Note Added: 0010720
2014-10-29 19:44	Dusk	Note Edited: 0010720	View Revisions
2014-10-29 19:46	Dusk	Priority	urgent => normal
2014-10-29 20:34	WaTaKiD	Note Added: 0010723
2015-01-15 14:14	Edward-san	Note Added: 0011379
2015-01-15 14:14	Edward-san	Note Edited: 0011379	View Revisions
2015-01-15 14:59	Edward-san	Assigned To	=> Torr Samaho
2015-01-15 14:59	Edward-san	Status	new => assigned
2015-02-15 21:08	Dusk	Target Version	=> 2.0
2015-03-08 20:41	cobalt	Status	assigned => needs testing
2015-03-08 20:41	cobalt	Note Added: 0011791
2015-03-08 20:46	cobalt	Note Added: 0011792
2015-03-08 21:49	WaTaKiD	Note Added: 0011795
2015-03-09 04:48	Dusk	Note Deleted: 0011792
2015-03-09 04:48	Dusk	Note Edited: 0011791	View Revisions
2015-03-09 04:49	Dusk	Status	needs testing => resolved
2015-03-09 04:49	Dusk	Fixed in Version	=> 2.0
2015-03-09 04:49	Dusk	Resolution	open => fixed
2018-09-30 23:04	Blzut3	Status	resolved => closed

Relationships