Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001895Zandronum[All Projects] Bugpublic2014-07-21 02:302018-09-30 23:04
ReporterWaTaKiD 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.0-beta 
Target Version2.0Fixed in Version2.0 
Summary0001895: hexen crash when using serpent staff in melee range online
Descriptionsummary
Steps To Reproducejoin hexen server
choose cleric
'give weapons'
attack a monster using serpent staff in melee range
crash
Additional Informationive tested gzdoom 323/1.5.0/1.8.6 and zdoom 2.3.1/2.5.0/2.7.1 along with zandro 1.2.2 and 1.3-140703-1806 singleplayer and multiplayer, and this appears to happen only in zandro 2.0 online, in every build ive tested so far, latest being 140720-1542

also, this happens in software and opengl even with a fresh config
Attached Fileszip file icon CrashReport-serpentstaffcrash.zip [^] (22,544 bytes) 2014-07-21 02:30

- Relationships

-  Notes
User avatar (0010030)
DevilHunter (reporter)
2014-07-21 22:54

 I can confirm this, as it does the very same for me. Haven't tested the other gzdoom's and whatnot, but yea..
User avatar (0011156)
WaTaKiD (updater)
2014-12-31 14:47

 no longer an issue for me as of 2.0-141231-1114
User avatar (0011512)
WaTaKiD (updater)
2015-01-23 07:11

 after testing 2.0-r150119-2001, this issue came up again

i dont know when this was fixed before, but i think'https://bitbucket.org/Torr_Samaho/zandronum/commits/839cd8f167c83a702c1e6b46d8931d39d3a76d05 [^]' might be the recent cause for this issue
although when i tried to update and build this, it came out as 1.4 and the issue wasnt present, but when i updated and built'https://bitbucket.org/Torr_Samaho/zandronum/commits/2acec5d85c83aeede5a18581f2d5f4455956b86b [^]'
it came out as 2.0 and the issue was present, and doing cl_hitscandecalhack 0 fixes the issue
User avatar (0011514)
Edward-san (developer)
2015-01-23 10:27
edited on: 2015-01-23 11:04

 It seems you need to find the revision which fixed the crash first.

[edit]Nevermind. It happens because in zandronum 2.0, P_LineAttack has an additional parameter which gets the victim of the attack. Since the addition of that NETWORK_InClientMode check, the clients could not set the victim anymore (see p_map.cpp line 4547).
User avatar (0011699)
Edward-san (developer)
2015-02-16 11:31
edited on: 2015-02-16 12:01

 Ugh ... the crash could potentially happen also in ZDoom. ZDoom r2373 introduced the 'victim' parameter to the function P_LineAttack for the reason is written in the commit log. Sadly, this caused some crashes, because there were no NULL checks.

ZDoom r2415 should have supposed to fix it in all the places where P_LineAttack would use the 'victim' parameter (NULL pointer checks), but apparently it forgot to do it in A_CStaffCheck.

It seems I have bug report in ZDoom bugs forum, because the trunk code is affected as well.

Now, this would fix the crash, but I'm sure that you could get the same issue as 0001894 , ie desync, with the same reason as 0001894:0011513 .

[edit] Done.
User avatar (0011730)
Edward-san (developer)
2015-02-21 09:42

 randi fixed the crash in commit 19ab774.
User avatar (0011788)
Torr Samaho (administrator)
2015-03-08 20:20

 0001894:0011784 may also fix this crash. Please test.
User avatar (0011794)
WaTaKiD (updater)
2015-03-08 21:41

 after testing with 2.0-r150308-2039, issue seems fixed

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2014-07-21 02:30 WaTaKiD New Issue
2014-07-21 02:30 WaTaKiD File Added: CrashReport-serpentstaffcrash.zip
2014-07-21 22:54 DevilHunter Note Added: 0010030
2014-07-25 22:21 Arco Status new => confirmed
2014-12-31 14:47 WaTaKiD Note Added: 0011156
2014-12-31 15:25 Dusk Status confirmed => closed
2014-12-31 15:25 Dusk Resolution open => unable to reproduce
2015-01-23 07:11 WaTaKiD Note Added: 0011512
2015-01-23 07:11 WaTaKiD Status closed => feedback
2015-01-23 07:11 WaTaKiD Resolution unable to reproduce => reopened
2015-01-23 10:27 Edward-san Note Added: 0011514
2015-01-23 11:04 Edward-san Note Edited: 0011514 View Revisions
2015-02-15 21:08 Dusk Target Version => 2.0
2015-02-16 11:31 Edward-san Note Added: 0011699
2015-02-16 11:32 Edward-san Note Edited: 0011699 View Revisions
2015-02-16 11:38 Edward-san Note Edited: 0011699 View Revisions
2015-02-16 11:50 Edward-san Note Edited: 0011699 View Revisions
2015-02-16 11:50 Edward-san Note Edited: 0011699 View Revisions
2015-02-16 12:00 Edward-san Note Edited: 0011699 View Revisions
2015-02-16 12:00 Edward-san Note Edited: 0011699 View Revisions
2015-02-16 12:01 Edward-san Note Edited: 0011699 View Revisions
2015-02-21 09:42 Edward-san Note Added: 0011730
2015-03-08 20:20 Torr Samaho Note Added: 0011788
2015-03-08 20:21 Torr Samaho Assigned To => Torr Samaho
2015-03-08 20:21 Torr Samaho Status feedback => needs testing
2015-03-08 21:41 WaTaKiD Note Added: 0011794
2015-03-09 04:49 Dusk Status needs testing => resolved
2015-03-09 04:49 Dusk Fixed in Version => 2.0
2015-03-09 04:49 Dusk Resolution reopened => fixed
2018-09-30 23:04 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker