MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001895Zandronum[All Projects] Bugpublic2014-07-21 02:302018-09-30 23:04
ReporterWaTaKiD 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.0-beta 
Target Version2.0Fixed in Version2.0 
Summary0001895: hexen crash when using serpent staff in melee range online
Descriptionsummary
Steps To Reproducejoin hexen server
choose cleric
'give weapons'
attack a monster using serpent staff in melee range
crash
Additional Informationive tested gzdoom 323/1.5.0/1.8.6 and zdoom 2.3.1/2.5.0/2.7.1 along with zandro 1.2.2 and 1.3-140703-1806 singleplayer and multiplayer, and this appears to happen only in zandro 2.0 online, in every build ive tested so far, latest being 140720-1542

also, this happens in software and opengl even with a fresh config
TagsNo tags attached.
Relationships
Attached Fileszip CrashReport-serpentstaffcrash.zip (22,544) 2014-07-21 02:30
https://zandronum.com/tracker/file_download.php?file_id=1266&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-07-21 02:30WaTaKiDNew Issue
2014-07-21 02:30WaTaKiDFile Added: CrashReport-serpentstaffcrash.zip
2014-07-21 22:54DevilHunterNote Added: 0010030
2014-07-25 22:21ArcoStatusnew => confirmed
2014-12-31 14:47WaTaKiDNote Added: 0011156
2014-12-31 15:25DuskStatusconfirmed => closed
2014-12-31 15:25DuskResolutionopen => unable to reproduce
2015-01-23 07:11WaTaKiDNote Added: 0011512
2015-01-23 07:11WaTaKiDStatusclosed => feedback
2015-01-23 07:11WaTaKiDResolutionunable to reproduce => reopened
2015-01-23 10:27Edward-sanNote Added: 0011514
2015-01-23 11:04Edward-sanNote Edited: 0011514bug_revision_view_page.php?bugnote_id=11514#r6508
2015-02-15 21:08DuskTarget Version => 2.0
2015-02-16 11:31Edward-sanNote Added: 0011699
2015-02-16 11:32Edward-sanNote Edited: 0011699bug_revision_view_page.php?bugnote_id=11699#r6655
2015-02-16 11:38Edward-sanNote Edited: 0011699bug_revision_view_page.php?bugnote_id=11699#r6656
2015-02-16 11:50Edward-sanNote Edited: 0011699bug_revision_view_page.php?bugnote_id=11699#r6657
2015-02-16 11:50Edward-sanNote Edited: 0011699bug_revision_view_page.php?bugnote_id=11699#r6658
2015-02-16 12:00Edward-sanNote Edited: 0011699bug_revision_view_page.php?bugnote_id=11699#r6659
2015-02-16 12:00Edward-sanNote Edited: 0011699bug_revision_view_page.php?bugnote_id=11699#r6660
2015-02-16 12:01Edward-sanNote Edited: 0011699bug_revision_view_page.php?bugnote_id=11699#r6661
2015-02-21 09:42Edward-sanNote Added: 0011730
2015-03-08 20:20Torr SamahoNote Added: 0011788
2015-03-08 20:21Torr SamahoAssigned To => Torr Samaho
2015-03-08 20:21Torr SamahoStatusfeedback => needs testing
2015-03-08 21:41WaTaKiDNote Added: 0011794
2015-03-09 04:49DuskStatusneeds testing => resolved
2015-03-09 04:49DuskFixed in Version => 2.0
2015-03-09 04:49DuskResolutionreopened => fixed
2018-09-30 23:04Blzut3Statusresolved => closed

Notes
(0010030)
DevilHunter   
2014-07-21 22:54   
I can confirm this, as it does the very same for me. Haven't tested the other gzdoom's and whatnot, but yea..
(0011156)
WaTaKiD   
2014-12-31 14:47   
no longer an issue for me as of 2.0-141231-1114
(0011512)
WaTaKiD   
2015-01-23 07:11   
after testing 2.0-r150119-2001, this issue came up again

i dont know when this was fixed before, but i think'https://bitbucket.org/Torr_Samaho/zandronum/commits/839cd8f167c83a702c1e6b46d8931d39d3a76d05 [^]' might be the recent cause for this issue
although when i tried to update and build this, it came out as 1.4 and the issue wasnt present, but when i updated and built'https://bitbucket.org/Torr_Samaho/zandronum/commits/2acec5d85c83aeede5a18581f2d5f4455956b86b [^]'
it came out as 2.0 and the issue was present, and doing cl_hitscandecalhack 0 fixes the issue
(0011514)
Edward-san   
2015-01-23 10:27   
(edited on: 2015-01-23 11:04)
It seems you need to find the revision which fixed the crash first.

[edit]Nevermind. It happens because in zandronum 2.0, P_LineAttack has an additional parameter which gets the victim of the attack. Since the addition of that NETWORK_InClientMode check, the clients could not set the victim anymore (see p_map.cpp line 4547).
(0011699)
Edward-san   
2015-02-16 11:31   
(edited on: 2015-02-16 12:01)
Ugh ... the crash could potentially happen also in ZDoom. ZDoom r2373 introduced the 'victim' parameter to the function P_LineAttack for the reason is written in the commit log. Sadly, this caused some crashes, because there were no NULL checks.

ZDoom r2415 should have supposed to fix it in all the places where P_LineAttack would use the 'victim' parameter (NULL pointer checks), but apparently it forgot to do it in A_CStaffCheck.

It seems I have bug report in ZDoom bugs forum, because the trunk code is affected as well.

Now, this would fix the crash, but I'm sure that you could get the same issue as 0001894 , ie desync, with the same reason as 0001894:0011513 .

[edit] Done.
(0011730)
Edward-san   
2015-02-21 09:42   
randi fixed the crash in commit 19ab774.
(0011788)
Torr Samaho   
2015-03-08 20:20   
0001894:0011784 may also fix this crash. Please test.
(0011794)
WaTaKiD   
2015-03-08 21:41   
after testing with 2.0-r150308-2039, issue seems fixed