Anonymous | Login | Signup for a new account | 2025-07-27 13:26 UTC | ![]() |
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0001865 | Zandronum | [All Projects] Suggestion | public | 2014-06-30 19:22 | 2018-09-30 22:58 | ||||
Reporter | Catastrophe | ||||||||
Assigned To | Watermelon | ||||||||
Priority | normal | Severity | minor | Reproducibility | N/A | ||||
Status | closed | Resolution | fixed | ||||||
Platform | Microsoft | OS | Windows | OS Version | XP/Vista/7 | ||||
Product Version | 1.2 | ||||||||
Target Version | 1.4 | Fixed in Version | 2.0 | ||||||
Summary | 0001865: Add a +NOIDENTIFYTARGET flag to decorate. | ||||||||
Description | This flag would be useful because certain mods only want certain classes to be unaffected by identify target (like creepers in gvh). However since we can't do that, we are forced to enable sv_noidentifytarget which instead affects all classes. | ||||||||
Steps To Reproduce | Adding +NOIDENTIFYTARGET to a playerclass would stop the players name from appearing when you are aiming at them. | ||||||||
Attached Files | ![]() | ||||||||
![]() |
|
Watermelon (developer) 2014-06-30 19:23 edited on: 2014-06-30 19:25 |
I attached a diff. This is not meant to be complete, since we need to take into account teams and such. Please comment on this if it's okay. The main reason this is brought up is that major wads like AoW and GvH use invisible classes, but you have to turn off identify target for every single class just to handle one corner case. This flag would allow it for any classes. NOTE: I avoided putting it in with zdoom flags because if we upgrade, that becomes a headache. |
Watermelon (developer) 2014-06-30 19:29 |
Also, ignore me using two if blocks, that should be one block (I learned that doing 5 things at the same time is bad when coding) |
ZzZombo (reporter) 2014-07-02 07:57 |
I propose to tweak the code to DO NOT show the player name if the player is certainly not visible or below some low value of alpha (the latter can be a CVAR) regardless of this request or sv_noidentifytarget. |
Watermelon (developer) 2014-10-27 02:12 |
You should probably post that in another ticket, this one should be specifically for the flag. I think your idea is also good as well. |
Watermelon (developer) 2014-10-27 02:19 |
Code review please: 'https://bitbucket.org/ChrisKOmg/zandronum_stable/commits/06f43289210f442c7e0f39610a8041ea82094afa [^]' |
Dusk (developer) 2014-10-27 06:22 edited on: 2014-10-27 06:23 |
Why the two nested if-statements in src/g_shared/shared_sbar.cpp? It seems the code further in assumes that if pTargetPlayer is not NULL then pTargetPlayer->mo is not NULL either, so the first if statement could be left out altogether. Also, I'd call the flag "DONTIDENTIFY" to be more consistent with existing flags. |
Catastrophe (reporter) 2014-10-28 14:01 |
I'm okay with adding 'DONT' in place of 'NO'. However, 'Identify' sounds way too obscure. It should be more specific. |
Watermelon (developer) 2014-10-29 14:48 |
Updated and fixed old logic from many months ago that made me laugh when reading it... ah the good days of spamming if statements... :D |
Torr Samaho (administrator) 2014-11-01 10:32 |
Please include a history entry, then I can pull the patch. |
Watermelon (developer) 2014-11-01 17:39 |
Pull request updated |
cobalt (updater) 2014-11-01 18:04 |
Issue addressed by commit 13832dc1f36c: Added +DONTIDENTIFYTARGET flag that prevents player identification (fixes 1865). Committed by WChrisK [Watermelon] on Saturday 01 November 2014 13:38:43 Changes in files: docs/zandronum-history.txt | 1 + src/actor.h | 3 +++ src/g_shared/shared_sbar.cpp | 4 ++++ src/thingdef/thingdef_data.cpp | 1 + 4 files changed, 9 insertions(+), 0 deletions(-) |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | Esum |
Opponents: | No one explicitly opposes this issue yet. |
![]() |
|||
Date Modified | Username | Field | Change |
2014-06-30 19:22 | Catastrophe | New Issue | |
2014-06-30 19:23 | Watermelon | Note Added: 0009810 | |
2014-06-30 19:23 | Watermelon | Status | new => needs review |
2014-06-30 19:24 | Watermelon | File Added: noidentifytarget.diff | |
2014-06-30 19:25 | Watermelon | Note Edited: 0009810 | View Revisions |
2014-06-30 19:29 | Watermelon | Note Added: 0009812 | |
2014-07-02 07:57 | ZzZombo | Note Added: 0009820 | |
2014-07-05 10:15 | Torr Samaho | Product Version | 2.0-beta => 1.2 |
2014-10-27 02:12 | Watermelon | Note Added: 0010700 | |
2014-10-27 02:16 | Watermelon | Assigned To | => Watermelon |
2014-10-27 02:16 | Watermelon | Status | needs review => assigned |
2014-10-27 02:16 | Watermelon | Status | assigned => needs review |
2014-10-27 02:19 | Watermelon | Note Added: 0010701 | |
2014-10-27 06:22 | Dusk | Note Added: 0010702 | |
2014-10-27 06:23 | Dusk | Note Edited: 0010702 | View Revisions |
2014-10-28 14:01 | Catastrophe | Note Added: 0010707 | |
2014-10-29 14:48 | Watermelon | Note Added: 0010710 | |
2014-11-01 10:32 | Torr Samaho | Note Added: 0010757 | |
2014-11-01 10:35 | Torr Samaho | Status | needs review => feedback |
2014-11-01 17:39 | Watermelon | Note Added: 0010772 | |
2014-11-01 17:39 | Watermelon | Status | feedback => needs review |
2014-11-01 18:04 | cobalt | Status | needs review => needs testing |
2014-11-01 18:04 | cobalt | Target Version | => 1.4 |
2014-11-01 18:04 | cobalt | Note Added: 0010773 | |
2015-03-29 20:21 | Dusk | Status | needs testing => resolved |
2015-03-29 20:21 | Dusk | Fixed in Version | => 2.0 |
2015-03-29 20:21 | Dusk | Resolution | open => fixed |
2018-09-30 22:58 | Blzut3 | Status | resolved => closed |
Copyright © 2000 - 2025 MantisBT Team |