MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001865Zandronum[All Projects] Suggestionpublic2014-06-30 19:222018-09-30 22:58
ReporterCatastrophe 
Assigned ToWatermelon 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.2 
Target Version1.4Fixed in Version2.0 
Summary0001865: Add a +NOIDENTIFYTARGET flag to decorate.
DescriptionThis flag would be useful because certain mods only want certain classes to be unaffected by identify target (like creepers in gvh). However since we can't do that, we are forced to enable sv_noidentifytarget which instead affects all classes.
Steps To ReproduceAdding +NOIDENTIFYTARGET to a playerclass would stop the players name from appearing when you are aiming at them.
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff noidentifytarget.diff (1,606) 2014-06-30 19:24
/tracker/file_download.php?file_id=1239&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-06-30 19:22CatastropheNew Issue
2014-06-30 19:23WatermelonNote Added: 0009810
2014-06-30 19:23WatermelonStatusnew => needs review
2014-06-30 19:24WatermelonFile Added: noidentifytarget.diff
2014-06-30 19:25WatermelonNote Edited: 0009810bug_revision_view_page.php?bugnote_id=9810#r5248
2014-06-30 19:29WatermelonNote Added: 0009812
2014-07-02 07:57ZzZomboNote Added: 0009820
2014-07-05 10:15Torr SamahoProduct Version2.0-beta => 1.2
2014-10-27 02:12WatermelonNote Added: 0010700
2014-10-27 02:16WatermelonAssigned To => Watermelon
2014-10-27 02:16WatermelonStatusneeds review => assigned
2014-10-27 02:16WatermelonStatusassigned => needs review
2014-10-27 02:19WatermelonNote Added: 0010701
2014-10-27 06:22DuskNote Added: 0010702
2014-10-27 06:23DuskNote Edited: 0010702bug_revision_view_page.php?bugnote_id=10702#r5870
2014-10-28 14:01CatastropheNote Added: 0010707
2014-10-29 14:48WatermelonNote Added: 0010710
2014-11-01 10:32Torr SamahoNote Added: 0010757
2014-11-01 10:35Torr SamahoStatusneeds review => feedback
2014-11-01 17:39WatermelonNote Added: 0010772
2014-11-01 17:39WatermelonStatusfeedback => needs review
2014-11-01 18:04cobaltStatusneeds review => needs testing
2014-11-01 18:04cobaltTarget Version => 1.4
2014-11-01 18:04cobaltNote Added: 0010773
2015-03-29 20:21DuskStatusneeds testing => resolved
2015-03-29 20:21DuskFixed in Version => 2.0
2015-03-29 20:21DuskResolutionopen => fixed
2018-09-30 22:58Blzut3Statusresolved => closed

Notes
(0009810)
Watermelon   
2014-06-30 19:23   
(edited on: 2014-06-30 19:25)
I attached a diff.

This is not meant to be complete, since we need to take into account teams and such.

Please comment on this if it's okay.

The main reason this is brought up is that major wads like AoW and GvH use invisible classes, but you have to turn off identify target for every single class just to handle one corner case. This flag would allow it for any classes.


NOTE: I avoided putting it in with zdoom flags because if we upgrade, that becomes a headache.
(0009812)
Watermelon   
2014-06-30 19:29   
Also, ignore me using two if blocks, that should be one block (I learned that doing 5 things at the same time is bad when coding)
(0009820)
ZzZombo   
2014-07-02 07:57   
I propose to tweak the code to DO NOT show the player name if the player is certainly not visible or below some low value of alpha (the latter can be a CVAR) regardless of this request or sv_noidentifytarget.
(0010700)
Watermelon   
2014-10-27 02:12   
You should probably post that in another ticket, this one should be specifically for the flag. I think your idea is also good as well.
(0010701)
Watermelon   
2014-10-27 02:19   
Code review please:

'https://bitbucket.org/ChrisKOmg/zandronum_stable/commits/06f43289210f442c7e0f39610a8041ea82094afa [^]'
(0010702)
Dusk   
2014-10-27 06:22   
(edited on: 2014-10-27 06:23)
Why the two nested if-statements in src/g_shared/shared_sbar.cpp? It seems the code further in assumes that if pTargetPlayer is not NULL then pTargetPlayer->mo is not NULL either, so the first if statement could be left out altogether.

Also, I'd call the flag "DONTIDENTIFY" to be more consistent with existing flags.
(0010707)
Catastrophe   
2014-10-28 14:01   
I'm okay with adding 'DONT' in place of 'NO'. However, 'Identify' sounds way too obscure. It should be more specific.
(0010710)
Watermelon   
2014-10-29 14:48   
Updated and fixed old logic from many months ago that made me laugh when reading it... ah the good days of spamming if statements... :D
(0010757)
Torr Samaho   
2014-11-01 10:32   
Please include a history entry, then I can pull the patch.
(0010772)
Watermelon   
2014-11-01 17:39   
Pull request updated
(0010773)
cobalt   
2014-11-01 18:04   
Issue addressed by commit 13832dc1f36c: Added +DONTIDENTIFYTARGET flag that prevents player identification (fixes 1865).
Committed by WChrisK [Watermelon] on Saturday 01 November 2014 13:38:43

Changes in files:
 docs/zandronum-history.txt | 1 +
 src/actor.h | 3 +++
 src/g_shared/shared_sbar.cpp | 4 ++++
 src/thingdef/thingdef_data.cpp | 1 +
 4 files changed, 9 insertions(+), 0 deletions(-)