Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001819Zandronum[All Projects] Suggestionpublic2014-06-07 11:022015-07-21 13:07
ReporterJKist3 
Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0001819: block chat messages from individuals&groups
DescriptionYou should be able to block chat messages from individual players or groups of players (spectators for example). This is really important for competitive play because you need to see certain messages like obituaries and chat from team members for example, but these can get drowned out from spectator chat or you can just lose concentration from spectator chat (often there are a lot of spectators for big games).
Attached Files

- Relationships
duplicate of 0001400feedbackDusk Block spectators talk. 
has duplicate 0002353closed Allow client to hide\Ignore spectator messages 

-  Notes
User avatar (0008871)
Torr Samaho (administrator)
2014-06-07 15:06

 FYI, you already can block chat messages of individual players with the ignore and ignore_idx commands.
User avatar (0008872)
JKist3 (reporter)
2014-06-07 15:47

 thanks. I guess just spectator block needs to be added then
User avatar (0008874)
Watermelon (developer)
2014-06-07 18:10

 This is something I always wanted to add, spectators chatting while I was dueling non stop pissed me off. F8 sucks as an alternative since you can't see obituaries when you killed them.

I have an idea, hopefully will post a diff soon.
User avatar (0008876)
Watermelon (developer)
2014-06-07 18:36

 Need input:

'https://bitbucket.org/ChrisKOmg/zandronum/commits/476e77ebe8850e5724f4bba37edb85383d3b49f4 [^]'


Summary:
- Blocks spectator chat (but never yourself, even if you're a spec)
- Only blocks chat when GS_LEVEL is true
User avatar (0008904)
Torr Samaho (administrator)
2014-06-08 07:59

 The implementation looks reasonable, but I'm unsure about one thing: Do we really want to have CVAR_ARCHIVE on cl_mutespectators? With it, Zandronum will save the setting of cl_mutespectators, i.e. you set it to true once and spectators will be muted indefinitely till you manually change it back. I think it would be more reasonable if the value is not archived, so that it reverts to false when Zandronum is restarted. This way it's more in line with the ignore function.
User avatar (0008928)
Watermelon (developer)
2014-06-08 17:49

 Changed to no save:

'https://bitbucket.org/ChrisKOmg/zandronum/commits/68289d4dd5f789745996347ba55ac7ab8bc7d4a0 [^]'

Updated documents as well since I assume that with the above it's ready to be pulled?
User avatar (0008937)
Torr Samaho (administrator)
2014-06-08 21:10

 Looks good for 1.3.
User avatar (0008938)
Watermelon (developer)
2014-06-08 21:11

 If you want actually, I could add this to zandronum stable and then attempt a pull request.
User avatar (0008939)
Torr Samaho (administrator)
2014-06-08 21:20

 Sure, go ahead.
User avatar (0009686)
Watermelon (developer)
2014-06-22 22:37

 Pull request sent
User avatar (0009687)
Watermelon (developer)
2014-06-22 22:39

 Can you transplant this for me?

'https://bitbucket.org/ChrisKOmg/zandronum-stable/commits/52a7cd558ad00b2e6c164869d1d041b35713cb28 [^]'

I'll have to practice more on creating separate heads.
User avatar (0009710)
Dusk (developer)
2014-06-23 13:13

 Perhaps could instead mess with chat levels, split chat into normal and spec chat and then allow spectators to be muted by simply setting the proper message filter?
User avatar (0009715)
Torr Samaho (administrator)
2014-06-23 19:08

 Looking at the updated patch I wonder if
(players[ulPlayer].bSpectating || static_cast<int>(ulPlayer) != consoleplayer)

is wrong. Shouldn't this be && instead of ||? How thoroughly did you test this change? If I read the code correctly, it will block the chat of all other players no matter whether they are spectators or not.

Quote from Dusk
Perhaps could instead mess with chat levels, split chat into normal and spec chat and then allow spectators to be muted by simply setting the proper message filter?
Doesn't the ability to block spectators separately give you more flexibility?
User avatar (0009725)
Watermelon (developer)
2014-06-23 23:08

 Thats weird, it should be &&

I'll try it again and see if it works. What I put looks like it shouldn't work, I'll fix this up and re-submit.
User avatar (0010395)
Watermelon (developer)
2014-10-09 00:04

 Will check into this after completing some other tickets

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: Combinebobnt unknownna
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2014-06-07 11:02 JKist3 New Issue
2014-06-07 15:06 Torr Samaho Note Added: 0008871
2014-06-07 15:47 JKist3 Note Added: 0008872
2014-06-07 18:08 Watermelon Assigned To => Watermelon
2014-06-07 18:08 Watermelon Status new => assigned
2014-06-07 18:10 Watermelon Note Added: 0008874
2014-06-07 18:36 Watermelon Note Added: 0008876
2014-06-07 18:36 Watermelon Status assigned => needs review
2014-06-08 07:59 Torr Samaho Note Added: 0008904
2014-06-08 07:59 Torr Samaho Status needs review => feedback
2014-06-08 17:49 Watermelon Note Added: 0008928
2014-06-08 17:49 Watermelon Status feedback => needs review
2014-06-08 21:10 Torr Samaho Note Added: 0008937
2014-06-08 21:11 Watermelon Note Added: 0008938
2014-06-08 21:20 Torr Samaho Note Added: 0008939
2014-06-15 22:16 Watermelon Assigned To Watermelon =>
2014-06-15 22:16 Watermelon Status needs review => assigned
2014-06-15 22:17 Watermelon Assigned To => Watermelon
2014-06-22 22:37 Watermelon Note Added: 0009686
2014-06-22 22:37 Watermelon Status assigned => needs review
2014-06-22 22:39 Watermelon Note Added: 0009687
2014-06-23 13:13 Dusk Note Added: 0009710
2014-06-23 19:08 Torr Samaho Note Added: 0009715
2014-06-23 19:09 Torr Samaho Status needs review => feedback
2014-06-23 23:08 Watermelon Note Added: 0009725
2014-10-09 00:04 Watermelon Note Added: 0010395
2014-10-09 00:04 Watermelon Assigned To Watermelon =>
2014-10-09 00:04 Watermelon Status feedback => new
2015-07-21 13:01 unknownna Relationship added has duplicate 0002353
2015-07-21 13:07 unknownna Relationship added duplicate of 0001400




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker