MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001819Zandronum[All Projects] Suggestionpublic2014-06-07 11:022015-07-21 13:07
ReporterJKist3 
Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0001819: block chat messages from individuals&groups
DescriptionYou should be able to block chat messages from individual players or groups of players (spectators for example). This is really important for competitive play because you need to see certain messages like obituaries and chat from team members for example, but these can get drowned out from spectator chat or you can just lose concentration from spectator chat (often there are a lot of spectators for big games).
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
duplicate of 0001400feedback Dusk Block spectators talk. 
has duplicate 0002353closed  Allow client to hide\Ignore spectator messages 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-06-07 11:02JKist3New Issue
2014-06-07 15:06Torr SamahoNote Added: 0008871
2014-06-07 15:47JKist3Note Added: 0008872
2014-06-07 18:08WatermelonAssigned To => Watermelon
2014-06-07 18:08WatermelonStatusnew => assigned
2014-06-07 18:10WatermelonNote Added: 0008874
2014-06-07 18:36WatermelonNote Added: 0008876
2014-06-07 18:36WatermelonStatusassigned => needs review
2014-06-08 07:59Torr SamahoNote Added: 0008904
2014-06-08 07:59Torr SamahoStatusneeds review => feedback
2014-06-08 17:49WatermelonNote Added: 0008928
2014-06-08 17:49WatermelonStatusfeedback => needs review
2014-06-08 21:10Torr SamahoNote Added: 0008937
2014-06-08 21:11WatermelonNote Added: 0008938
2014-06-08 21:20Torr SamahoNote Added: 0008939
2014-06-15 22:16WatermelonAssigned ToWatermelon =>
2014-06-15 22:16WatermelonStatusneeds review => assigned
2014-06-15 22:17WatermelonAssigned To => Watermelon
2014-06-22 22:37WatermelonNote Added: 0009686
2014-06-22 22:37WatermelonStatusassigned => needs review
2014-06-22 22:39WatermelonNote Added: 0009687
2014-06-23 13:13DuskNote Added: 0009710
2014-06-23 19:08Torr SamahoNote Added: 0009715
2014-06-23 19:09Torr SamahoStatusneeds review => feedback
2014-06-23 23:08WatermelonNote Added: 0009725
2014-10-09 00:04WatermelonNote Added: 0010395
2014-10-09 00:04WatermelonAssigned ToWatermelon =>
2014-10-09 00:04WatermelonStatusfeedback => new
2015-07-21 13:01unknownnaRelationship addedhas duplicate 0002353
2015-07-21 13:07unknownnaRelationship addedduplicate of 0001400

Notes
(0008871)
Torr Samaho   
2014-06-07 15:06   
FYI, you already can block chat messages of individual players with the ignore and ignore_idx commands.
(0008872)
JKist3   
2014-06-07 15:47   
thanks. I guess just spectator block needs to be added then
(0008874)
Watermelon   
2014-06-07 18:10   
This is something I always wanted to add, spectators chatting while I was dueling non stop pissed me off. F8 sucks as an alternative since you can't see obituaries when you killed them.

I have an idea, hopefully will post a diff soon.
(0008876)
Watermelon   
2014-06-07 18:36   
Need input:

'https://bitbucket.org/ChrisKOmg/zandronum/commits/476e77ebe8850e5724f4bba37edb85383d3b49f4 [^]'


Summary:
- Blocks spectator chat (but never yourself, even if you're a spec)
- Only blocks chat when GS_LEVEL is true
(0008904)
Torr Samaho   
2014-06-08 07:59   
The implementation looks reasonable, but I'm unsure about one thing: Do we really want to have CVAR_ARCHIVE on cl_mutespectators? With it, Zandronum will save the setting of cl_mutespectators, i.e. you set it to true once and spectators will be muted indefinitely till you manually change it back. I think it would be more reasonable if the value is not archived, so that it reverts to false when Zandronum is restarted. This way it's more in line with the ignore function.
(0008928)
Watermelon   
2014-06-08 17:49   
Changed to no save:

'https://bitbucket.org/ChrisKOmg/zandronum/commits/68289d4dd5f789745996347ba55ac7ab8bc7d4a0 [^]'

Updated documents as well since I assume that with the above it's ready to be pulled?
(0008937)
Torr Samaho   
2014-06-08 21:10   
Looks good for 1.3.
(0008938)
Watermelon   
2014-06-08 21:11   
If you want actually, I could add this to zandronum stable and then attempt a pull request.
(0008939)
Torr Samaho   
2014-06-08 21:20   
Sure, go ahead.
(0009686)
Watermelon   
2014-06-22 22:37   
Pull request sent
(0009687)
Watermelon   
2014-06-22 22:39   
Can you transplant this for me?

'https://bitbucket.org/ChrisKOmg/zandronum-stable/commits/52a7cd558ad00b2e6c164869d1d041b35713cb28 [^]'

I'll have to practice more on creating separate heads.
(0009710)
Dusk   
2014-06-23 13:13   
Perhaps could instead mess with chat levels, split chat into normal and spec chat and then allow spectators to be muted by simply setting the proper message filter?
(0009715)
Torr Samaho   
2014-06-23 19:08   
Looking at the updated patch I wonder if
(players[ulPlayer].bSpectating || static_cast<int>(ulPlayer) != consoleplayer)

is wrong. Shouldn't this be && instead of ||? How thoroughly did you test this change? If I read the code correctly, it will block the chat of all other players no matter whether they are spectators or not.

Quote from Dusk
Perhaps could instead mess with chat levels, split chat into normal and spec chat and then allow spectators to be muted by simply setting the proper message filter?
Doesn't the ability to block spectators separately give you more flexibility?
(0009725)
Watermelon   
2014-06-23 23:08   
Thats weird, it should be &&

I'll try it again and see if it works. What I put looks like it shouldn't work, I'll fix this up and re-submit.
(0010395)
Watermelon   
2014-10-09 00:04   
Will check into this after completing some other tickets