0001774: Buffer overflow crash in release build compiled with GCC 4.8

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001774

Zandronum

[All Projects] Bug

public

2014-04-07 08:28

2018-09-30 21:36

Reporter

Edward-san

Assigned To

Torr Samaho

Priority

urgent

Severity

crash

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Linux

OS Version

Product Version

1.2

Target Version

1.3

Fixed in Version

1.3

Summary

0001774: Buffer overflow crash in release build compiled with GCC 4.8

Description

If zandronum is compiled with GCC 4.8, the release build will crash when trying to run a server. The crash happens in src/parsecontext.cpp, line 160:

strcpy (yylval->sym, token);

It happens because GCC 4.8 makes wrong assumptions regarding unions with char arrays (in the code FParseToken is an union with two char arrays); it was fixed in GCC 4.9 (see PR54570 ).

This bug showed up also in zdoom and was fixed with this commit. Applying the patch on the zandronum code makes the crash go away.

Steps To Reproduce

- Compile Zandronum with GCC 4.8
- Run 'zandronum -iwad doom2.wad -host'

Attached Files

Relationships

Notes
(0008515) Torr Samaho (administrator) 2014-04-07 20:54	I already backported the ZDoom fix to 2.0 a while ago and transplanted it to 1.3 now.

(0010012) Edward-san (developer) 2014-07-20 16:04	Works fine here.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2014-04-07 08:28	Edward-san	New Issue
2014-04-07 16:24	Edward-san	OS	=> Linux
2014-04-07 16:24	Edward-san	Product Version	=> 1.2
2014-04-07 20:54	Torr Samaho	Note Added: 0008515
2014-04-07 20:54	Torr Samaho	Assigned To	=> Torr Samaho
2014-04-07 20:54	Torr Samaho	Status	new => needs testing
2014-04-07 22:06	Dusk	View Status	private => public
2014-07-20 16:04	Edward-san	Note Added: 0010012
2014-07-20 16:04	Edward-san	Status	needs testing => resolved
2014-07-20 16:04	Edward-san	Fixed in Version	=> 1.3
2014-07-20 16:04	Edward-san	Resolution	open => fixed
2018-09-30 21:36	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.