0001763: botdebug_walktest = true crash flappy lost soul

Notes
(0008462) Dusk (developer) 2014-03-30 09:16	It's crashing because botdebug_walktest runs bot walk routines on the consoleplayer's camera, which in this case is not a player pawn even though it assumes it is. This mis-assumption causes a bad cast from AActor* to APlayerPawn*.

(0008469) ibm5155 (reporter) 2014-03-31 14:07	idk the structure but this wouldn't fix this? if(actual camera == player camera){ walktest code... }//when the camera is changed it doesn't enter on walktest

(0008470) Torr Samaho (administrator) 2014-03-31 17:22	Regarding your patch: You need to check ( players[consoleplayer].camera != NULL ) before you can access players[consoleplayer].camera->player. The old code properly checked the camera pointer before using it.

(0008490) Dusk (developer) 2014-04-03 22:04	amended

(0008498) Torr Samaho (administrator) 2014-04-05 08:38	When testing your updated patch I noticed that it changes the behavior of the code. Previously botdebug_walktest could be used from the player's view to determine what a bot would think about the path ahead. This is not possible anymore.

(0009613) Torr Samaho (administrator) 2014-06-21 13:45	More than two months have passed since I mentioned that the patch restricts the functionality of botdebug_walktest. So I went ahead and fixed the reason why BOTPATH_TryWalk crashed instead of trying not to call BOTPATH_TryWalk with parameters that could make it crash. This way botdebug_walktest can still be used as before and we avoid more potential crashes caused by BOTPATH_TryWalk.

(0009829) Arco (updater) 2014-07-03 19:40	Works correctly in V1.3 r140703-1806.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2014-03-28 14:45	ibm5155	New Issue
2014-03-28 14:45	ibm5155	File Added: CrashReport.zip
2014-03-30 09:16	Dusk	Note Added: 0008462
2014-03-30 09:16	Dusk	Status	new => confirmed
2014-03-30 20:57	Dusk	Assigned To	=> Dusk
2014-03-30 20:57	Dusk	Status	confirmed => needs review
2014-03-31 14:07	ibm5155	Note Added: 0008469
2014-03-31 17:22	Torr Samaho	Note Added: 0008470
2014-03-31 17:23	Torr Samaho	Status	needs review => feedback
2014-04-03 22:04	Dusk	Note Added: 0008490
2014-04-03 22:04	Dusk	Status	feedback => needs review
2014-04-05 08:38	Torr Samaho	Note Added: 0008498
2014-04-05 09:14	Torr Samaho	Status	needs review => feedback
2014-06-21 13:45	Torr Samaho	Note Added: 0009613
2014-06-21 13:45	Torr Samaho	Status	feedback => needs testing
2014-06-21 13:46	Torr Samaho	Target Version	=> 1.3
2014-07-03 19:40	Arco	Note Added: 0009829
2014-07-03 19:40	Arco	Fixed in Version	=> 1.3
2014-07-03 19:42	Dusk	Status	needs testing => resolved
2014-07-03 19:42	Dusk	Resolution	open => fixed
2018-09-30 21:36	Blzut3	Status	resolved => closed

Relationships