MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001763Zandronum[All Projects] Bugpublic2014-03-28 14:452018-09-30 21:36
Reporteribm5155 
Assigned ToDusk 
PrioritynormalSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
PlatformX64OS8.1OS Versionpro
Product Version1.2 
Target Version1.3Fixed in Version1.3 
Summary0001763: botdebug_walktest = true crash flappy lost soul
Descriptionwhen botdebug_walktest is set to true, if you try to play flappy lost soul it'll crash. (if you didn't start the flappy lost soul round it'll work)
Steps To ReproduceGoto console and write "botdebug_walktest 1"
Start the game.
Move or fire.
Wait for the message "ready, go!!"
Fatal Error.
Additional Informationmod link:http://static.best-ever.org/wads/fsoul_beta3.pk3
TagsNo tags attached.
Relationships
Attached Fileszip CrashReport.zip (21,309) 2014-03-28 14:45
/tracker/file_download.php?file_id=1187&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-03-28 14:45ibm5155New Issue
2014-03-28 14:45ibm5155File Added: CrashReport.zip
2014-03-30 09:16DuskNote Added: 0008462
2014-03-30 09:16DuskStatusnew => confirmed
2014-03-30 20:57DuskAssigned To => Dusk
2014-03-30 20:57DuskStatusconfirmed => needs review
2014-03-31 14:07ibm5155Note Added: 0008469
2014-03-31 17:22Torr SamahoNote Added: 0008470
2014-03-31 17:23Torr SamahoStatusneeds review => feedback
2014-04-03 22:04DuskNote Added: 0008490
2014-04-03 22:04DuskStatusfeedback => needs review
2014-04-05 08:38Torr SamahoNote Added: 0008498
2014-04-05 09:14Torr SamahoStatusneeds review => feedback
2014-06-21 13:45Torr SamahoNote Added: 0009613
2014-06-21 13:45Torr SamahoStatusfeedback => needs testing
2014-06-21 13:46Torr SamahoTarget Version => 1.3
2014-07-03 19:40ArcoNote Added: 0009829
2014-07-03 19:40ArcoFixed in Version => 1.3
2014-07-03 19:42DuskStatusneeds testing => resolved
2014-07-03 19:42DuskResolutionopen => fixed
2018-09-30 21:36Blzut3Statusresolved => closed

Notes
(0008462)
Dusk   
2014-03-30 09:16   
It's crashing because botdebug_walktest runs bot walk routines on the consoleplayer's camera, which in this case is not a player pawn even though it assumes it is. This mis-assumption causes a bad cast from AActor* to APlayerPawn*.
(0008469)
ibm5155   
2014-03-31 14:07   
idk the structure but this wouldn't fix this?
if(actual camera == player camera){
 walktest code...
}//when the camera is changed it doesn't enter on walktest
(0008470)
Torr Samaho   
2014-03-31 17:22   
Regarding your patch:

You need to check ( players[consoleplayer].camera != NULL ) before you can access players[consoleplayer].camera->player. The old code properly checked the camera pointer before using it.
(0008490)
Dusk   
2014-04-03 22:04   
amended
(0008498)
Torr Samaho   
2014-04-05 08:38   
When testing your updated patch I noticed that it changes the behavior of the code. Previously botdebug_walktest could be used from the player's view to determine what a bot would think about the path ahead. This is not possible anymore.
(0009613)
Torr Samaho   
2014-06-21 13:45   
More than two months have passed since I mentioned that the patch restricts the functionality of botdebug_walktest. So I went ahead and fixed the reason why BOTPATH_TryWalk crashed instead of trying not to call BOTPATH_TryWalk with parameters that could make it crash. This way botdebug_walktest can still be used as before and we avoid more potential crashes caused by BOTPATH_TryWalk.
(0009829)
Arco   
2014-07-03 19:40   
Works correctly in V1.3 r140703-1806.