| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0001719 | Zandronum | [All Projects] Bug | public | 2014-02-22 19:47 | 2014-06-15 15:29 |
|
| Reporter | AlexMax | |
| Assigned To | | |
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | no change required | |
| Platform | Microsoft | OS | Windows | OS Version | XP/Vista/7 |
| Product Version | 2.0-beta | |
| Target Version | | Fixed in Version | | |
|
| Summary | 0001719: Can't compile on Visual C++ Express 2005 without attached patch. |
| Description | I have attempted to compile trunk with Viausl C++ Express 2005 by following the instructions on the Wiki to a T and ran into two separate problems:
1. Many files would not compile due to an error C2733 described at the bottom of this wiki article:
'https://developer.valvesoftware.com/wiki/Compiling_under_VS2005 [^]'
There is no patch for this, because there's nothing in Zandronum to fix, unless you know some clever way to fix this without having to modify the Visual Studio header file yourself.
2. maprotation.cpp would not compile, period. The full details of the error and the suggestion solution are here:
'http://support.microsoft.com/kb/922317/en-us [^]'
To fix it, see attached patch. Note that this patch was not necessary for me on Visual C++ Express 2013, but I'm not exactly sure what is going on with the fix and what versions is is/is not necessary on, so the proper pragmas to use are left as an exercise to the patcher, as I am unfamiliar with them. Perhaps you might want to remove the comment as well, as it was written in a fit of disbelief and despair. :) |
|
| Attached Files |  zan_20_vs2005_express_fix_C2059.patch [^] (666 bytes) 2014-02-22 19:47 [Show Content] [Hide Content]diff -r 8c120f4cb271 src/maprotation.cpp
--- a/src/maprotation.cpp Sun Feb 09 22:22:26 2014 +0100
+++ b/src/maprotation.cpp Sat Feb 22 14:34:47 2014 -0500
@@ -47,6 +47,16 @@
//
//-----------------------------------------------------------------------------
+// [AM] No words. Should have sent a poet. Specifically, Edgar Allan Poe.
+// http://support.microsoft.com/kb/922317/en-us
+#pragma push_macro("_dupenv_s")
+#pragma push_macro("_wdupenv_s")
+#undef _dupenv_s
+#undef _wdupenv_s
+#include <stdlib.h>
+#pragma pop_macro("_dupenv_s")
+#pragma pop_macro("_wdupenv_s")
+
#include <string.h>
#include <vector>
#include "c_cvars.h"
|
|
Chat on our Discord Server
Get the latest version: 3.2
Relationships 
Relationships 
(0009425)
ZDoom
Doom Wiki
id Software
Doomworld
Odamex
Doomseeker
Internet Doom Explorer
The Sentinel's Playground Servers