Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001670Zandronum[All Projects] Suggestionpublic2014-01-16 23:022018-09-30 22:00
ReporterBeed28 
Assigned ToTorr Samaho 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS Version8.1
Product Version1.2 
Target Version3.0Fixed in Version3.0 
Summary0001670: Increase the limit of bots that can be defined
DescriptionOur mod (the name of which I'm withholding out of fear of causing a flame war) is coming dangerously close to hitting the hard limit Zandronum imposes on the number of bots that can be defined, which after testing, appears to be 128. A later update to the coremod later this year will add even more bots. There is a mod released for it that adds loads of custom classes for it, each coming with a retrospective bot. However, when I have a few custom bots using custom skins defined, some of the bots for said classes mod won't appear, as in they can't be added through the console or even shown up in the bot setup menu in the Offline Skirmish menu.
Attached Files

- Relationships

-  Notes
User avatar (0008040)
Dusk (developer)
2014-01-17 11:04
edited on: 2014-01-17 11:05

 I think the proper solution here would be to make g_BotInfo a TArray and remove the limit completely.

EDIT: or hrm, if the botinfo index is ever sent to the client we might have to still keep the limit to some degree.

Quote
(the name of which I'm withholding out of fear of causing a flame war)

I don't think one should need to censor out information to avoid flamewars. If anyone stirs up shit it will just be deleted.
User avatar (0008042)
Beed28 (reporter)
2014-01-17 15:26

 Alright. The mod I was talking about was MM8BDM-v3b, which has tons and tons of skins, most of which have their own bots. There is a side mod released for it called CSCC (Cutstuff Community Classes) that adds many unique classes to it, each with their own bot as well.

However, I load MM8BDM with several bots of my own using skins I downloaded as well, and with at least 8 custom bots, I hit the limit when adding CSCC, and thus the last three bots defined in CSCC fail to show up.
User avatar (0009407)
Watermelon (developer)
2014-06-15 15:01

 Same in 2.0?
User avatar (0015155)
Celebi (reporter)
2016-06-30 12:43

 There is still a limit of 128 defined bots in Zandronum 3.0-alpha-160519-2047.
User avatar (0015166)
Torr Samaho (administrator)
2016-07-02 12:13

 I made an experimental build that uses a TArray for g_BotInfo. Please test if successfully removes that limit.
User avatar (0015197)
Celebi (reporter)
2016-07-02 21:01

 Using that build, I checked 1000+ different bot defines in a BOTINFO and there were no issues for any of them.
User avatar (0015207)
WaTaKiD (updater)
2016-07-03 15:59

 i tried building'https://bitbucket.org/Torr_Samaho/zandronum/commits/88e532d74d73e09ebd1312aeef55fcaf887d6985 [^]'

but i got an error:

Error C2065 'MAX_BOTINFO': undeclared identifier zdoom C:\ZanSrc\zandronum\src\menu\menudef.cpp 1419
User avatar (0015208)
Torr Samaho (administrator)
2016-07-03 16:16

 Thanks for the info! Something seems to be wrong with VC++'s or CMake's dependency handling. VC++ didn't recompile menudef.cpp after I removed MAX_BOTINFO, so it didn't complain for me about the missing define. Anyway, should be fixed now.
User avatar (0015493)
Combinebobnt (reporter)
2016-08-18 18:45

 tested with 160814-2010, defined 200+ bots, and was able to add the last ones defined.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Combinebobnt Celebi
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2014-01-16 23:02 Beed28 New Issue
2014-01-17 11:04 Dusk Note Added: 0008040
2014-01-17 11:05 Dusk Note Edited: 0008040 View Revisions
2014-01-17 15:26 Beed28 Note Added: 0008042
2014-01-18 10:32 Torr Samaho Product Version 2.0-beta => 1.2
2014-06-15 15:01 Watermelon Note Added: 0009407
2014-06-15 15:01 Watermelon Status new => feedback
2016-06-30 12:43 Celebi Note Added: 0015155
2016-07-02 12:13 Torr Samaho Note Added: 0015166
2016-07-02 13:30 Torr Samaho Assigned To => Torr Samaho
2016-07-02 13:30 Torr Samaho Status feedback => assigned
2016-07-02 13:30 Torr Samaho Status assigned => feedback
2016-07-02 21:01 Celebi Note Added: 0015197
2016-07-03 15:59 WaTaKiD Note Added: 0015207
2016-07-03 16:16 Torr Samaho Note Added: 0015208
2016-07-30 21:28 Dusk Status feedback => needs testing
2016-08-18 18:45 Combinebobnt Note Added: 0015493
2016-08-18 21:24 Ru5tK1ng Status needs testing => resolved
2016-08-18 21:24 Ru5tK1ng Resolution open => fixed
2016-08-18 21:24 Ru5tK1ng Fixed in Version => 3.0
2016-08-18 21:24 Ru5tK1ng Target Version => 3.0
2018-09-30 22:00 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker