Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001653Zandronum[All Projects] Bugpublic2014-01-10 20:182018-09-30 22:41
Reportersomeoneelse 
Assigned ToDusk 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version2.0-beta 
Target Version1.3Fixed in Version 
Summary0001653: Shared keys only are shared when there are players on a server
DescriptionUnlike sharedkeys.wad the Zandronum option "forgets" keys if there's no one on the server. But because if a key is taken, most often it means the area leading to the key is already cleared, I think having keys even if the server is empty would spare the player the necessity of running around the big, empty areas to gather the keys. (Also, sometimes people reconnect to the same server for various reasons).
I'm not sure if it was made like this or purpose, or rather a bug, but anyway, I am reporting.
Attached Files

- Relationships
related to 0001769closedDusk Shared keys stay after map reset in survival 

-  Notes
User avatar (0007943)
Dusk (developer)
2014-01-10 21:14

 this is kind of semi-intentional, I was aware of this when I first wrote the feature but figured to do nothing about it. The behavior can of course be changed though.
User avatar (0007944)
someoneelse (reporter)
2014-01-10 22:25
edited on: 2014-06-08 16:16

 I guess it would be very nice, for the reasons I stated in a main post... It's sure better to be able to jump right into the action when joining abandoned game, than run around and admire dead bodies while searching for a key :)
User avatar (0008844)
Dusk (developer)
2014-06-04 16:07
edited on: 2014-06-08 16:16

 'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/35/shared-keys-largely-rewritten [^]'
User avatar (0008859)
Torr Samaho (administrator)
2014-06-07 09:39
edited on: 2014-06-08 16:16

 Two things I noticed:

- I'm wondering if it's correct to call SERVER_SyncSharedKeys in P_SpawnPlayer in case bClientUpdate is false. P_SpawnPlayer will not tell the clients to spawn the player in this case, but SERVER_SyncSharedKeys will tell the clients to give the keys to the player that they didn't even spawn.

- __func__ is not supported under VC++, so the error message in sv_main.cpp needs to be adjusted.
User avatar (0008862)
Dusk (developer)
2014-06-07 10:39
edited on: 2014-06-08 16:16
Quote
I'm wondering if it's correct to call SERVER_SyncSharedKeys in P_SpawnPlayer in case bClientUpdate is false.

Hrm. Probably is not. I'll amend this.

Quote
- __func__ is not supported under VC++, so the error message in sv_main.cpp needs to be adjusted.

:-|.
edit: ah, it was only standardized in C++11..
User avatar (0008910)
Dusk (developer)
2014-06-08 11:35
edited on: 2014-06-08 16:16

 Please review/pull this:'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/43 [^]'

This is the value tracking part of the dmflags difference thing. I could use it here as well to suppress needless messages.
User avatar (0008914)
Torr Samaho (administrator)
2014-06-08 13:17
edited on: 2014-06-08 16:16
Quote from Dusk
Please review/pull this:https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/43

Done.
User avatar (0008916)
Dusk (developer)
2014-06-08 13:34
edited on: 2014-06-08 16:16

 And here's the real thing now:
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/44 [^]'
User avatar (0008919)
Torr Samaho (administrator)
2014-06-08 14:13
edited on: 2014-06-08 16:16

 It would be better to call "g_keysFound.Clear()" in GAME_ResetMap() instead of
SURVIVAL_DoFight. This way the keys are properly cleared no matter which game mode reset the map or if the reset was made in *_DoFight or because a mod called ResetMap.
User avatar (0008924)
Dusk (developer)
2014-06-08 16:16
edited on: 2014-06-08 16:45

 'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/46 [^]'

edit: ouch! a python accident happened and all notes got no-op edits.
User avatar (0008932)
Torr Samaho (administrator)
2014-06-08 19:11

 Pulled.
User avatar (0008943)
Arco (updater)
2014-06-08 22:36

 Works correctly in r140608-2119.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Wirtualnosc Zalewa President People
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2014-01-10 20:18 someoneelse New Issue
2014-01-10 21:14 Dusk Note Added: 0007943
2014-01-10 22:25 someoneelse Note Added: 0007944
2014-01-10 22:26 someoneelse Note Edited: 0007944 View Revisions
2014-04-09 20:08 Dusk Relationship added related to 0001769
2014-04-09 23:27 Dusk Assigned To => Dusk
2014-04-09 23:27 Dusk Status new => assigned
2014-06-04 16:07 Dusk Note Added: 0008844
2014-06-04 16:07 Dusk Status assigned => needs review
2014-06-04 17:30 Dusk Target Version => 1.3
2014-06-07 09:39 Torr Samaho Note Added: 0008859
2014-06-07 09:39 Torr Samaho Status needs review => feedback
2014-06-07 10:39 Dusk Note Added: 0008862
2014-06-07 10:43 Dusk Status feedback => assigned
2014-06-07 10:44 Dusk Note Edited: 0008862 View Revisions
2014-06-08 11:35 Dusk Note Added: 0008910
2014-06-08 11:35 Dusk Status assigned => needs review
2014-06-08 12:34 Dusk Status needs review => assigned
2014-06-08 13:17 Torr Samaho Note Added: 0008914
2014-06-08 13:34 Dusk Note Added: 0008916
2014-06-08 13:34 Dusk Status assigned => needs review
2014-06-08 14:13 Torr Samaho Note Added: 0008919
2014-06-08 14:15 Torr Samaho Status needs review => feedback
2014-06-08 14:27 Dusk Status feedback => assigned
2014-06-08 16:16 Dusk Note Edited: 0008859 View Revisions
2014-06-08 16:16 Dusk Note Edited: 0008862 View Revisions
2014-06-08 16:16 Dusk Note Edited: 0008910 View Revisions
2014-06-08 16:16 Dusk Note Edited: 0008914 View Revisions
2014-06-08 16:16 Dusk Note Edited: 0008916 View Revisions
2014-06-08 16:16 Dusk Note Edited: 0008919 View Revisions
2014-06-08 16:16 Dusk Status assigned => needs review
2014-06-08 16:16 Dusk Description Updated View Revisions
2014-06-08 16:16 Dusk Note Added: 0008924
2014-06-08 16:45 Dusk Note Edited: 0008924 View Revisions
2014-06-08 19:11 Torr Samaho Note Added: 0008932
2014-06-08 19:13 Torr Samaho Status needs review => needs testing
2014-06-08 22:36 Arco Note Added: 0008943
2014-06-08 22:36 Arco Status needs testing => resolved
2014-06-08 22:36 Arco Resolution open => fixed
2014-06-08 22:36 Arco Description Updated View Revisions
2018-09-30 22:41 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker