0001638: Rejection of invalid client pong responses

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001638

Zandronum

[All Projects] Suggestion

public

2014-01-02 22:24

2014-03-30 20:38

Reporter

AlienOverlord

Assigned To

Priority

low

Severity

tweak

Reproducibility

always

Status

closed

Resolution

not fixable

Platform

Microsoft

Windows

OS Version

XP/Vista/7

Product Version

1.2

Target Version

1.3

Fixed in Version

Summary

0001638: Rejection of invalid client pong responses

Description

Since the server is sending it's current millisecond time to the client, the client can then alter this time and send it back to the server, thus altering it's displayed ping. Although that doesn't really change anything gameplay-wise (other than teleportation reaction time, of course) I highly doubt that it's a valid approach to allow clients to manipulate anything at random will.

The suggestion itself: keep the log of last 30 ping requests, compare pong that comes from the client with what the server has sent, reject invalid responses.

Attached Files

Relationships

related to

0001705

closed

Watermelon

Gametic-based unlagged

Notes
(0008006) Llewellyn (reporter) 2014-01-14 20:22	So the server is supposed to ignore your responses if your ping spikes?

(0008008) Konar6 (reporter) 2014-01-14 21:31	The server should calculate pings on its own by subtracting the client's pong reply delay. I thought this was the case. :o

(0008187) Jen0va (reporter) 2014-02-10 22:41 edited on: 2014-02-10 22:56	Setting my ping to 200 using a custom client gave me a pretty large advantage and let me almost land any shot (even ones that missed). Just throwing this in there. I should probably elaborate that I think around 200ms is kind of a sweet spot where you have a wider target because of unlagged.

(0008466) Dusk (developer) 2014-03-30 20:35 edited on: 2014-03-30 20:38	The client can just spoof the ping anyway by delaying the ping response. Not much we can do here.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2014-01-02 22:24	AlienOverlord	New Issue
2014-01-14 20:22	Llewellyn	Note Added: 0008006
2014-01-14 21:31	Konar6	Note Added: 0008008
2014-02-10 22:41	Jen0va	Note Added: 0008187
2014-02-10 22:43	Dusk	Assigned To	=> Dusk
2014-02-10 22:43	Dusk	Status	new => assigned
2014-02-10 22:44	Dusk	Target Version	=> 1.3
2014-02-10 22:56	Jen0va	Note Edited: 0008187	View Revisions
2014-02-11 00:34	Dusk	Status	assigned => needs review
2014-02-18 15:03	Dusk	Relationship added	related to 0001705
2014-03-30 20:35	Dusk	Note Added: 0008466
2014-03-30 20:35	Dusk	Status	needs review => closed
2014-03-30 20:35	Dusk	Assigned To	Dusk =>
2014-03-30 20:35	Dusk	Resolution	open => not fixable
2014-03-30 20:38	Dusk	Note Edited: 0008466	View Revisions

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.