0001607: Check SBARINFO implementation

(0007705)
Blzut3 (administrator)
2013-12-17 21:53
edited on: 2013-12-17 21:55

Regarding item 2, everything seems to work as intended, however please back port r3065 to fix an easy to reproduce crash I got while testing this.

Edit: Also the diff you mention appears to be missing.

(0007715)
Torr Samaho (administrator)
2013-12-19 17:37

Sorry for my ambiguous formulation. I didn't attach the diff itself, but the files that need to be diffed to see the extra code.

(0007749)
Blzut3 (administrator)
2013-12-28 07:50
edited on: 2013-12-28 07:53

Doesn't change that there are no files attached... I just took care of that myself.

Ignoring the whole ST alternative hud for a moment, the difference in the Doom status bar itself is pretty small. The rune icon was added (already supported with our sbarinfo changes), the frags count on the hud is changed to a generic score, and the points graphic is added to the normal status bar. Those last two changes probably would be best addressed with another extension to the gamemode command which allows detection of flags.

There does however, appear to be one other issue that seems like it should just be part of the standard hud: The CTF/ST team scoreboard. If it was my decision I would just scratch the graphical version and just use the generic scoreboard used in team dm for these modes as well. In my opinion, the conditional change isn't worth the extra delta, but if we want to keep it the best solution would be to add another status bar type which overlays (and replaces the generic score board) if present and applicable.

This leaves the issue of the skulltag hud. Should we keep this? I think the best way to handle that would be to implement it like the GZDoom althud and have it override SBARINFO. The downside to that, however, is that having it enabled by default would mean no one would see full screen SBARINFO huds. For the most part it's a minor tweak (font change) to the standard ZDoom hud so I'm not sure I see the point in keeping it around.

The Heretic and Hexen status bars have the same changes: Calling the function to get the CTF/ST scoreboard and the frag count on the hud being changed to display the proper score instead of just frags. Same solution would apply.

(0015088)
StrikerMan780 (reporter)
2016-06-17 21:36
edited on: 2016-06-17 21:36

After some testing, I found that RuneIcon no longer works. This is in the latest Zandronum 3.0 build.

(0015093)
Edward-san (developer)
2016-06-18 08:54

Can you show an example wad exhibiting the problem? Imho it has to do with the Rune rewrite, ie 0002137 .

(0015105)
StrikerMan780 (reporter)
2016-06-24 18:34
edited on: 2016-06-24 18:41

Done. Sorry it took so long. Just load it, give yourself a rune in the fullscreen hud, and it'll show up in the top left corner.

By the way, the Rune icons are missing from the stock HUD. Older versions of ST/Zan had it. (Before 2.0, afaik).

Also, in response to Blzut3, I can't speak for anyone else, but I think the ST HUD is fugly, I wouldn't care if it disappeared.

(0015122)
Torr Samaho (administrator)
2016-06-26 12:16
edited on: 2016-06-26 12:22

I can confirm that sbarinfo_test.pk3 works in 2.1.2, but not in 3.0. I'll look into it.

EDIT: RuneIcon should work again in 3.0.

(0015137)
StrikerMan780 (reporter)
2016-06-26 21:20
edited on: 2016-06-26 21:20

Ok, awesome. Thanks for the fix. Got a test build so I can continue work on my HUD?

(0015167)
Torr Samaho (administrator)
2016-07-02 12:14

Here is a test build that I made for another purpose, but it also includes the RuneIcon fix.

(0015174)
WaTaKiD (updater)
2016-07-02 15:38

RuneIcon fix added in 3.0 here:'https://bitbucket.org/Torr_Samaho/zandronum/commits/e7c11b562d728986f6728517a325634a61042022 [^]'

(0015201)
StrikerMan780 (reporter)
2016-07-03 01:27
edited on: 2016-07-03 01:28

Tested. Works for most runes except the spread rune, regeneration, and reflection runes.

(0015204)
Torr Samaho (administrator)
2016-07-03 11:05

I just tested the spread rune and it works fine for me in your example wad. Can you give me a detailed description on how to reproduce the problem with the spread rune?

(0016128)
Blzut3 (administrator)
2016-10-30 21:46

Noting here in regards to the ST hud from IRC meeting: It is preferable at this time to change the default to the standard ZDoom hud and migrate the ST hud to a second alt hud (following standard alt hud semantics of overriding SBarInfo).

(0016690)
StrikerMan780 (reporter)
2017-01-26 02:33
edited on: 2017-01-28 16:42

Never mind, it just seems to be behaving weird due to the sprite offsets of the spread rune on my end. This can be closed.

(0016708)
Edward-san (developer)
2017-01-28 19:10

Wait, the SBARINFO conversion is not done yet. This runeicon issue should've been moved to another ticket.

Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2013-12-08 08:09	Torr Samaho	New Issue
2013-12-08 08:09	Torr Samaho	Status	new => assigned
2013-12-08 08:09	Torr Samaho	Assigned To	=> Blzut3
2013-12-17 21:53	Blzut3	Note Added: 0007705
2013-12-17 21:55	Blzut3	Note Edited: 0007705	View Revisions
2013-12-19 14:22	Dusk	View Status	private => public
2013-12-19 17:37	Torr Samaho	Note Added: 0007715
2013-12-28 07:50	Blzut3	Note Added: 0007749
2013-12-28 07:53	Blzut3	Note Edited: 0007749	View Revisions
2015-03-29 19:10	Dusk	Target Version	2.0 => 2.1
2015-06-24 22:44	Dusk	Target Version	2.1 => 2.2
2016-06-17 21:36	StrikerMan780	Note Added: 0015088
2016-06-17 21:36	StrikerMan780	Note Edited: 0015088	View Revisions
2016-06-18 08:54	Edward-san	Note Added: 0015093
2016-06-24 18:27	StrikerMan780	File Added: sbarinfo_test.pk3
2016-06-24 18:34	StrikerMan780	Note Added: 0015105
2016-06-24 18:34	StrikerMan780	Note Edited: 0015105	View Revisions
2016-06-24 18:34	StrikerMan780	Note Edited: 0015105	View Revisions
2016-06-24 18:41	StrikerMan780	Note Edited: 0015105	View Revisions
2016-06-26 12:16	Torr Samaho	Note Added: 0015122
2016-06-26 12:22	Torr Samaho	Note Edited: 0015122	View Revisions
2016-06-26 12:23	Torr Samaho	Status	assigned => needs testing
2016-06-26 21:20	StrikerMan780	Note Added: 0015137
2016-06-26 21:20	StrikerMan780	Note Edited: 0015137	View Revisions
2016-07-02 12:14	Torr Samaho	Note Added: 0015167
2016-07-02 15:38	WaTaKiD	Note Added: 0015174
2016-07-03 01:27	StrikerMan780	Note Added: 0015201
2016-07-03 01:28	StrikerMan780	Note Edited: 0015201	View Revisions
2016-07-03 11:05	Torr Samaho	Note Added: 0015204
2016-10-30 21:46	Blzut3	Note Added: 0016128
2017-01-26 02:18	StrikerMan780	Note Added: 0016689
2017-01-26 02:24	StrikerMan780	Note Deleted: 0016689
2017-01-26 02:33	StrikerMan780	Note Added: 0016690
2017-01-28 16:42	StrikerMan780	Note Edited: 0016690	View Revisions
2017-01-28 17:27	Ru5tK1ng	Status	needs testing => resolved
2017-01-28 17:27	Ru5tK1ng	Resolution	open => fixed
2017-01-28 17:27	Ru5tK1ng	Fixed in Version	=> 3.0
2017-01-28 17:27	Ru5tK1ng	Target Version	2.2 => 3.0
2017-01-28 19:10	Edward-san	Note Added: 0016708
2017-01-28 19:10	Edward-san	Status	resolved => assigned

Notes
(0007705) Blzut3 (administrator) 2013-12-17 21:53 edited on: 2013-12-17 21:55	Regarding item 2, everything seems to work as intended, however please back port r3065 to fix an easy to reproduce crash I got while testing this. Edit: Also the diff you mention appears to be missing.

(0007715) Torr Samaho (administrator) 2013-12-19 17:37	Sorry for my ambiguous formulation. I didn't attach the diff itself, but the files that need to be diffed to see the extra code.

(0007749) Blzut3 (administrator) 2013-12-28 07:50 edited on: 2013-12-28 07:53	Doesn't change that there are no files attached... I just took care of that myself. Ignoring the whole ST alternative hud for a moment, the difference in the Doom status bar itself is pretty small. The rune icon was added (already supported with our sbarinfo changes), the frags count on the hud is changed to a generic score, and the points graphic is added to the normal status bar. Those last two changes probably would be best addressed with another extension to the gamemode command which allows detection of flags. There does however, appear to be one other issue that seems like it should just be part of the standard hud: The CTF/ST team scoreboard. If it was my decision I would just scratch the graphical version and just use the generic scoreboard used in team dm for these modes as well. In my opinion, the conditional change isn't worth the extra delta, but if we want to keep it the best solution would be to add another status bar type which overlays (and replaces the generic score board) if present and applicable. This leaves the issue of the skulltag hud. Should we keep this? I think the best way to handle that would be to implement it like the GZDoom althud and have it override SBARINFO. The downside to that, however, is that having it enabled by default would mean no one would see full screen SBARINFO huds. For the most part it's a minor tweak (font change) to the standard ZDoom hud so I'm not sure I see the point in keeping it around. The Heretic and Hexen status bars have the same changes: Calling the function to get the CTF/ST scoreboard and the frag count on the hud being changed to display the proper score instead of just frags. Same solution would apply.

(0015088) StrikerMan780 (reporter) 2016-06-17 21:36 edited on: 2016-06-17 21:36	After some testing, I found that RuneIcon no longer works. This is in the latest Zandronum 3.0 build.

(0015093) Edward-san (developer) 2016-06-18 08:54	Can you show an example wad exhibiting the problem? Imho it has to do with the Rune rewrite, ie 0002137 .

(0015105) StrikerMan780 (reporter) 2016-06-24 18:34 edited on: 2016-06-24 18:41	Done. Sorry it took so long. Just load it, give yourself a rune in the fullscreen hud, and it'll show up in the top left corner. By the way, the Rune icons are missing from the stock HUD. Older versions of ST/Zan had it. (Before 2.0, afaik). Also, in response to Blzut3, I can't speak for anyone else, but I think the ST HUD is fugly, I wouldn't care if it disappeared.

(0015122) Torr Samaho (administrator) 2016-06-26 12:16 edited on: 2016-06-26 12:22	I can confirm that sbarinfo_test.pk3 works in 2.1.2, but not in 3.0. I'll look into it. EDIT: RuneIcon should work again in 3.0.

(0015137) StrikerMan780 (reporter) 2016-06-26 21:20 edited on: 2016-06-26 21:20	Ok, awesome. Thanks for the fix. Got a test build so I can continue work on my HUD?

(0015167) Torr Samaho (administrator) 2016-07-02 12:14	Here is a test build that I made for another purpose, but it also includes the RuneIcon fix.

(0015174) WaTaKiD (updater) 2016-07-02 15:38	RuneIcon fix added in 3.0 here:'https://bitbucket.org/Torr_Samaho/zandronum/commits/e7c11b562d728986f6728517a325634a61042022 [^]'

(0015201) StrikerMan780 (reporter) 2016-07-03 01:27 edited on: 2016-07-03 01:28	Tested. Works for most runes except the spread rune, regeneration, and reflection runes.

(0015204) Torr Samaho (administrator) 2016-07-03 11:05	I just tested the spread rune and it works fine for me in your example wad. Can you give me a detailed description on how to reproduce the problem with the spread rune?

(0016128) Blzut3 (administrator) 2016-10-30 21:46	Noting here in regards to the ST hud from IRC meeting: It is preferable at this time to change the default to the standard ZDoom hud and migrate the ST hud to a second alt hud (following standard alt hud semantics of overriding SBarInfo).

(0016690) StrikerMan780 (reporter) 2017-01-26 02:33 edited on: 2017-01-28 16:42	Never mind, it just seems to be behaving weird due to the sprite offsets of the spread rune on my end. This can be closed.

(0016708) Edward-san (developer) 2017-01-28 19:10	Wait, the SBARINFO conversion is not done yet. This runeicon issue should've been moved to another ticket.

Relationships