0001579: Make it to where you can still use DoomSeeker while WadSeeker is getting Wads

Notes
(0008500) Zalewa (developer) 2014-04-05 12:00	I think that if we want to detach Wadseeker window so that it doesn't block the main program then we also should change how games are started after Wadseeker completes. Currently, if Wadseeker is successful, the game will start outright, and this may interfere with user activites. Perhaps it would be better to display a system global popup message to notify the user that the downloads have finished and then await confirmation before launching the actual game. I'm not sure if Qt provides any means to display OS global message as every OS does this a bit differently - Ubuntu has its notifier, Windows has the tray or basically whatever kind of interference you may imagine and program, and I know nothing about Mac.

(0008501) Blzut3 (administrator) 2014-04-05 15:58 edited on: 2014-04-05 15:59	The Mac doesn't really have much. I would probably recommend popping up a normal message box when downloads are complete and the Wadseeker window is inactive to confirm that the user still wishes to join. For system notifications there's QSystemTrayIcon::showMessage which works on Windows and a few Mac systems. For Linux you need to work with libnotify to get that functionality. (Odd that Qt hasn't added that yet.) If Doomseeker is completely inactive you can use QApplication::alert() to highlight the application in the task bar. This works on all platforms. Edit: And just as I post this, I remembered that recent versions of OS X have a notifications system. But that would lock us into recent versions of OS X and we'd have to write some Objective-C code to get at it.

(0008502) Zalewa (developer) 2014-04-06 10:50	Changes, changes, changes... Now, as Wadseeker no longer blocks the program there's a new problem where users may start to spam server joins which will result in multiple Wadseekers working at once. This can lead to numerous problems: network connection hogging, web services refusing connections due to too many requests, and the same WAD being downloaded more than once. I'm not sure if we want to spend extra time on developing a synchronization process between multiple windows, as this may require some reworks to Wadseeker library itself. Perhaps it would be a good idea to somehow prevent multiple Wadseeker windows being open at once? In such case what should happen when user tries to join another server for which they don't have WADs? Should the attempt be simply cancelled with proper warning message? It's also assumed that if user tries to join a server where they have all the WADs then join should proceed as usual.

(0008505) Blzut3 (administrator) 2014-04-06 15:19	I think it would be reasonable to limit Doomseeker to waiting for wads to download for one server. I would imagine the main reason the OP and others want this feature is so that they can continue to use IRC while a file is being downloaded. Being able to join a server that you already have the wads for in the mean time would just be a bonus. In that case the solution would be to just have an error "You do not have all the files required to join this server. In addition, Wadseeker is already busy handling another request. Either wait until that transfer is complete or cancel."

(0008512) Zalewa (developer) 2014-04-07 19:16	Done: 'https://bitbucket.org/Blzut3/doomseeker/commits/fc52b7231bccd6b95fa2fb668b72ddc709e3e480 [^]'

(0008516) Zalewa (developer) 2014-04-07 21:49	Update available on beta update channel and on DRD team page. Please test.

(0008577) DevilHunter (reporter) 2014-04-15 00:30	Works just fine. Warns me if Wadseeker is already running.

This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	Zalewa Absolute Zero
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2013-11-14 09:55	DevilHunter	New Issue
2014-04-05 12:00	Zalewa	Note Added: 0008500
2014-04-05 15:58	Blzut3	Note Added: 0008501
2014-04-05 15:59	Blzut3	Note Edited: 0008501	View Revisions
2014-04-06 10:25	Zalewa	Assigned To	=> Zalewa
2014-04-06 10:25	Zalewa	Status	new => assigned
2014-04-06 10:50	Zalewa	Note Added: 0008502
2014-04-06 10:50	Zalewa	Status	assigned => feedback
2014-04-06 15:19	Blzut3	Note Added: 0008505
2014-04-07 05:25	Zalewa	Status	feedback => assigned
2014-04-07 19:16	Zalewa	Note Added: 0008512
2014-04-07 19:16	Zalewa	Status	assigned => needs review
2014-04-07 19:16	Zalewa	Target Version	=> 0.12 Beta
2014-04-07 21:49	Zalewa	Note Added: 0008516
2014-04-07 21:49	Zalewa	Status	needs review => needs testing
2014-04-15 00:30	DevilHunter	Note Added: 0008577
2014-04-15 15:14	Zalewa	Status	needs testing => resolved
2014-04-15 15:14	Zalewa	Fixed in Version	=> 0.12 Beta
2014-04-15 15:14	Zalewa	Resolution	open => fixed
2018-09-29 14:44	WubTheCaptain	Status	resolved => closed

Relationships