0001558: Buddy list doesn't update when the server list refreshes or when the list opens

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001558

Doomseeker

[All Projects] Bug

public

2013-10-27 12:26

2018-09-29 14:47

Reporter

Ferk

Assigned To

Blzut3

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

0.11 Beta

Summary

0001558: Buddy list doesn't update when the server list refreshes or when the list opens

Description

Looks like the only event that triggers an update to the buddy list is when a new buddy is added or an old buddy is removed.

I guess this is not the intended behaviour. If you think that it's not reasonable to update it when the server list updates, then at least there should be a button to refresh it, or refresh it every time the List is open (since there's a "List" button to open it, that should work too).

Attached Files

fix-buddylist-refresh.patch [^] (418 bytes) 2013-10-27 22:49 [Show Content] [Hide Content]

diff -r bff2a085bc66 src/core/gui/mainwindow.cpp
--- a/src/core/gui/mainwindow.cpp	Thu Oct 10 15:01:46 2013 -0400
+++ b/src/core/gui/mainwindow.cpp	Sun Oct 27 23:47:51 2013 +0100
@@ -1129,6 +1129,7 @@
 
 	serverTableHandler->serverTable()->setAllowAllRowsRefresh(true);
 	serverTableHandler->cleanUpForce();
+	buddiesList->scan();
 	statusBar()->showMessage(tr("Done"));
 	updateTrayIconTooltipAndLogTotalRefresh();

Relationships

Notes
(0007477) Ferk (reporter) 2013-10-27 12:30	Hm.. I have no way to edit the description, but the last word on the first paragraph should be "removed", not "refreshed".

(0007478) Ferk (reporter) 2013-10-27 22:50	Please apply the patch I attached, it fixes the problem, calling buddylist->scan(); after the list of servers is updated.

(0007497) Blzut3 (administrator) 2013-10-30 23:14	Your patch had the right idea, but I think it's better to just use Qt's signals to connect the refreshing thread to the buddies list directly.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2013-10-27 12:26	Ferk	New Issue
2013-10-27 12:30	Ferk	Note Added: 0007477
2013-10-27 19:33	Blzut3	Description Updated	View Revisions
2013-10-27 22:49	Ferk	File Added: fix-buddylist-refresh.patch
2013-10-27 22:50	Ferk	Note Added: 0007478
2013-10-30 23:14	Blzut3	Note Added: 0007497
2013-10-30 23:14	Blzut3	Status	new => resolved
2013-10-30 23:14	Blzut3	Fixed in Version	=> 0.11 Beta
2013-10-30 23:14	Blzut3	Resolution	open => fixed
2013-10-30 23:14	Blzut3	Assigned To	=> Blzut3
2018-09-29 14:47	WubTheCaptain	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.