Anonymous | Login | Signup for a new account | 2024-03-19 13:48 UTC |
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||||||
0001478 | Zandronum | [All Projects] Suggestion | public | 2013-08-30 00:22 | 2017-06-11 15:39 | ||||||||
Reporter | Qent | ||||||||||||
Assigned To | Torr Samaho | ||||||||||||
Priority | normal | Severity | minor | Reproducibility | N/A | ||||||||
Status | assigned | Resolution | no change required | ||||||||||
Platform | Microsoft | OS | Windows | OS Version | XP/Vista/7 | ||||||||
Product Version | 1.1.1 | ||||||||||||
Target Version | Fixed in Version | ||||||||||||
Summary | 0001478: Un-deprecate IsMultiplayer | ||||||||||||
Description | IsMultiplayer is a useful ACS function to determine whether a game is online or offline. For the longest time it has been deprecated, according to both the Skulltag/Zandronum and ZDoom wikis; and ACC has not compiled it, replacing its opcode with the unimplemented PlayerOnTeam function. While the latter is an issue for the ACC maintainers to sort out, I would like to request here that support for IsMultiplayer be restored, or its functionality covered by other ACS functions. The closest function that I have found so far is ConsolePlayerNumber. When run on the server, it will return -1, revealing that there is a server, and therefore the game is online; however, to work as a substitute for IsMultiplayer, ConsolePlayerNumber cannot be run CLIENTSIDE. | ||||||||||||
Additional Information | I have just written up a description of IsMultiplayer on the Zandronum wiki that truer to its current behavior. | ||||||||||||
Attached Files | |||||||||||||
Notes | |
(0007086) Dusk (developer) 2013-08-30 16:36 edited on: 2013-08-30 16:37 |
Quote |
(0007088) Watermelon (developer) 2013-08-31 17:16 |
An ACS function for NETWORK_GetState() may help here? |
(0007104) Blzut3 (administrator) 2013-09-04 15:21 |
Is there are reason that GameType() or SinglePlayer() do not return the proper value in multiplayer emulation? It would seem to me that a mode called "emulation" should actually emulate multiplayer as far as ACS scripts are concerned. |
(0007110) Qent (updater) 2013-09-05 13:00 edited on: 2013-09-05 13:35 |
Neither of those can distinguish between online and offline Deathmatch modes (needed for D2DM3). A function to expose NETWORK_GetState() would be great. |
(0007113) Blzut3 (administrator) 2013-09-05 14:36 |
Ahh, so this is "needed" for silly easter eggs. Still it would seem to me like SinglePlayer() could be modified to just be the inverse of IsMultiplayer(). If you really want to distinguish between offline deathmatch and true single player there are way you could still get that (count the players for example). |
(0007131) Torr Samaho (administrator) 2013-09-07 09:07 edited on: 2013-09-07 09:08 |
As far as I can tell Zandronum still fully supports IsMultiplayer and the op code has been the same ever since I joined, i.e. since Skulltag 97c2. I don't see why we should remove this function (although I don't don't see why it was added it the first place, but now that it's there we'll have to keep it) and I don't know who flagged this as deprecated. Modifying SinglePlayer() risks breaking mods that rely on its current behavior. |
(0007156) Qent (updater) 2013-09-10 15:56 |
So all that's needed now is for ACC to add it back in. |
(0007160) ZzZombo (reporter) 2013-09-11 05:41 edited on: 2013-09-11 05:41 |
No. All what is needed is choosing an unused in ZDoom opcode for this function since ZDoom apparently never thought about Skulltag-specific function in its place (that's why PlayerOnTeam() is here) and will never change that in our favor. |
(0007165) Qent (updater) 2013-09-11 17:50 |
That would break compatibility with existing mods, and if we did that then we might as well deprecate IsMultiplayer in favor of an ACS function for NETWORK_GetState. But why do you think that PlayerOnTeam is ZDoom's (unused!) function? Both the ACC and ZDoom sources have it well within the "Skulltag pcodes." |
(0007369) Qent (updater) 2013-10-10 16:58 |
Since this requires only a change to ACC over which we have no control, I'm marking this closed. |
(0015097) Torr Samaho (administrator) 2016-06-19 08:57 |
Repoened to sort out the op code naming differences. |
(0015098) Edward-san (developer) 2016-06-19 10:07 |
As I said here, imho IsMultiplayer must be renamed to IsNetworkGame because it doesn't do what it's supposed to do and also the acc parser still uses the old name. |
(0015099) Edward-san (developer) 2016-06-19 11:02 |
Now Singleplayer will do the same thing in both zandronum and zdoom git (see this commit). |
(0015100) Edward-san (developer) 2016-06-20 08:35 |
In the dev meeting it was decided that the function should be renamed IsNetworkGame, for clearer meaning. Applied the changes to ZDoom (here) and acc (here). |
Only registered users can voice their support. Click here to register, or here to log in. | |
Supporters: | Qent Hypnotoad Korshun Combinebobnt |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2013-08-30 00:22 | Qent | New Issue | |
2013-08-30 16:36 | Dusk | Note Added: 0007086 | |
2013-08-30 16:37 | Dusk | Note Edited: 0007086 | View Revisions |
2013-08-31 17:16 | Watermelon | Note Added: 0007088 | |
2013-09-04 15:21 | Blzut3 | Note Added: 0007104 | |
2013-09-05 13:00 | Qent | Note Added: 0007110 | |
2013-09-05 13:35 | Qent | Note Edited: 0007110 | View Revisions |
2013-09-05 14:36 | Blzut3 | Note Added: 0007113 | |
2013-09-07 09:07 | Torr Samaho | Note Added: 0007131 | |
2013-09-07 09:08 | Torr Samaho | Note Edited: 0007131 | View Revisions |
2013-09-07 09:08 | Torr Samaho | Note Revision Dropped: 7131: 0004001 | |
2013-09-10 15:56 | Qent | Note Added: 0007156 | |
2013-09-11 05:41 | ZzZombo | Note Added: 0007160 | |
2013-09-11 05:41 | ZzZombo | Note Edited: 0007160 | View Revisions |
2013-09-11 17:50 | Qent | Note Added: 0007165 | |
2013-10-10 16:58 | Qent | Note Added: 0007369 | |
2013-10-10 16:58 | Qent | Status | new => closed |
2013-10-10 16:58 | Qent | Resolution | open => no change required |
2016-06-19 08:57 | Torr Samaho | Note Added: 0015097 | |
2016-06-19 08:57 | Torr Samaho | Status | closed => new |
2016-06-19 10:07 | Edward-san | Note Added: 0015098 | |
2016-06-19 11:02 | Edward-san | Note Added: 0015099 | |
2016-06-20 08:35 | Edward-san | Note Added: 0015100 | |
2016-06-20 08:35 | Edward-san | Assigned To | => Torr Samaho |
2016-06-20 08:35 | Edward-san | Status | new => assigned |
Copyright © 2000 - 2024 MantisBT Team |