Zandronum Chat on our Discord Server Get the latest version: 3.2.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001435Zandronum[All Projects] Bugpublic2013-07-27 21:482018-09-30 23:17
ReporterNeuralStunner 
Assigned ToTorr Samaho 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.2 
Target VersionFixed in Version2.0 
Summary0001435: PUFFGETSOWNER Fails in Certain Cases
DescriptionIf the puff enters its Crash state (due to hitting a wall or missing), it will not target the shooter correctly.
Additional InformationAt the end of the P_SpawnPuff function in p_mobj.cpp:


    // [BB] If the puff came from a player, set the target of the puff to this player.
    if ( puff && (puff->flags5 & MF5_PUFFGETSOWNER))
        puff->target = source;

    return puff;
}


ZDoom (r2129), however, sets this pointer closer to the function's beginning:

    puff = Spawn (pufftype, x, y, z, ALLOW_REPLACE);
    if (puff == NULL) return NULL;

    // [BB] If the puff came from a player, set the target of the puff to this player.
    if ( puff && (puff->flags5 & MF5_PUFFGETSOWNER))
        puff->target = source;


In ZDoom's case, the Target assignment works perfectly. I duplicated this move in a local Zandronum build and it too was fixed.
Attached Files

- Relationships

-  Notes
User avatar (0007711)
NeuralStunner (reporter)
2013-12-18 00:11

 Checking against the beta source, this is fixed in 2.0 (and can be closed as such).

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2013-07-27 21:48 NeuralStunner New Issue
2013-07-27 22:30 Dusk Additional Information Updated View Revisions
2013-12-18 00:11 NeuralStunner Note Added: 0007711
2013-12-27 11:52 Torr Samaho Assigned To => Torr Samaho
2013-12-27 11:52 Torr Samaho Status new => resolved
2013-12-27 11:52 Torr Samaho Resolution open => fixed
2013-12-27 11:52 Torr Samaho Product Version => 1.2
2013-12-27 11:52 Torr Samaho Fixed in Version => 2.0
2018-09-30 23:17 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker