Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | All Projects Issue Support Ranking | Rules | My Account
  

View Revisions: Issue #1435 [ All Revisions ] [ Back to Issue ]
Summary 0001435: PUFFGETSOWNER Fails in Certain Cases
Revision 2013-07-27 22:30 by Dusk
Additional Information At the end of the P_SpawnPuff function in p_mobj.cpp:


    // [BB] If the puff came from a player, set the target of the puff to this player.
    if ( puff && (puff->flags5 & MF5_PUFFGETSOWNER))
        puff->target = source;

    return puff;
}


ZDoom (r2129), however, sets this pointer closer to the function's beginning:

    puff = Spawn (pufftype, x, y, z, ALLOW_REPLACE);
    if (puff == NULL) return NULL;

    // [BB] If the puff came from a player, set the target of the puff to this player.
    if ( puff && (puff->flags5 & MF5_PUFFGETSOWNER))
        puff->target = source;


In ZDoom's case, the Target assignment works perfectly. I duplicated this move in a local Zandronum build and it too was fixed.
Revision 2013-07-27 21:48 by NeuralStunner
Additional Information At the end of the P_SpawnPuff function in p_mobj.cpp:


    // [BB] If the puff came from a player, set the target of the puff to this player.
    if ( puff && (puff->flags5 & MF5_PUFFGETSOWNER))
        puff->target = source;

    return puff;
}


ZDoom, however, sets this pointer closer to the function's beginning:

    puff = Spawn (pufftype, x, y, z, ALLOW_REPLACE);
    if (puff == NULL) return NULL;

    // [BB] If the puff came from a player, set the target of the puff to this player.
    if ( puff && (puff->flags5 & MF5_PUFFGETSOWNER))
        puff->target = source;


In ZDoom's case, the Target assignment works perfectly. I duplicated this move in a local Zandronum build and it too was fixed.




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker