Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001389Zandronum[All Projects] Bugpublic2013-07-01 23:492018-09-30 20:16
Reporteribm5155 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.0 
Target Version1.1Fixed in Version1.1 
Summary0001389: Dynamic light color not restored on map reset
Descriptionclientside script change the light and dynamic lights on the map, but when the map restart it doesn´t go back as it was.

wad test
'https://mega.co.nz/#!j9QViDxQ!IKFh5G0Ul1fwwcywBMt_FD9kwa4lNn_i2GK4dSZJHio [^]'
Steps To ReproduceFirst you need doomseker or other multiplayer launcher
 load these files:Doom2.wad,Skulltag_actors,Skulltag_data_126,ZM09_LE.wad
 Start on surival mode and start on map zm09

 To active the Lava bug press the switch on the right, you enter on the lava and you die, when the map reset be down of the 3D floor with the weird orange color (a bug)
Attached Files7z file icon ZM09_LE_WFACE.7z [^] (1,464 bytes) 2013-07-11 19:47
diff file icon client-reset-args.diff [^] (3,542 bytes) 2013-07-13 13:38 [Show Content]
diff file icon resetargs.diff [^] (4,373 bytes) 2013-07-14 15:23 [Show Content]

- Relationships
related to 0001388newDusk Effects of Ceiling_RaiseByValue on 3D floors not properly reset during a map reset 

-  Notes
User avatar (0006616)
ibm5155 (reporter)
2013-07-10 23:26

'http://www.mediafire.com/download/9m5fk3t3g9g9x4t/Zombie_Horde_-_ZM09_CLIENTSIDE_BUG.rar [^]'

Better example with a record on zandronum 1.1
When used Thing_SetSpecial on a clientside to chande the light color (on the example to red) when the map resets it doesn´t went back to the original light

Imstructions to do this bug

while you see the prepare to fight print (on survival coop) press the switch.
When the game really starts you don´t press the switch and the dynamic light will be red and not white.
User avatar (0006621)
Torr Samaho (administrator)
2013-07-11 19:54
edited on: 2013-07-11 19:55

Looks like we were investigating the same issue at the same time, Dusk. Next time I'll assign any ticket to myself as soon as I start to investigate it to prevent us from needlessly doing the same thing twice.

Anyway, I "minimalized" the example wad and think I found out what the problem is: Actor args are not reset during a map reset.

User avatar (0006624)
ibm5155 (reporter)
2013-07-12 11:58

That´s the problem, since it only change the arg values of dynamic lights, Since I don't even know what should I change on the code I will only "find"/test the bugs =/
User avatar (0006625)
Dusk (developer)
2013-07-13 13:45

I've attached a sort of a fix, while it works here I'm kind of baffled how this actually is working and I'm almost certain it's not the right way to do it.. it's a hack.

It seems dynamic lights don't have net IDs, being on one peer only. Therefore the server doesn't touch them and thus the args need to be reset on the client's end.

Any comments on this?
User avatar (0006628)
Torr Samaho (administrator)
2013-07-14 15:30

We actually have two bugs here:

First, actor args are not restored to their initial values during a map reset. Your patch only fixes part of the problem, but I have extended the patch to hopefully cover this fully (see attached diff).

Second, the client doesn't reset ALLOWCLIENTSPAWN actors spawned by the map. Since ALLOWCLIENTSPAWN was only intended for actors that are never altered in any way, this is more a bug of the mod than a bug in the engine. I slightly altered your patch in this regard to stress that we are working around a problem caused by the alteration of an actor that shouldn't be altered.
User avatar (0006637)
Torr Samaho (administrator)
2013-07-14 20:18

This contains the updated fix.
User avatar (0006638)
Arco (updater)
2013-07-14 20:37

This issue is now fixed.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2013-07-01 23:49 Dusk New Issue
2013-07-01 23:51 Dusk Relationship added related to 0001388
2013-07-01 23:51 Dusk Reporter Dusk => ibm5155
2013-07-10 23:26 ibm5155 Note Added: 0006616
2013-07-11 19:31 Dusk File Added: ZM09_LE_WFACE.wad.zip
2013-07-11 19:33 Dusk Status new => confirmed
2013-07-11 19:33 Dusk Summary Bugs that may affect the gameplay and the map itself durin the map reset (2) => Dynamic light color not restored on map reset
2013-07-11 19:47 Torr Samaho File Added: ZM09_LE_WFACE.7z
2013-07-11 19:54 Torr Samaho Note Added: 0006621
2013-07-11 19:55 Torr Samaho File Deleted: ZM09_LE_WFACE.wad.zip
2013-07-11 19:55 Torr Samaho Note Edited: 0006621 View Revisions
2013-07-11 19:55 Torr Samaho Note Revision Dropped: 6621: 0003677
2013-07-12 11:58 ibm5155 Note Added: 0006624
2013-07-13 12:38 Dusk Assigned To => Dusk
2013-07-13 12:38 Dusk Status confirmed => assigned
2013-07-13 13:37 Dusk File Added: client-reset-args.diff
2013-07-13 13:38 Dusk File Deleted: client-reset-args.diff
2013-07-13 13:38 Dusk File Added: client-reset-args.diff
2013-07-13 13:45 Dusk Note Added: 0006625
2013-07-13 13:45 Dusk Status assigned => needs review
2013-07-14 15:23 Torr Samaho File Added: resetargs.diff
2013-07-14 15:30 Torr Samaho Note Added: 0006628
2013-07-14 15:30 Torr Samaho Status needs review => feedback
2013-07-14 15:58 Dusk Note View State: 0006625: public
2013-07-14 20:18 Torr Samaho Note Added: 0006637
2013-07-14 20:18 Torr Samaho Status feedback => needs testing
2013-07-14 20:18 Torr Samaho Target Version => 1.1
2013-07-14 20:37 Arco Note Added: 0006638
2013-07-14 20:38 Dusk Status needs testing => resolved
2013-07-14 20:38 Dusk Fixed in Version => 1.1
2013-07-14 20:38 Dusk Resolution open => fixed
2018-09-30 20:16 Blzut3 Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker