Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001382Zandronum[All Projects] Bugpublic2013-06-25 02:162018-09-30 21:39
ReporterArco 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformAllOSAllOS VersionAll
Product Version1.0 
Target Version2.1Fixed in Version2.1 
Summary0001382: Friendly Fire Obituaries Don't Appear Online
DescriptionWhen a player is killed by their own team mates, the proper obituary doesn't appear on screen. The player who is killed has the weapon's defined obituary message.
Attached Files

- Relationships

-  Notes
User avatar (0006504)
Arco (updater)
2013-06-25 02:22
edited on: 2013-07-10 17:05

 I forgot to mention that teamdamage has to be enabled for this to happen. If the client does not have this flag enabled, and is still somehow able to kill their own team mates, the correct message will appear.

EDIT: This bug also happens in v1.0, as stated below.
User avatar (0006508)
Edward-san (developer)
2013-06-25 18:11

 We should find the latest beta build which didn't have this problem...
User avatar (0006585)
Torr Samaho (administrator)
2013-07-06 18:58

 Is anybody already checking which build introduced the problem?
User avatar (0006592)
Qent (updater)
2013-07-07 17:11

 I cannot get the special teamkill obituaries to show up in 1.0 online. Arco, can you please be more specific about the reproduction steps? I started a 1.0 server in Team Deathmatch mode (in Cooperative the obituaries work in both 1.0 and 1.1) and full teamdamage, and got the weapons' obituaries when killing teammates.
User avatar (0006609)
Arco (updater)
2013-07-10 17:11

 I made an error on my part while re-testing this ticket again. This bug is also peristant in v1.0, and I'm assuming that it has been there since then.
User avatar (0006610)
Torr Samaho (administrator)
2013-07-10 19:13

 Since this problem already happened in 1.0, I removed 1.1 as target version.
User avatar (0006742)
Dusk (developer)
2013-07-21 20:51
edited on: 2013-07-21 20:51

 Fixed:'https://bitbucket.org/Torr_Samaho/zandronum/pull-request/20/fixed-friendly-fire-obituaries-did-not [^]'
User avatar (0006750)
Torr Samaho (administrator)
2013-07-22 18:44

 The code change looks good, but the comment is misleading:

Clients must set FriendlyFire to false here because they do not enter P_DamageMobj.

sounds as if clients will always set this to false, which is not the case and wouldn't work. Actually they only do so if the attacker is not a teammate. Can you clarify the comment? I'll pull the patch then.
User avatar (0006859)
Dusk (developer)
2013-07-31 08:22

 Updated with a new pull request
User avatar (0006865)
Torr Samaho (administrator)
2013-07-31 18:38

 Thanks!

Looking at the updated patch again I noticed that you didn't check if attacker is a valid pointer. All other parts of ClientObituary check this pointer before using it. Are you sure that attacker has to be valid?
User avatar (0010692)
Torr Samaho (administrator)
2014-10-26 07:38

 Waiting for an answer for more than a year now...
User avatar (0011006)
Dusk (developer)
2014-11-30 16:00

 I cannot seem to be able to reproduce this anymore? Can anyone confirm whether this works in 1.3/2.0?
User avatar (0011495)
WaTaKiD (updater)
2015-01-21 22:56

 using doom2.wad with teamdamage 1, ive tested 1.0, 1.3, and 2.0, they all have the same results: in coop the obits are like "checked my glasses" and in tdm theyre the normal "splattered by ssg", am i misunderstanding or doing something wrong?
User avatar (0011749)
ZzZombo (reporter)
2015-02-24 01:12

 I can confirm this happens with the latest build from the accounts branch.
User avatar (0011750)
Edward-san (developer)
2015-02-24 09:42

 The accounts branch is outdated, since its last changeset is 5 months ago.
User avatar (0011753)
Dusk (developer)
2015-02-24 13:37
edited on: 2015-02-24 13:37

 Indeed this bug only occurs in team deathmatch (and probably in other competitive gamemodes). I'll tackle this one later, ATM there's more important things for 2.0.
User avatar (0011930)
Dusk (developer)
2015-03-30 10:42

 fixed
User avatar (0011942)
cobalt (updater)
2015-03-30 17:59

 Issue addressed by commit 5e285bd2d5b7: - fixed: friendly fire obituaries did not appear online in competitive gamemodes (fixes 1382)
Committed by Teemu Piippo [Dusk] on Monday 30 March 2015 13:41:44

Changes in files:
 docs/zandronum-history.txt | 2 ++
 src/p_interaction.cpp | 6 +++++-
 2 files changed, 7 insertions(+), 1 deletions(-)
User avatar (0012017)
Arco (updater)
2015-04-04 15:36

 Issue fixed in r150330-1514.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2013-06-25 02:16 Arco New Issue
2013-06-25 02:22 Arco Note Added: 0006504
2013-06-25 18:11 Edward-san Note Added: 0006508
2013-06-25 19:12 Dusk Status new => confirmed
2013-06-25 19:12 Dusk Product Version => 1.1-beta
2013-06-25 19:12 Dusk Target Version => 1.1
2013-06-25 19:12 Dusk Description Updated View Revisions
2013-06-25 19:33 Arco Note Edited: 0006504 View Revisions
2013-07-06 18:58 Torr Samaho Note Added: 0006585
2013-07-07 17:11 Qent Note Added: 0006592
2013-07-10 17:05 Arco Note Edited: 0006504 View Revisions
2013-07-10 17:11 Arco Note Added: 0006609
2013-07-10 19:13 Torr Samaho Note Added: 0006610
2013-07-10 19:13 Torr Samaho Product Version 1.1-beta => 1.0
2013-07-10 19:13 Torr Samaho Target Version 1.1 =>
2013-07-21 18:18 Dusk Assigned To => Dusk
2013-07-21 18:18 Dusk Status confirmed => assigned
2013-07-21 19:56 Torr Samaho Description Updated View Revisions
2013-07-21 20:51 Dusk Note Added: 0006742
2013-07-21 20:51 Dusk Status assigned => needs review
2013-07-21 20:51 Dusk Note Edited: 0006742 View Revisions
2013-07-22 18:44 Torr Samaho Note Added: 0006750
2013-07-22 18:45 Torr Samaho Status needs review => feedback
2013-07-31 08:22 Dusk Note Added: 0006859
2013-07-31 08:22 Dusk Status feedback => needs review
2013-07-31 18:38 Torr Samaho Note Added: 0006865
2013-07-31 18:39 Torr Samaho Status needs review => feedback
2014-10-26 07:38 Torr Samaho Note Added: 0010692
2014-11-30 13:50 Dusk Status feedback => assigned
2014-11-30 16:00 Dusk Note Added: 0011006
2014-11-30 16:00 Dusk Status assigned => feedback
2015-01-21 22:56 WaTaKiD Note Added: 0011495
2015-02-24 01:12 ZzZombo Note Added: 0011749
2015-02-24 09:42 Edward-san Note Added: 0011750
2015-02-24 13:37 Dusk Note Added: 0011753
2015-02-24 13:37 Dusk Status feedback => confirmed
2015-02-24 13:37 Dusk Fixed in Version => 2.1
2015-02-24 13:37 Dusk Note Edited: 0011753 View Revisions
2015-02-24 13:38 Dusk Fixed in Version 2.1 =>
2015-02-24 13:38 Dusk Target Version => 2.1
2015-03-30 10:28 Dusk Status confirmed => assigned
2015-03-30 10:42 Dusk Note Added: 0011930
2015-03-30 10:42 Dusk Status assigned => needs review
2015-03-30 17:59 cobalt Status needs review => needs testing
2015-03-30 17:59 cobalt Note Added: 0011942
2015-04-04 15:36 Arco Note Added: 0012017
2015-04-04 15:36 Arco Status needs testing => resolved
2015-04-04 15:36 Arco Resolution open => fixed
2015-04-04 15:36 Arco Fixed in Version => 2.1
2018-09-30 21:39 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker