MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001382Zandronum[All Projects] Bugpublic2013-06-25 02:162018-09-30 21:39
ReporterArco 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformAllOSAllOS VersionAll
Product Version1.0 
Target Version2.1Fixed in Version2.1 
Summary0001382: Friendly Fire Obituaries Don't Appear Online
DescriptionWhen a player is killed by their own team mates, the proper obituary doesn't appear on screen. The player who is killed has the weapon's defined obituary message.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-06-25 02:16ArcoNew Issue
2013-06-25 02:22ArcoNote Added: 0006504
2013-06-25 18:11Edward-sanNote Added: 0006508
2013-06-25 19:12DuskStatusnew => confirmed
2013-06-25 19:12DuskProduct Version => 1.1-beta
2013-06-25 19:12DuskTarget Version => 1.1
2013-06-25 19:12DuskDescription Updatedbug_revision_view_page.php?rev_id=3593#r3593
2013-06-25 19:33ArcoNote Edited: 0006504bug_revision_view_page.php?bugnote_id=6504#r3595
2013-07-06 18:58Torr SamahoNote Added: 0006585
2013-07-07 17:11QentNote Added: 0006592
2013-07-10 17:05ArcoNote Edited: 0006504bug_revision_view_page.php?bugnote_id=6504#r3670
2013-07-10 17:11ArcoNote Added: 0006609
2013-07-10 19:13Torr SamahoNote Added: 0006610
2013-07-10 19:13Torr SamahoProduct Version1.1-beta => 1.0
2013-07-10 19:13Torr SamahoTarget Version1.1 =>
2013-07-21 18:18DuskAssigned To => Dusk
2013-07-21 18:18DuskStatusconfirmed => assigned
2013-07-21 19:56Torr SamahoDescription Updatedbug_revision_view_page.php?rev_id=3749#r3749
2013-07-21 20:51DuskNote Added: 0006742
2013-07-21 20:51DuskStatusassigned => needs review
2013-07-21 20:51DuskNote Edited: 0006742bug_revision_view_page.php?bugnote_id=6742#r3751
2013-07-22 18:44Torr SamahoNote Added: 0006750
2013-07-22 18:45Torr SamahoStatusneeds review => feedback
2013-07-31 08:22DuskNote Added: 0006859
2013-07-31 08:22DuskStatusfeedback => needs review
2013-07-31 18:38Torr SamahoNote Added: 0006865
2013-07-31 18:39Torr SamahoStatusneeds review => feedback
2014-10-26 07:38Torr SamahoNote Added: 0010692
2014-11-30 13:50DuskStatusfeedback => assigned
2014-11-30 16:00DuskNote Added: 0011006
2014-11-30 16:00DuskStatusassigned => feedback
2015-01-21 22:56WaTaKiDNote Added: 0011495
2015-02-24 01:12ZzZomboNote Added: 0011749
2015-02-24 09:42Edward-sanNote Added: 0011750
2015-02-24 13:37DuskNote Added: 0011753
2015-02-24 13:37DuskStatusfeedback => confirmed
2015-02-24 13:37DuskFixed in Version => 2.1
2015-02-24 13:37DuskNote Edited: 0011753bug_revision_view_page.php?bugnote_id=11753#r6703
2015-02-24 13:38DuskFixed in Version2.1 =>
2015-02-24 13:38DuskTarget Version => 2.1
2015-03-30 10:28DuskStatusconfirmed => assigned
2015-03-30 10:42DuskNote Added: 0011930
2015-03-30 10:42DuskStatusassigned => needs review
2015-03-30 17:59cobaltStatusneeds review => needs testing
2015-03-30 17:59cobaltNote Added: 0011942
2015-04-04 15:36ArcoNote Added: 0012017
2015-04-04 15:36ArcoStatusneeds testing => resolved
2015-04-04 15:36ArcoResolutionopen => fixed
2015-04-04 15:36ArcoFixed in Version => 2.1
2018-09-30 21:39Blzut3Statusresolved => closed

Notes
(0006504)
Arco   
2013-06-25 02:22   
(edited on: 2013-07-10 17:05)
I forgot to mention that teamdamage has to be enabled for this to happen. If the client does not have this flag enabled, and is still somehow able to kill their own team mates, the correct message will appear.

EDIT: This bug also happens in v1.0, as stated below.
(0006508)
Edward-san   
2013-06-25 18:11   
We should find the latest beta build which didn't have this problem...
(0006585)
Torr Samaho   
2013-07-06 18:58   
Is anybody already checking which build introduced the problem?
(0006592)
Qent   
2013-07-07 17:11   
I cannot get the special teamkill obituaries to show up in 1.0 online. Arco, can you please be more specific about the reproduction steps? I started a 1.0 server in Team Deathmatch mode (in Cooperative the obituaries work in both 1.0 and 1.1) and full teamdamage, and got the weapons' obituaries when killing teammates.
(0006609)
Arco   
2013-07-10 17:11   
I made an error on my part while re-testing this ticket again. This bug is also peristant in v1.0, and I'm assuming that it has been there since then.
(0006610)
Torr Samaho   
2013-07-10 19:13   
Since this problem already happened in 1.0, I removed 1.1 as target version.
(0006742)
Dusk   
2013-07-21 20:51   
Fixed:'https://bitbucket.org/Torr_Samaho/zandronum/pull-request/20/fixed-friendly-fire-obituaries-did-not [^]'
(0006750)
Torr Samaho   
2013-07-22 18:44   
The code change looks good, but the comment is misleading:

Clients must set FriendlyFire to false here because they do not enter P_DamageMobj.

sounds as if clients will always set this to false, which is not the case and wouldn't work. Actually they only do so if the attacker is not a teammate. Can you clarify the comment? I'll pull the patch then.
(0006859)
Dusk   
2013-07-31 08:22   
Updated with a new pull request
(0006865)
Torr Samaho   
2013-07-31 18:38   
Thanks!

Looking at the updated patch again I noticed that you didn't check if attacker is a valid pointer. All other parts of ClientObituary check this pointer before using it. Are you sure that attacker has to be valid?
(0010692)
Torr Samaho   
2014-10-26 07:38   
Waiting for an answer for more than a year now...
(0011006)
Dusk   
2014-11-30 16:00   
I cannot seem to be able to reproduce this anymore? Can anyone confirm whether this works in 1.3/2.0?
(0011495)
WaTaKiD   
2015-01-21 22:56   
using doom2.wad with teamdamage 1, ive tested 1.0, 1.3, and 2.0, they all have the same results: in coop the obits are like "checked my glasses" and in tdm theyre the normal "splattered by ssg", am i misunderstanding or doing something wrong?
(0011749)
ZzZombo   
2015-02-24 01:12   
I can confirm this happens with the latest build from the accounts branch.
(0011750)
Edward-san   
2015-02-24 09:42   
The accounts branch is outdated, since its last changeset is 5 months ago.
(0011753)
Dusk   
2015-02-24 13:37   
Indeed this bug only occurs in team deathmatch (and probably in other competitive gamemodes). I'll tackle this one later, ATM there's more important things for 2.0.
(0011930)
Dusk   
2015-03-30 10:42   
fixed
(0011942)
cobalt   
2015-03-30 17:59   
Issue addressed by commit 5e285bd2d5b7: - fixed: friendly fire obituaries did not appear online in competitive gamemodes (fixes 1382)
Committed by Teemu Piippo [Dusk] on Monday 30 March 2015 13:41:44

Changes in files:
 docs/zandronum-history.txt | 2 ++
 src/p_interaction.cpp | 6 +++++-
 2 files changed, 7 insertions(+), 1 deletions(-)
(0012017)
Arco   
2015-04-04 15:36   
Issue fixed in r150330-1514.