Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001336Zandronum[All Projects] Bugpublic2013-05-05 22:122018-09-30 21:52
ReporterEdward-san 
Assigned ToTorr Samaho 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.1.1 
Target Version3.0Fixed in Version3.0 
Summary0001336: NETWORK_GetLocalAddress always resorts to "something more complicated"
Description

/home/edward-san/zdoom/zandronum/trunk/src/network.cpp:742:33: warning: if statement has empty body [-Wempty-body]
        if ( stringToAddress == false );
                                       ^
/home/edward-san/zdoom/zandronum/trunk/src/network.cpp:742:33: note: put the semicolon on a separate line to silence this warning


This means that all the code below the "something more complicated" is executed regardless of the stringToAddress condition...
Attached Files

- Relationships

-  Notes
User avatar (0006361)
Torr Samaho (administrator)
2013-06-02 19:18

 Simply removing the semicolon should fix it. Since this is rather basic code that's pretty important I propose we change this once 1.1 is out to avoid introducing new bugs now.
User avatar (0006818)
Edward-san (developer)
2013-07-26 20:05

 bump, I believe this is the time to remove the semicolon and see what happens.
User avatar (0009370)
Edward-san (developer)
2014-06-15 13:04

 It's still a problem in 1.2.x and 2.0.
User avatar (0009429)
Dusk (developer)
2014-06-15 15:48

 Made public, I don't think this ticket is anyhow sensitive.
User avatar (0009484)
Torr Samaho (administrator)
2014-06-15 19:50

 Let's just remove the semicolon in 2.0.
User avatar (0012326)
Torr Samaho (administrator)
2015-05-17 20:10

 3.0 finally takes care of this.
User avatar (0012351)
cobalt (updater)
2015-05-24 09:29

 Issue addressed by commit d2857e31e716: Fixed: Under Linux, NETWORK_GetLocalAddress was always resorting to "something more complicated" (fixes 1336).
Committed by Benjamin Berkels [Torr Samaho] on Sunday 17 May 2015 22:10:11

Changes in files:
 src/network.cpp | 2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
User avatar (0016507)
Ru5tK1ng (updater)
2016-12-16 22:28

 Closing this since it doesn't seem removing the semi-colon caused any major issues all this time.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2013-05-05 22:12 Edward-san New Issue
2013-06-02 19:18 Torr Samaho Note Added: 0006361
2013-07-26 20:05 Edward-san Note Added: 0006818
2013-07-27 08:00 Torr Samaho Assigned To => Torr Samaho
2013-07-27 08:00 Torr Samaho Status new => assigned
2013-07-27 08:00 Torr Samaho Product Version => 1.1.1
2013-07-27 08:00 Torr Samaho Target Version => 1.2
2013-08-28 21:20 Torr Samaho Target Version 1.2 =>
2014-06-15 13:04 Edward-san Note Added: 0009370
2014-06-15 15:48 Dusk Note Added: 0009429
2014-06-15 15:48 Dusk View Status private => public
2014-06-15 19:49 Torr Samaho Target Version => 2.0
2014-06-15 19:50 Torr Samaho Note Added: 0009484
2014-06-15 19:59 Torr Samaho Priority high => normal
2015-02-01 20:50 Torr Samaho Target Version 2.0 =>
2015-02-01 20:52 Dusk Target Version => 2.1
2015-05-11 18:23 Dusk Target Version 2.1 => 3.0
2015-05-17 20:10 Torr Samaho Note Added: 0012326
2015-05-17 20:11 Torr Samaho Status assigned => needs testing
2015-05-24 09:29 cobalt Note Added: 0012351
2016-12-16 22:28 Ru5tK1ng Note Added: 0016507
2016-12-16 22:28 Ru5tK1ng Status needs testing => resolved
2016-12-16 22:28 Ru5tK1ng Resolution open => fixed
2016-12-16 22:28 Ru5tK1ng Fixed in Version => 3.0
2018-09-30 21:52 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker