MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001336Zandronum[All Projects] Bugpublic2013-05-05 22:122018-09-30 21:52
ReporterEdward-san 
Assigned ToTorr Samaho 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.1.1 
Target Version3.0Fixed in Version3.0 
Summary0001336: NETWORK_GetLocalAddress always resorts to "something more complicated"
Description

/home/edward-san/zdoom/zandronum/trunk/src/network.cpp:742:33: warning: if statement has empty body [-Wempty-body]
        if ( stringToAddress == false );
                                       ^
/home/edward-san/zdoom/zandronum/trunk/src/network.cpp:742:33: note: put the semicolon on a separate line to silence this warning


This means that all the code below the "something more complicated" is executed regardless of the stringToAddress condition...
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-05-05 22:12Edward-sanNew Issue
2013-06-02 19:18Torr SamahoNote Added: 0006361
2013-07-26 20:05Edward-sanNote Added: 0006818
2013-07-27 08:00Torr SamahoAssigned To => Torr Samaho
2013-07-27 08:00Torr SamahoStatusnew => assigned
2013-07-27 08:00Torr SamahoProduct Version => 1.1.1
2013-07-27 08:00Torr SamahoTarget Version => 1.2
2013-08-28 21:20Torr SamahoTarget Version1.2 =>
2014-06-15 13:04Edward-sanNote Added: 0009370
2014-06-15 15:48DuskNote Added: 0009429
2014-06-15 15:48DuskView Statusprivate => public
2014-06-15 19:49Torr SamahoTarget Version => 2.0
2014-06-15 19:50Torr SamahoNote Added: 0009484
2014-06-15 19:59Torr SamahoPriorityhigh => normal
2015-02-01 20:50Torr SamahoTarget Version2.0 =>
2015-02-01 20:52DuskTarget Version => 2.1
2015-05-11 18:23DuskTarget Version2.1 => 3.0
2015-05-17 20:10Torr SamahoNote Added: 0012326
2015-05-17 20:11Torr SamahoStatusassigned => needs testing
2015-05-24 09:29cobaltNote Added: 0012351
2016-12-16 22:28Ru5tK1ngNote Added: 0016507
2016-12-16 22:28Ru5tK1ngStatusneeds testing => resolved
2016-12-16 22:28Ru5tK1ngResolutionopen => fixed
2016-12-16 22:28Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:52Blzut3Statusresolved => closed

Notes
(0006361)
Torr Samaho   
2013-06-02 19:18   
Simply removing the semicolon should fix it. Since this is rather basic code that's pretty important I propose we change this once 1.1 is out to avoid introducing new bugs now.
(0006818)
Edward-san   
2013-07-26 20:05   
bump, I believe this is the time to remove the semicolon and see what happens.
(0009370)
Edward-san   
2014-06-15 13:04   
It's still a problem in 1.2.x and 2.0.
(0009429)
Dusk   
2014-06-15 15:48   
Made public, I don't think this ticket is anyhow sensitive.
(0009484)
Torr Samaho   
2014-06-15 19:50   
Let's just remove the semicolon in 2.0.
(0012326)
Torr Samaho   
2015-05-17 20:10   
3.0 finally takes care of this.
(0012351)
cobalt   
2015-05-24 09:29   
Issue addressed by commit d2857e31e716: Fixed: Under Linux, NETWORK_GetLocalAddress was always resorting to "something more complicated" (fixes 1336).
Committed by Benjamin Berkels [Torr Samaho] on Sunday 17 May 2015 22:10:11

Changes in files:
 src/network.cpp | 2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(0016507)
Ru5tK1ng   
2016-12-16 22:28   
Closing this since it doesn't seem removing the semi-colon caused any major issues all this time.