0001322: Skin Aren't Counted Properly

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001322

Zandronum

[All Projects] Bug

public

2013-04-10 23:18

2018-09-30 20:19

Reporter

Blzut3

Assigned To

Blzut3

Priority

high

Severity

crash

Reproducibility

always

Status

closed

Resolution

fixed

Platform

Linux

Ubuntu

OS Version

12.10 x86_64

Product Version

1.1-beta

Target Version

1.1

Fixed in Version

1.1

Summary

0001322: Skin Aren't Counted Properly

Description

The procedure for counting skins in S_SKIN/SKININFO is inconsistent with the loader. This results in not enough memory being allocated leaving the engine in an inconsistent state at best (usually crashing on load).

Attached Files

Screenshot_Doom_20130610_231053.png [^] (174,234 bytes) 2013-06-11 03:25

Relationships

parent of

0001106

closed

Torr Samaho

Skins folder causes crashes upon picking up any items online with Armageddon2v63.pk3

Notes
(0006282) Blzut3 (administrator) 2013-04-11 20:14 edited on: 2013-04-11 20:15	Opted to go ahead and change the skins array to a TArray to make things simpler. Tested against a handful of skins including a set of malformed ones and the pull request should solve the problems.

(0006308) Torr Samaho (administrator) 2013-04-28 19:08	I pulled your change.

(0006416) Arco (updater) 2013-06-11 03:24 edited on: 2013-06-11 03:25	This issue appears to be fixed in V1.1-alpha-130512-1932. The lumps S_SKIN/SKININFO work together, but the lump SKININFO/S_SKIN only works as long as one or both of them are properly defined. If it has the same values as "SKININFO/S_SKIN" the resulting skin will simply be named "skin2".

(0006417) Blzut3 (administrator) 2013-06-11 03:30	S_SKIN and SKININFO are basically different names for the same lump, so having the same skin defined in both will result in one being renamed.

**Issue Community Support**
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2013-04-10 23:18	Blzut3	New Issue
2013-04-10 23:18	Blzut3	Status	new => assigned
2013-04-10 23:18	Blzut3	Assigned To	=> Blzut3
2013-04-11 18:57	Dusk	Relationship added	parent of 0001106
2013-04-11 20:13	Blzut3	Status	assigned => needs review
2013-04-11 20:14	Blzut3	Note Added: 0006282
2013-04-11 20:15	Blzut3	Note Edited: 0006282	View Revisions
2013-04-24 20:36	Blzut3	Status	needs review => needs testing
2013-04-28 19:08	Torr Samaho	Note Added: 0006308
2013-06-11 03:24	Arco	Note Added: 0006416
2013-06-11 03:25	Arco	File Added: Screenshot_Doom_20130610_231053.png
2013-06-11 03:25	Arco	Note Edited: 0006416	View Revisions
2013-06-11 03:30	Blzut3	Note Added: 0006417
2013-06-11 03:30	Blzut3	Status	needs testing => resolved
2013-06-11 03:30	Blzut3	Fixed in Version	=> 1.1
2013-06-11 03:30	Blzut3	Resolution	open => fixed
2018-09-30 20:19	Blzut3	Status	resolved => closed

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.