MantisBT - Zandronum
View Issue Details
0001322Zandronum[All Projects] Bugpublic2013-04-10 23:182018-09-30 20:19
Blzut3 
Blzut3 
highcrashalways
closedfixed 
LinuxUbuntu12.10 x86_64
1.1-beta 
1.11.1 
0001322: Skin Aren't Counted Properly
The procedure for counting skins in S_SKIN/SKININFO is inconsistent with the loader. This results in not enough memory being allocated leaving the engine in an inconsistent state at best (usually crashing on load).
No tags attached.
parent of 0001106closed Torr Samaho Skins folder causes crashes upon picking up any items online with Armageddon2v63.pk3 
png Screenshot_Doom_20130610_231053.png (174,234) 2013-06-11 03:25
/tracker/file_download.php?file_id=978&type=bug
png
Issue History
2013-04-10 23:18Blzut3New Issue
2013-04-10 23:18Blzut3Statusnew => assigned
2013-04-10 23:18Blzut3Assigned To => Blzut3
2013-04-11 18:57DuskRelationship addedparent of 0001106
2013-04-11 20:13Blzut3Statusassigned => needs review
2013-04-11 20:14Blzut3Note Added: 0006282
2013-04-11 20:15Blzut3Note Edited: 0006282bug_revision_view_page.php?bugnote_id=6282#r3470
2013-04-24 20:36Blzut3Statusneeds review => needs testing
2013-04-28 19:08Torr SamahoNote Added: 0006308
2013-06-11 03:24ArcoNote Added: 0006416
2013-06-11 03:25ArcoFile Added: Screenshot_Doom_20130610_231053.png
2013-06-11 03:25ArcoNote Edited: 0006416bug_revision_view_page.php?bugnote_id=6416#r3537
2013-06-11 03:30Blzut3Note Added: 0006417
2013-06-11 03:30Blzut3Statusneeds testing => resolved
2013-06-11 03:30Blzut3Fixed in Version => 1.1
2013-06-11 03:30Blzut3Resolutionopen => fixed
2018-09-30 20:19Blzut3Statusresolved => closed

Notes
(0006282)
Blzut3   
2013-04-11 20:14   
(edited on: 2013-04-11 20:15)
Opted to go ahead and change the skins array to a TArray to make things simpler.

Tested against a handful of skins including a set of malformed ones and the pull request should solve the problems.

(0006308)
Torr Samaho   
2013-04-28 19:08   
I pulled your change.
(0006416)
Arco   
2013-06-11 03:24   
(edited on: 2013-06-11 03:25)
This issue appears to be fixed in V1.1-alpha-130512-1932. The lumps S_SKIN/SKININFO work together, but the lump SKININFO/S_SKIN only works as long as one or both of them are properly defined. If it has the same values as "SKININFO/S_SKIN" the resulting skin will simply be named "skin2".

(0006417)
Blzut3   
2013-06-11 03:30   
S_SKIN and SKININFO are basically different names for the same lump, so having the same skin defined in both will result in one being renamed.