Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001218Zandronum[All Projects] Bugpublic2012-12-17 15:102014-06-13 15:57
ReporterZzZombo 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionbackport later 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0001218: Increase the limit of ACS scripts
DescriptionCurrently Zandronum allows only up to 1001 scripts to be defined in libraries (counting from 0). Loading ZDoom ACS scripts can cause Zandronum to hang if a script which number is greater than 1000 present.
Steps To ReproduceCreate a script with number of 1001 of type OPEN and compile it. Run Zandronum with it and load any level.
Additional InformationPatch
Attached Files

- Relationships

-  Notes
User avatar (0005535)
Edward-san (developer)
2012-12-19 17:37
edited on: 2012-12-19 17:50

#define NUM_SCRIPTS 32767


That's wrong. If you want to increase the maximum script number from 999 to 32767, you should increase the storage size from 999+1 = 1000 to 32767+1 = 32768.

Also, there's no trace of this code in the zdoom source. Which revision increased the size?

[edit] The revision with the increase is r3359 and it's related to the initial support of the Named scripts.

I don't know if Torr agrees with the code, but it'll cause headaches when he'll begin to update the zdoom codebase.
User avatar (0005536)
ZzZombo (reporter)
2012-12-19 17:51
edited on: 2012-12-19 17:53

 [Reply to initial post] Indeed, my bad ;)
User avatar (0005540)
Watermelon (developer)
2012-12-22 05:17

 I support this because mod's nowadays are getting so huge that were sometimes having to restructure scripts because we're running out of them.
User avatar (0005545)
ZzZombo (reporter)
2012-12-22 12:58

 > it'll cause headaches when he'll begin to update the zdoom codebase.
Hm. A simple replacement of 1000 to NUM_SCRIPTS can't cause any headache >.<. This patch is worth to be pulled after I'll fix it because I highly doubt named scripts will be backported in any versions of Zandrponum would out in next several months while this change can be applied to next version easily.
User avatar (0005546)
Qent (updater)
2012-12-22 14:33
edited on: 2012-12-22 14:36

 Why not backport named scripts instead?

EDIT: Or, I suppose this and named scripts would probably come as an item.
User avatar (0009200)
Watermelon (developer)
2014-06-13 15:57

 Hey I want this really badly too, but we have to wait for zdoom :(

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2012-12-17 15:10 ZzZombo New Issue
2012-12-19 17:37 Edward-san Note Added: 0005535
2012-12-19 17:42 Edward-san Note Edited: 0005535 View Revisions
2012-12-19 17:44 Edward-san Note Edited: 0005535 View Revisions
2012-12-19 17:50 Edward-san Note Edited: 0005535 View Revisions
2012-12-19 17:51 ZzZombo Note Added: 0005536
2012-12-19 17:53 ZzZombo Note Edited: 0005536 View Revisions
2012-12-22 05:17 Watermelon Note Added: 0005540
2012-12-22 12:58 ZzZombo Note Added: 0005545
2012-12-22 14:33 Qent Note Added: 0005546
2012-12-22 14:36 Qent Note Edited: 0005546 View Revisions
2014-06-13 15:57 Watermelon Note Added: 0009200
2014-06-13 15:57 Watermelon Status new => closed
2014-06-13 15:57 Watermelon Resolution open => backport later




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker