MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001218Zandronum[All Projects] Bugpublic2012-12-17 15:102014-06-13 15:57
ReporterZzZombo 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionbackport later 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0001218: Increase the limit of ACS scripts
DescriptionCurrently Zandronum allows only up to 1001 scripts to be defined in libraries (counting from 0). Loading ZDoom ACS scripts can cause Zandronum to hang if a script which number is greater than 1000 present.
Steps To ReproduceCreate a script with number of 1001 of type OPEN and compile it. Run Zandronum with it and load any level.
Additional InformationPatch
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-12-17 15:10ZzZomboNew Issue
2012-12-19 17:37Edward-sanNote Added: 0005535
2012-12-19 17:42Edward-sanNote Edited: 0005535bug_revision_view_page.php?bugnote_id=5535#r3032
2012-12-19 17:44Edward-sanNote Edited: 0005535bug_revision_view_page.php?bugnote_id=5535#r3033
2012-12-19 17:50Edward-sanNote Edited: 0005535bug_revision_view_page.php?bugnote_id=5535#r3034
2012-12-19 17:51ZzZomboNote Added: 0005536
2012-12-19 17:53ZzZomboNote Edited: 0005536bug_revision_view_page.php?bugnote_id=5536#r3036
2012-12-22 05:17WatermelonNote Added: 0005540
2012-12-22 12:58ZzZomboNote Added: 0005545
2012-12-22 14:33QentNote Added: 0005546
2012-12-22 14:36QentNote Edited: 0005546bug_revision_view_page.php?bugnote_id=5546#r3038
2014-06-13 15:57WatermelonNote Added: 0009200
2014-06-13 15:57WatermelonStatusnew => closed
2014-06-13 15:57WatermelonResolutionopen => backport later

Notes
(0005535)
Edward-san   
2012-12-19 17:37   
(edited on: 2012-12-19 17:50)

#define NUM_SCRIPTS 32767


That's wrong. If you want to increase the maximum script number from 999 to 32767, you should increase the storage size from 999+1 = 1000 to 32767+1 = 32768.

Also, there's no trace of this code in the zdoom source. Which revision increased the size?

[edit] The revision with the increase is r3359 and it's related to the initial support of the Named scripts.

I don't know if Torr agrees with the code, but it'll cause headaches when he'll begin to update the zdoom codebase.
(0005536)
ZzZombo   
2012-12-19 17:51   
(edited on: 2012-12-19 17:53)
[Reply to initial post] Indeed, my bad ;)
(0005540)
Watermelon   
2012-12-22 05:17   
I support this because mod's nowadays are getting so huge that were sometimes having to restructure scripts because we're running out of them.
(0005545)
ZzZombo   
2012-12-22 12:58   
> it'll cause headaches when he'll begin to update the zdoom codebase.
Hm. A simple replacement of 1000 to NUM_SCRIPTS can't cause any headache >.<. This patch is worth to be pulled after I'll fix it because I highly doubt named scripts will be backported in any versions of Zandrponum would out in next several months while this change can be applied to next version easily.
(0005546)
Qent   
2012-12-22 14:33   
(edited on: 2012-12-22 14:36)
Why not backport named scripts instead?

EDIT: Or, I suppose this and named scripts would probably come as an item.
(0009200)
Watermelon   
2014-06-13 15:57   
Hey I want this really badly too, but we have to wait for zdoom :(