Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001105Zandronum[All Projects] Bugpublic2012-10-07 12:212018-09-30 22:23
ReporterEsum 
Assigned To 
PrioritylowSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.0 
Target Version3.0Fixed in Version3.0 
Summary0001105: Spectators move down when using the land command.
DescriptionSpectators move down while using the land command.
This effect last 1~2 tics.
Attached Files

- Relationships

-  Notes
User avatar (0005031)
unknownna (updater)
2012-10-07 13:42

Is the land command specific to Skulltag/Zandronum?
User avatar (0005042)
Esum (reporter)
2012-10-07 18:05

The land command is not specific to Zandronum and exists in ZDoom. It interrupts flight and make the player who used it fall.
User avatar (0005048)
unknownna (updater)
2012-10-08 00:03

I see. I thought it was specific to Zandronum since it wouldn't respond when called from the console offline. Speaking of which, perhaps spectators should be allowed to use the land command properly.
User avatar (0009802)
Esum (reporter)
2014-06-30 11:37
edited on: 2014-06-30 12:28

Here is the relevant part of the code:
Quote from p_user.cpp

3121 // Allow the spectator to do a few things, then break out.
3122 if ( player->bSpectating )
3123 {
... ...
3133 // Allow the player to fly around when a spectator.
3134 player->mo->flags |= MF_NOGRAVITY;
3135 player->mo->flags2 |= MF2_FLY;
... ...
3200 if ( cmd->ucmd.upmove == -32768 )
3201 { // Only land if in the air
3202 if ((player->mo->flags2 & MF2_FLY) && player->mo->waterlevel < 2)
3203 {
3204 player->mo->flags2 &= ~MF2_FLY;
3205 player->mo->flags &= ~MF_NOGRAVITY;
3206 }
3207 }
... ...
3225 // Done with spectator specific logic.
3226 return;
3227 }

If a spectator uses the land command he loses his ability to fly and becomes subject to gravity for one tick.
This issue is related to'http://zandronum.com/tracker/view.php?id=1641 [^]'

User avatar (0009833)
Esum (reporter)
2014-07-04 11:22

Since spectators are not meant to interact with gravity I removed this here:'https://bitbucket.org/esum/zandronum-stable/commits/be5c0172b7e073a3ed21823becf6ad12e6d36b5b [^]'
User avatar (0013211)
cobalt (updater)
2015-08-11 19:04

Issue addressed by commit 381f296c9c7c: Changed: Spectators can now interact with gravity and use the fly/land commands (addresses 1641 and fixes 1105).
Committed by Leonard on Sunday 09 August 2015 19:48:32

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/c_cmds.cpp | 17 ++++++++++-
 src/cl_demo.cpp | 4 ++
 src/cl_demo.h | 1 +
 src/p_interaction.cpp | 11 ++++--
 src/p_user.cpp | 139 +++++++++++++++++++++-----------------------------------------------------------------
 6 files changed, 63 insertions(+), 110 deletions(-)

User avatar (0013257)
Ru5tK1ng (updater)
2015-08-23 19:23

Tested this with 3.0-alpha-150819-2351. The land command causes me to fall out of the sky and land on the ground with gravity in effect permantely. I have to use FLY to float around again. Not sure if this behavior is correct.
User avatar (0013260)
Leonard (developer)
2015-08-23 20:31

Yes that's what it's supposed to do.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2012-10-07 12:21 Esum New Issue
2012-10-07 13:42 unknownna Note Added: 0005031
2012-10-07 18:05 Esum Note Added: 0005042
2012-10-08 00:03 unknownna Note Added: 0005048
2012-10-08 00:03 unknownna Status new => confirmed
2012-10-08 10:26 Esum Note Added: 0005050
2014-06-30 11:37 Esum Note Added: 0009802
2014-06-30 11:38 Esum Note Deleted: 0005050
2014-06-30 12:28 Esum Note Edited: 0009802 View Revisions
2014-07-04 11:22 Esum Note Added: 0009833
2015-08-11 19:04 cobalt Status confirmed => needs testing
2015-08-11 19:04 cobalt Target Version => 3.0
2015-08-11 19:04 cobalt Description Updated View Revisions
2015-08-11 19:04 cobalt Note Added: 0013211
2015-08-23 19:23 Ru5tK1ng Note Added: 0013257
2015-08-23 20:31 Leonard Note Added: 0013260
2015-08-25 10:34 Dusk Status needs testing => resolved
2015-08-25 10:34 Dusk Fixed in Version => 3.0
2015-08-25 10:34 Dusk Resolution open => fixed
2015-08-25 10:34 Dusk Assigned To => Dusk
2015-08-25 10:34 Dusk Assigned To Dusk =>
2015-08-25 10:34 Dusk Description Updated View Revisions
2018-09-30 22:23 Blzut3 Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker