Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000998Zandronum[All Projects] Bugpublic2012-08-29 15:082018-09-30 21:26
ReporterDusk 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.0 
Target VersionFixed in Version1.1 
Summary0000998: Attached midtextures aren't reset properly
Description3d midtextures attached to a sector do not get their heights reset properly during map resets. Can be reproduced offline.
Steps To Reproduce1. Load up example wad. The brown window midtexture is attached to a control sector off the scene.
2. Hit the small switch beside the brown midtexture to elevate the midtexture off the blue base.
3. Hit the blue skull switch to reset the map. The midtexture remains elevated.
Attached Fileszip file icon AttachMidtexTest.zip [^] (8,151 bytes) 2012-08-29 15:08

- Relationships

-  Notes
User avatar (0004511)
Dusk (developer)
2012-08-30 02:38

This one was tricky but I got it. P:

Note that the map reset informs clients to explicitly set the move distance as the clients seem not to be able to calculate it correctly themselves (32.0 on server, 31.0 or 28.0 on client for instance).

Fixed: Attached 3d midtexture heights were not reset properly during map resets.
User avatar (0004536)
Torr Samaho (administrator)
2012-09-01 09:31

Some comments:
- g_game.cpp + p_setup.cpp + p_udmf.cpp: I think it's safer to check whether e is NULL before using it
- p_saveg.cpp: Please mark the changes with comments
- g_game.cpp: trailing tabs ;)
- zandronum-history.txt: "Skulltag Version History.txt" has the latest version on top and I think we should keep this pattern in Zandronum. Most likely I will commit a change to zandronum-history.txt soon and use the old pattern.
User avatar (0004554)
Dusk (developer)
2012-09-01 16:48

Addressed

bitbucket sure doesn't like me
User avatar (0004571)
Torr Samaho (administrator)
2012-09-02 15:12

Pulled. I also noticed that it won't hurt to add another small NULL pointer check and added it in a separate commit.
User avatar (0004758)
Watermelon (developer)
2012-09-23 17:26

Is there a downloadable build to test this with?
User avatar (0004765)
Torr Samaho (administrator)
2012-09-23 18:30

You can use this binary to test this.
User avatar (0004777)
unknownna (updater)
2012-09-23 20:04

It seems to work as intended.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2012-08-29 15:08 Dusk New Issue
2012-08-29 15:08 Dusk File Added: AttachMidtexTest.zip
2012-08-29 15:10 Dusk Steps to Reproduce Updated View Revisions
2012-08-29 23:46 Dusk Assigned To => Dusk
2012-08-29 23:46 Dusk Status new => assigned
2012-08-30 01:33 Dusk Note Added: 0004510
2012-08-30 01:33 Dusk Status assigned => needs review
2012-08-30 01:35 Dusk Note Deleted: 0004510
2012-08-30 01:35 Dusk Status needs review => assigned
2012-08-30 02:38 Dusk Note Added: 0004511
2012-08-30 02:38 Dusk Status assigned => needs review
2012-09-01 09:31 Torr Samaho Note Added: 0004536
2012-09-01 12:05 Dusk Status needs review => assigned
2012-09-01 16:48 Dusk Note Added: 0004554
2012-09-01 16:48 Dusk Status assigned => needs review
2012-09-02 15:12 Torr Samaho Note Added: 0004571
2012-09-02 15:12 Torr Samaho Status needs review => needs testing
2012-09-23 17:26 Watermelon Note Added: 0004758
2012-09-23 18:30 Torr Samaho Note Added: 0004765
2012-09-23 20:04 unknownna Note Added: 0004777
2012-09-23 20:15 Torr Samaho Status needs testing => resolved
2012-09-23 20:15 Torr Samaho Fixed in Version => 1.1
2012-09-23 20:15 Torr Samaho Resolution open => fixed
2018-09-30 21:26 Blzut3 Status resolved => closed






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker