MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000998Zandronum[All Projects] Bugpublic2012-08-29 15:082018-09-30 21:26
ReporterDusk 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.0 
Target VersionFixed in Version1.1 
Summary0000998: Attached midtextures aren't reset properly
Description3d midtextures attached to a sector do not get their heights reset properly during map resets. Can be reproduced offline.
Steps To Reproduce1. Load up example wad. The brown window midtexture is attached to a control sector off the scene.
2. Hit the small switch beside the brown midtexture to elevate the midtexture off the blue base.
3. Hit the blue skull switch to reset the map. The midtexture remains elevated.
Additional Information
TagsNo tags attached.
Relationships
Attached Fileszip AttachMidtexTest.zip (8,151) 2012-08-29 15:08
/tracker/file_download.php?file_id=687&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-08-29 15:08DuskNew Issue
2012-08-29 15:08DuskFile Added: AttachMidtexTest.zip
2012-08-29 15:10DuskSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=2461#r2461
2012-08-29 23:46DuskAssigned To => Dusk
2012-08-29 23:46DuskStatusnew => assigned
2012-08-30 01:33DuskNote Added: 0004510
2012-08-30 01:33DuskStatusassigned => needs review
2012-08-30 01:35DuskNote Deleted: 0004510
2012-08-30 01:35DuskStatusneeds review => assigned
2012-08-30 02:38DuskNote Added: 0004511
2012-08-30 02:38DuskStatusassigned => needs review
2012-09-01 09:31Torr SamahoNote Added: 0004536
2012-09-01 12:05DuskStatusneeds review => assigned
2012-09-01 16:48DuskNote Added: 0004554
2012-09-01 16:48DuskStatusassigned => needs review
2012-09-02 15:12Torr SamahoNote Added: 0004571
2012-09-02 15:12Torr SamahoStatusneeds review => needs testing
2012-09-23 17:26WatermelonNote Added: 0004758
2012-09-23 18:30Torr SamahoNote Added: 0004765
2012-09-23 20:04unknownnaNote Added: 0004777
2012-09-23 20:15Torr SamahoStatusneeds testing => resolved
2012-09-23 20:15Torr SamahoFixed in Version => 1.1
2012-09-23 20:15Torr SamahoResolutionopen => fixed
2018-09-30 21:26Blzut3Statusresolved => closed

Notes
(0004511)
Dusk   
2012-08-30 02:38   
This one was tricky but I got it. P:

Note that the map reset informs clients to explicitly set the move distance as the clients seem not to be able to calculate it correctly themselves (32.0 on server, 31.0 or 28.0 on client for instance).

Fixed: Attached 3d midtexture heights were not reset properly during map resets.
(0004536)
Torr Samaho   
2012-09-01 09:31   
Some comments:
- g_game.cpp + p_setup.cpp + p_udmf.cpp: I think it's safer to check whether e is NULL before using it
- p_saveg.cpp: Please mark the changes with comments
- g_game.cpp: trailing tabs ;)
- zandronum-history.txt: "Skulltag Version History.txt" has the latest version on top and I think we should keep this pattern in Zandronum. Most likely I will commit a change to zandronum-history.txt soon and use the old pattern.
(0004554)
Dusk   
2012-09-01 16:48   
Addressed

bitbucket sure doesn't like me
(0004571)
Torr Samaho   
2012-09-02 15:12   
Pulled. I also noticed that it won't hurt to add another small NULL pointer check and added it in a separate commit.
(0004758)
Watermelon   
2012-09-23 17:26   
Is there a downloadable build to test this with?
(0004765)
Torr Samaho   
2012-09-23 18:30   
You can use this binary to test this.
(0004777)
unknownna   
2012-09-23 20:04   
It seems to work as intended.