Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000866Zandronum[All Projects] Bugpublic2012-06-06 16:502018-09-30 19:52
ReporterKlofkac 
Assigned ToDusk 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version98d 
Target VersionFixed in Version1.0 
Summary0000866: Server doesn't inform clients about SetActorVelocity
DescriptionWhen using SetActorVelocity, called actor's velocity and position isn't informed to the client. When actor changes state, its position updates, but not the velocity.
Server-side and locally it works normally.
Steps To ReproduceStart local server with attached wad and join it.
Call script 2 to move monster with changing state (Thing_Hate) and watch it "jumping".
Call script 3 to move yourself, this is OK.
Call script 4 to move projectile, the projectile will look like it stands at place, but if you step on cross, it hits you.

Restart after script calls.
Attached Files? file icon setactorvelocity.wad [^] (11,222 bytes) 2012-06-06 16:50

- Relationships

-  Notes
User avatar (0003711)
Dusk (developer)
2012-06-09 15:24

 Fixed:'https://bitbucket.org/CrimsonDusk/neurosphere/changeset/1b56cfa10e39 [^]'

Though I noticed another issue with this. Online, the player seems to fall off from his orbit and this is not a desync as both the hudmessages and idmypos show the same positions.
User avatar (0003786)
Torr Samaho (administrator)
2012-06-16 16:54

 Looks good, I just wonder if we should move the special player handling to a new function (e.g. SERVERCOMMANDS_SetThingMomentumAndPositionIfNoPlayer) since it's used at two places. What do you think?

BTW: Can you configure your editor not to insert trailing tabs? If you use KDiff3 you should see what I'm referring to.
User avatar (0003791)
Dusk (developer)
2012-06-16 23:03
edited on: 2012-06-16 23:04

 > I just wonder if we should move the special player handling to a new function (e.g. SERVERCOMMANDS_SetThingMomentumAndPositionIfNoPlayer) since it's used at two places.
Sure, though the name sounds way too long to me. :F
Maybe SERVERCOMMANDS_MoveThingPlayer or something like that? Or is it too vague?

> BTW: Can you configure your editor not to insert trailing tabs? If you use KDiff3 you should see what I'm referring to.
.. crap. I'll look into it if I can configure it that way.

I guess I'll fix the tab and then try send a pull request. I think we should give that feature a shot. :P
User avatar (0003796)
Torr Samaho (administrator)
2012-06-17 09:29

 I'd say SERVERCOMMANDS_MoveThingPlayer is definitely too vague, but I agree that the name I proposed is a bit too long ;).

Quote from Dusk

I guess I'll fix the tab and then try send a pull request.

Yeah, we should try pulling. Just be sure to base your change on my latest default changeset, don't base it on one of yours as pulling a changeset requires to pull all of its ancestors. Please also include the necessary entry in zandronum-history.txt.
User avatar (0003836)
Dusk (developer)
2012-06-24 10:58

 Pull request created.
User avatar (0003839)
Torr Samaho (administrator)
2012-06-24 15:05
edited on: 2012-06-24 15:06

 I pulled your changes, removed the trailing tabs (creating a third changeset) and collapsed the three changeset. Since collapsing changes authorship it would be preferably if you do this in the future (collapsing is just a few clicks in TortoisHg using "Compress History").

EDIT: What about adding SERVERCOMMANDS_SetThingMomentumAndPositionIfNoPlayer (possibly with a nicer name)?
User avatar (0003846)
Dusk (developer)
2012-06-24 17:04
edited on: 2012-06-24 17:04

 > I pulled your changes
I just wonder.. if you did, then how come is this still open?
'https://bitbucket.org/Torr_Samaho/zandronum/pull-request/3/fixed-setactorvelocity-didnt-update [^]'

> EDIT: What about adding SERVERCOMMANDS_SetThingMomentumAndPositionIfNoPlayer (possibly with a nicer name)?
SERVERCOMMANDS_MoveThingIfNoPlayer? "MoveThing" implies momentum anyway. If that's fine I'll go and add it up.
User avatar (0003847)
Torr Samaho (administrator)
2012-06-24 17:44
edited on: 2012-06-24 17:47

 > I just wonder.. if you did, then how come is this still open?

I pulled it with my local client to my local repository. Since I collapsed the changes and removed the extra head locally before pushing it to my bitbucket repo (history manipulation should only be done carefully in a local repository) I guess bitbucket didn't realize that I pulled it. Or it didn't like that I only pulled the interesting head and not all of your Neuroshpere changes. The former is more likely though. We'll see what exactly happened once I pull a change that doesn't need collapsing.

> SERVERCOMMANDS_MoveThingIfNoPlayer

Hmm, I though that the new function doesn't have the ulBits argument anymore, so the name MoveThingIfNoPlayer wouldn't imply that anything is done if the argument is a player.

EDIT: How about SERVER_UpdateThingMomentum (and no ulBits argument)?
User avatar (0004184)
Qent (updater)
2012-08-02 01:40

 This is fixed.
User avatar (0004194)
Watermelon (developer)
2012-08-02 13:38

 Additional confirmation of working in latest build
User avatar (0004207)
Torr Samaho (administrator)
2012-08-02 19:24
edited on: 2012-08-05 16:36

 Thanks for confirming. Since SERVER_UpdateThingMomentum is also implemented, this is resolved now.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2012-06-06 16:50 Klofkac New Issue
2012-06-06 16:50 Klofkac File Added: setactorvelocity.wad
2012-06-06 16:51 Dusk Assigned To => Dusk
2012-06-06 16:51 Dusk Status new => assigned
2012-06-09 13:22 Torr Samaho Category General => Bug
2012-06-09 15:24 Dusk Note Added: 0003711
2012-06-09 15:24 Dusk Status assigned => needs review
2012-06-16 16:54 Torr Samaho Note Added: 0003786
2012-06-16 23:03 Dusk Note Added: 0003791
2012-06-16 23:04 Dusk Note Edited: 0003791 View Revisions
2012-06-17 09:29 Torr Samaho Note Added: 0003796
2012-06-24 10:47 Torr Samaho Status needs review => feedback
2012-06-24 10:58 Dusk Note Added: 0003836
2012-06-24 10:58 Dusk Status feedback => needs review
2012-06-24 15:05 Torr Samaho Note Added: 0003839
2012-06-24 15:05 Torr Samaho Status needs review => needs testing
2012-06-24 15:06 Torr Samaho Note Edited: 0003839 View Revisions
2012-06-24 17:04 Dusk Note Added: 0003846
2012-06-24 17:04 Dusk Note Edited: 0003846 View Revisions
2012-06-24 17:44 Torr Samaho Note Added: 0003847
2012-06-24 17:47 Torr Samaho Note Edited: 0003847 View Revisions
2012-06-24 17:47 Torr Samaho Note Edited: 0003847 View Revisions
2012-08-02 01:40 Qent Note Added: 0004184
2012-08-02 13:38 Watermelon Note Added: 0004194
2012-08-02 19:24 Torr Samaho Note Added: 0004207
2012-08-02 19:25 Torr Samaho Status needs testing => resolved
2012-08-02 19:25 Torr Samaho Fixed in Version => 1.0
2012-08-02 19:25 Torr Samaho Resolution open => fixed
2012-08-05 16:36 Torr Samaho Note Edited: 0004207 View Revisions
2012-08-05 16:38 Torr Samaho Note Revision Dropped: 4207: 0002340
2018-09-30 19:52 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker