MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0000866Zandronum[All Projects] Bugpublic2012-06-06 16:502018-09-30 19:52
ReporterKlofkac 
Assigned ToDusk 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version98d 
Target VersionFixed in Version1.0 
Summary0000866: Server doesn't inform clients about SetActorVelocity
DescriptionWhen using SetActorVelocity, called actor's velocity and position isn't informed to the client. When actor changes state, its position updates, but not the velocity.
Server-side and locally it works normally.
Steps To ReproduceStart local server with attached wad and join it.
Call script 2 to move monster with changing state (Thing_Hate) and watch it "jumping".
Call script 3 to move yourself, this is OK.
Call script 4 to move projectile, the projectile will look like it stands at place, but if you step on cross, it hits you.

Restart after script calls.
Additional Information
TagsNo tags attached.
Relationships
Attached Files? setactorvelocity.wad (11,222) 2012-06-06 16:50
/tracker/file_download.php?file_id=625&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-06-06 16:50KlofkacNew Issue
2012-06-06 16:50KlofkacFile Added: setactorvelocity.wad
2012-06-06 16:51DuskAssigned To => Dusk
2012-06-06 16:51DuskStatusnew => assigned
2012-06-09 13:22Torr SamahoCategoryGeneral => Bug
2012-06-09 15:24DuskNote Added: 0003711
2012-06-09 15:24DuskStatusassigned => needs review
2012-06-16 16:54Torr SamahoNote Added: 0003786
2012-06-16 23:03DuskNote Added: 0003791
2012-06-16 23:04DuskNote Edited: 0003791bug_revision_view_page.php?bugnote_id=3791#r2076
2012-06-17 09:29Torr SamahoNote Added: 0003796
2012-06-24 10:47Torr SamahoStatusneeds review => feedback
2012-06-24 10:58DuskNote Added: 0003836
2012-06-24 10:58DuskStatusfeedback => needs review
2012-06-24 15:05Torr SamahoNote Added: 0003839
2012-06-24 15:05Torr SamahoStatusneeds review => needs testing
2012-06-24 15:06Torr SamahoNote Edited: 0003839bug_revision_view_page.php?bugnote_id=3839#r2095
2012-06-24 17:04DuskNote Added: 0003846
2012-06-24 17:04DuskNote Edited: 0003846bug_revision_view_page.php?bugnote_id=3846#r2099
2012-06-24 17:44Torr SamahoNote Added: 0003847
2012-06-24 17:47Torr SamahoNote Edited: 0003847bug_revision_view_page.php?bugnote_id=3847#r2101
2012-06-24 17:47Torr SamahoNote Edited: 0003847bug_revision_view_page.php?bugnote_id=3847#r2102
2012-08-02 01:40QentNote Added: 0004184
2012-08-02 13:38WatermelonNote Added: 0004194
2012-08-02 19:24Torr SamahoNote Added: 0004207
2012-08-02 19:25Torr SamahoStatusneeds testing => resolved
2012-08-02 19:25Torr SamahoFixed in Version => 1.0
2012-08-02 19:25Torr SamahoResolutionopen => fixed
2012-08-05 16:36Torr SamahoNote Edited: 0004207bug_revision_view_page.php?bugnote_id=4207#r2341
2012-08-05 16:38Torr SamahoNote Revision Dropped: 4207: 0002340
2018-09-30 19:52Blzut3Statusresolved => closed

Notes
(0003711)
Dusk   
2012-06-09 15:24   
Fixed:'https://bitbucket.org/CrimsonDusk/neurosphere/changeset/1b56cfa10e39 [^]'

Though I noticed another issue with this. Online, the player seems to fall off from his orbit and this is not a desync as both the hudmessages and idmypos show the same positions.
(0003786)
Torr Samaho   
2012-06-16 16:54   
Looks good, I just wonder if we should move the special player handling to a new function (e.g. SERVERCOMMANDS_SetThingMomentumAndPositionIfNoPlayer) since it's used at two places. What do you think?

BTW: Can you configure your editor not to insert trailing tabs? If you use KDiff3 you should see what I'm referring to.
(0003791)
Dusk   
2012-06-16 23:03   
(edited on: 2012-06-16 23:04)
> I just wonder if we should move the special player handling to a new function (e.g. SERVERCOMMANDS_SetThingMomentumAndPositionIfNoPlayer) since it's used at two places.
Sure, though the name sounds way too long to me. :F
Maybe SERVERCOMMANDS_MoveThingPlayer or something like that? Or is it too vague?

> BTW: Can you configure your editor not to insert trailing tabs? If you use KDiff3 you should see what I'm referring to.
.. crap. I'll look into it if I can configure it that way.

I guess I'll fix the tab and then try send a pull request. I think we should give that feature a shot. :P
(0003796)
Torr Samaho   
2012-06-17 09:29   
I'd say SERVERCOMMANDS_MoveThingPlayer is definitely too vague, but I agree that the name I proposed is a bit too long ;).

Quote from Dusk

I guess I'll fix the tab and then try send a pull request.

Yeah, we should try pulling. Just be sure to base your change on my latest default changeset, don't base it on one of yours as pulling a changeset requires to pull all of its ancestors. Please also include the necessary entry in zandronum-history.txt.
(0003836)
Dusk   
2012-06-24 10:58   
Pull request created.
(0003839)
Torr Samaho   
2012-06-24 15:05   
(edited on: 2012-06-24 15:06)
I pulled your changes, removed the trailing tabs (creating a third changeset) and collapsed the three changeset. Since collapsing changes authorship it would be preferably if you do this in the future (collapsing is just a few clicks in TortoisHg using "Compress History").

EDIT: What about adding SERVERCOMMANDS_SetThingMomentumAndPositionIfNoPlayer (possibly with a nicer name)?
(0003846)
Dusk   
2012-06-24 17:04   
> I pulled your changes
I just wonder.. if you did, then how come is this still open?
'https://bitbucket.org/Torr_Samaho/zandronum/pull-request/3/fixed-setactorvelocity-didnt-update [^]'

> EDIT: What about adding SERVERCOMMANDS_SetThingMomentumAndPositionIfNoPlayer (possibly with a nicer name)?
SERVERCOMMANDS_MoveThingIfNoPlayer? "MoveThing" implies momentum anyway. If that's fine I'll go and add it up.
(0003847)
Torr Samaho   
2012-06-24 17:44   
(edited on: 2012-06-24 17:47)
> I just wonder.. if you did, then how come is this still open?

I pulled it with my local client to my local repository. Since I collapsed the changes and removed the extra head locally before pushing it to my bitbucket repo (history manipulation should only be done carefully in a local repository) I guess bitbucket didn't realize that I pulled it. Or it didn't like that I only pulled the interesting head and not all of your Neuroshpere changes. The former is more likely though. We'll see what exactly happened once I pull a change that doesn't need collapsing.

> SERVERCOMMANDS_MoveThingIfNoPlayer

Hmm, I though that the new function doesn't have the ulBits argument anymore, so the name MoveThingIfNoPlayer wouldn't imply that anything is done if the argument is a player.

EDIT: How about SERVER_UpdateThingMomentum (and no ulBits argument)?
(0004184)
Qent   
2012-08-02 01:40   
This is fixed.
(0004194)
Watermelon   
2012-08-02 13:38   
Additional confirmation of working in latest build
(0004207)
Torr Samaho   
2012-08-02 19:24   
(edited on: 2012-08-05 16:36)
Thanks for confirming. Since SERVER_UpdateThingMomentum is also implemented, this is resolved now.