0004277: "Hold" state name causes broken behavior

Notes
(0023696) unknownna (updater) 2024-05-14 03:53	The example wad seems to work fine for me. Tested with a local connection and with 300 ping. The regular attack prints "A", while altattack prints "B". How is it broken, and what do you expect to occur instead? I'd like to help you narrow it down more if you explain it a bit better. Thank you.

(0023703) BinaryCode (reporter) 2024-05-16 00:55 edited on: 2024-05-16 01:49	He told me "hold M1 use M2 (or viceversa) on both weapons" Also, he wants the ticket renamed to "weaponready jump bug"; I don't know how to do that, and change the steps to what he told me at the start of this note (hold M1 use M2 (or viceversa) on both weapons). And it might happen with or without Clumsy

(0023704) unknownna (updater) 2024-05-16 03:57 edited on: 2024-05-16 04:01	Quote from BinaryCode He told me "hold M1 use M2 (or viceversa) on both weapons" You mean to hold both buttons down at the same time. After figuring it out, there is a difference indeed, but it also happens offline, so it's not an online issue from what I can tell. However, after comparing Zandronum and GZDoom 1.8.6, Zandronum is the broken one indeed. The culprit seems to be the "Hold" state. If it's named something else it works properly for some reason.

(0023827) Kaminsky (developer) 2024-07-27 14:19	Quote from "unknownna" However, after comparing Zandronum and GZDoom 1.8.6, Zandronum is the broken one indeed. I tried testing the example WAD in Zandronum 3.2-alpha and GZDoom 1.8.6 myself and I didn't notice any difference in the behaviour. When used the "one that doesn't work" pistol in both ports, if I held +attack or +altattack then pressed and held the other, it flickered between printing "A" or "B" on the screen. If I pressed and held both at the same time, it printed "C" on the screen. The "one that does" work pistol also seems to work fine in both ports too. Am I missing something here? Likewise, I didn't notice any issues with how A_WeaponReady works at high pings, and I tested with a local connection at 300+ ping using GamersProxy. The behaviour worked the same online as it did offline.

(0023837) unknownna (updater) 2024-07-27 22:41	Yeah, this is weird. Testing it again yields the same results between Zandronum and GZDoom 1.8.6. Thanks for checking this out for me BTW. The "one that does work" pistol prints "C" if you press and hold +attack and then press +altattack on top of that, and vice versa. The "one that doesn't work" pistol only prints "C" if you press and hold +attack and +altattack at the same time. I think I missed the latter part the first time I checked, and then figured that by renaming the "Hold" state, the behavior of "one that doesn't work" matched to the "one that does work". But this behaves the same between Zandronum and GZDoom 1.8.6. If anything, it's a GZDoom-ism and should be reported there by the OP if it feels like a bug. The example wad uploaded confirms that it's the "Hold" state name that makes the pistols behave differently, but it behaves the same between Zandronum and GZDoom 1.8.6.

(0023846) Kaminsky (developer) 2024-07-29 14:45	For the record, this issue still happens in GZDoom 4.12.2 (the latest version as of writing this). I agree that if the reporter thinks this a bug, it should be reported there first. Otherwise, I'd just close this ticket.

(0023858) unknownna (updater) 2024-07-30 01:56	Agreed, I'll mark this as "waiting for ZDoom" for the time being until the OP reports it there and finds a resolution and reports back here.

**Issue Community Support**
Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue Community Support

Only registered users can voice their support. Click here to register, or here to log in.

Supporters:

No one explicitly supports this issue yet.

Opponents:

No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2024-05-10 15:30	BinaryCode	New Issue
2024-05-10 15:30	BinaryCode	File Added: A_WeaponReady_Bug.wad
2024-05-10 16:23	WaTaKiD	Steps to Reproduce Updated	View Revisions
2024-05-14 03:53	unknownna	Note Added: 0023696
2024-05-14 03:53	unknownna	Status	new => feedback
2024-05-16 00:55	BinaryCode	Note Added: 0023703
2024-05-16 00:55	BinaryCode	Status	feedback => new
2024-05-16 00:57	BinaryCode	Note Edited: 0023703	View Revisions
2024-05-16 01:19	Ru5tK1ng	Description Updated	View Revisions
2024-05-16 01:49	BinaryCode	Note Edited: 0023703	View Revisions
2024-05-16 03:57	unknownna	Note Added: 0023704
2024-05-16 03:57	unknownna	Status	new => confirmed
2024-05-16 04:00	unknownna	Summary	A_WeaponReady ignores flags on high ping (200-250) (?) => A_WeaponReady ignores flags on high ping (200-250) (?) \| Hold state broken in Zandronum
2024-05-16 04:00	unknownna	Steps to Reproduce Updated	View Revisions
2024-05-16 04:01	unknownna	Note Edited: 0023704	View Revisions
2024-05-16 04:04	unknownna	Priority	normal => high
2024-07-27 14:19	Kaminsky	Note Added: 0023827
2024-07-27 14:19	Kaminsky	Status	confirmed => feedback
2024-07-27 22:40	unknownna	File Added: A_WeaponReady_Bug_02.wad
2024-07-27 22:41	unknownna	Note Added: 0023837
2024-07-29 14:45	Kaminsky	Note Added: 0023846
2024-07-30 01:56	unknownna	Note Added: 0023858
2024-07-30 01:56	unknownna	Priority	high => normal
2024-07-30 01:56	unknownna	Status	feedback => acknowledged
2024-07-30 01:56	unknownna	Resolution	open => waiting for zdoom
2024-07-30 01:56	unknownna	Summary	A_WeaponReady ignores flags on high ping (200-250) (?) \| Hold state broken in Zandronum => "Hold" state name causes broken behavior

Relationships