| Anonymous | Login | Signup for a new account | 2025-11-04 19:28 UTC |
| My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account |
| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
| 0004216 | Zandronum | [All Projects] Suggestion | public | 2024-04-04 23:57 | 2025-11-03 19:17 | ||||
| Reporter | BinaryCode | ||||||||
| Assigned To | Kaminsky | ||||||||
| Priority | normal | Severity | tweak | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Platform | OS | OS Version | |||||||
| Product Version | 3.1 | ||||||||
| Target Version | 3.3 | Fixed in Version | 3.3 | ||||||
| Summary | 0004216: CurrentPlayerClass variable is limited to 255 | ||||||||
| Description | In d_player.h, "CurrentPlayerClass" is a BYTE variable, meaning you cannot select a class after the 255th index, or it will reset back to 0. I feel like this is a bug, but GZDoom has the same thing (uses a different variable type, but still has the same limitation):'https://github.com/ZDoom/gzdoom/blob/master/src/playsim/d_player.h#L340 [^]' This isn't really a major issue, since there isn't a mod with THAT many classes, but I wanted to make a ticket issue in case. | ||||||||
| Attached Files | |||||||||
Notes |
|
|
Ru5tK1ng (updater) 2024-04-05 23:21 |
Marking this as a suggestion since this seems more like an oversight than a bug due to the reason you specified: no mod uses over 255 classes. |
|
Kaminsky (developer) 2024-04-06 00:05 |
After speaking in private with Binary about this ticket, it's better if GZDoom decides (if they really want) to change the data type of that variable to something bigger than an unsigned 8-bit integer, which we could then backport someday. I don't see any justification in changing this ourselves and creating more delta from GZDoom if there's seemingly no mod out there that's defined more than, or even close to, 256 player classes. |
|
BinaryCode (reporter) 2025-09-25 02:14 |
Made a GZDoom PR:'https://github.com/ZDoom/gzdoom/pull/3370 [^]' And uploaded an example PK3 and patch file. Hopefully the patch file can be used... |
|
Ru5tK1ng (updater) 2025-11-03 16:42 |
Merged in:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/9cee7e80ec2496a0ad90e0b01dc05be61c760d98 [^]' |
|
BinaryCode (reporter) 2025-11-03 18:55 |
Works for me, feel free to mark as done |
|
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
| Supporters: | No one explicitly supports this issue yet. |
| Opponents: | No one explicitly opposes this issue yet. |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-04-04 23:57 | BinaryCode | New Issue | |
| 2024-04-05 23:21 | Ru5tK1ng | Note Added: 0023517 | |
| 2024-04-05 23:21 | Ru5tK1ng | Status | new => acknowledged |
| 2024-04-05 23:21 | Ru5tK1ng | Resolution | open => waiting for zdoom |
| 2024-04-05 23:21 | Ru5tK1ng | Category | Bug => Suggestion |
| 2024-04-06 00:05 | Kaminsky | Note Added: 0023520 | |
| 2025-09-25 02:12 | BinaryCode | File Added: ClassLimitIssue-0.pk3 | |
| 2025-09-25 02:14 | BinaryCode | Note Added: 0024567 | |
| 2025-09-25 02:15 | BinaryCode | File Added: NoLimit-CurrentPlayerClass-1.patch | |
| 2025-11-03 16:42 | Ru5tK1ng | Note Added: 0024628 | |
| 2025-11-03 16:42 | Ru5tK1ng | Status | acknowledged => needs testing |
| 2025-11-03 16:42 | Ru5tK1ng | Target Version | => 3.3 |
| 2025-11-03 18:55 | BinaryCode | Note Added: 0024629 | |
| 2025-11-03 19:17 | Ru5tK1ng | Status | needs testing => resolved |
| 2025-11-03 19:17 | Ru5tK1ng | Resolution | waiting for zdoom => fixed |
| 2025-11-03 19:17 | Ru5tK1ng | Fixed in Version | => 3.3 |
| 2025-11-03 19:17 | Kaminsky | Assigned To | => Kaminsky |
| Copyright © 2000 - 2025 MantisBT Team |