0004216: CurrentPlayerClass variable is limited to 255

Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004216

Zandronum

[All Projects] Suggestion

public

2024-04-04 23:57

2024-04-06 00:05

Reporter

BinaryCode

Assigned To

Priority

normal

Severity

tweak

Reproducibility

always

Status

acknowledged

Resolution

waiting for zdoom

Platform

OS Version

Product Version

3.1

Target Version

Fixed in Version

Summary

0004216: CurrentPlayerClass variable is limited to 255

Description

In d_player.h, "CurrentPlayerClass" is a BYTE variable, meaning you cannot select a class after the 255th index, or it will reset back to 0.

I feel like this is a bug, but GZDoom has the same thing (uses a different variable type, but still has the same limitation):'https://github.com/ZDoom/gzdoom/blob/master/src/playsim/d_player.h#L340 [^]'

This isn't really a major issue, since there isn't a mod with THAT many classes, but I wanted to make a ticket issue in case.

Attached Files

Relationships

Notes
(0023517) Ru5tK1ng (updater) 2024-04-05 23:21	Marking this as a suggestion since this seems more like an oversight than a bug due to the reason you specified: no mod uses over 255 classes.

(0023520) Kaminsky (developer) 2024-04-06 00:05	After speaking in private with Binary about this ticket, it's better if GZDoom decides (if they really want) to change the data type of that variable to something bigger than an unsigned 8-bit integer, which we could then backport someday. I don't see any justification in changing this ourselves and creating more delta from GZDoom if there's seemingly no mod out there that's defined more than, or even close to, 256 player classes.

**Issue Community Support**
Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2024-04-04 23:57	BinaryCode	New Issue
2024-04-05 23:21	Ru5tK1ng	Note Added: 0023517
2024-04-05 23:21	Ru5tK1ng	Status	new => acknowledged
2024-04-05 23:21	Ru5tK1ng	Resolution	open => waiting for zdoom
2024-04-05 23:21	Ru5tK1ng	Category	Bug => Suggestion
2024-04-06 00:05	Kaminsky	Note Added: 0023520

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.