Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0004081Doomseeker[All Projects] Suggestionpublic2023-01-02 10:062024-11-03 19:14
ReporterZalewa 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.4.0 
Target Version1.4.0Fixed in Version1.4.0 
Summary0004081: Doomseeker 1.1 config migration getting in the way of --basedir
DescriptionThe code in DataPaths is full of legacy, but the one thing that started to get in the way is the code that migrates the Doomseeker 1.1 configs to 1.2 and newer. 1.2 was released in October 2018. The code was written in December 2017.

Now the issue is that when you start a new Doomseeker process with `--basedir something_fresh`, Doomseeker will see that this is a new config directory and then will check if Doomseeker 1.1 configs still exist in the system. If they do, it will migrate them and init the new config with them! This is not what we want.

It is possible to keep this migration code and fix it so that it will trigger only if the current config dir is the system default one, but I think its also viable already and much more future-proof to outright remove it.
Additional Information--basedir was added as a feature of 0003452
Attached Files

- Relationships
related to 0003452closedZalewa Add an option to select a Doomseeker environment path on startup 

-  Notes
User avatar (0022621)
Zalewa (developer)
2023-01-02 13:32

 This commit installs a fail-safe to migrate the configs only when the current config dirs are the defaults (--basedir didn't change them):'https://bitbucket.org/Doomseeker/doomseeker/commits/36ee27420f812ddd9ecc4a53cd20781ce5832798 [^]'

This subsequent commit removes the migration code altogether:'https://bitbucket.org/Doomseeker/doomseeker/commits/a59481c02c15bcb462e615c00579dd3e27533864 [^]'
User avatar (0022658)
Zalewa (developer)
2023-01-05 12:26

 Beta package for Windows available at the beta auto-update channel and at:
'https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.3~beta-230105-1140_windows.zip [^]'

Please test if a fresh start of Doomseeker with no configuration doesn't cause any problems now.
User avatar (0022694)
Zalewa (developer)
2023-01-14 13:20

 Seems good: when you open Doomseeker without the configuration, it will pop-up the welcome box and then open the config box. It will also start refreshing the servers. Everything is as expected.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2023-01-02 10:06 Zalewa New Issue
2023-01-02 10:06 Zalewa Assigned To => Zalewa
2023-01-02 10:06 Zalewa Status new => assigned
2023-01-02 10:07 Zalewa Relationship added related to 0003452
2023-01-02 10:07 Zalewa Additional Information Updated View Revisions
2023-01-02 13:32 Zalewa Note Added: 0022621
2023-01-02 13:32 Zalewa Status assigned => needs review
2023-01-05 12:26 Zalewa Note Added: 0022658
2023-01-05 12:26 Zalewa Status needs review => needs testing
2023-01-14 13:20 Zalewa Note Added: 0022694
2023-01-14 13:20 Zalewa Status needs testing => resolved
2023-01-14 13:20 Zalewa Fixed in Version => 1.4.0
2023-01-14 13:20 Zalewa Resolution open => fixed
2024-11-03 19:14 Zalewa Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker