MantisBT - Doomseeker
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0004081Doomseeker[All Projects] Suggestionpublic2023-01-02 10:062024-11-03 19:14
ReporterZalewa 
Assigned ToZalewa 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.4.0 
Target Version1.4.0Fixed in Version1.4.0 
Summary0004081: Doomseeker 1.1 config migration getting in the way of --basedir
DescriptionThe code in DataPaths is full of legacy, but the one thing that started to get in the way is the code that migrates the Doomseeker 1.1 configs to 1.2 and newer. 1.2 was released in October 2018. The code was written in December 2017.

Now the issue is that when you start a new Doomseeker process with `--basedir something_fresh`, Doomseeker will see that this is a new config directory and then will check if Doomseeker 1.1 configs still exist in the system. If they do, it will migrate them and init the new config with them! This is not what we want.

It is possible to keep this migration code and fix it so that it will trigger only if the current config dir is the system default one, but I think its also viable already and much more future-proof to outright remove it.
Steps To Reproduce
Additional Information--basedir was added as a feature of 0003452
TagsNo tags attached.
Relationships
related to 0003452closed Zalewa Add an option to select a Doomseeker environment path on startup 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-01-02 10:06ZalewaNew Issue
2023-01-02 10:06ZalewaAssigned To => Zalewa
2023-01-02 10:06ZalewaStatusnew => assigned
2023-01-02 10:07ZalewaRelationship addedrelated to 0003452
2023-01-02 10:07ZalewaAdditional Information Updatedbug_revision_view_page.php?rev_id=13861#r13861
2023-01-02 13:32ZalewaNote Added: 0022621
2023-01-02 13:32ZalewaStatusassigned => needs review
2023-01-05 12:26ZalewaNote Added: 0022658
2023-01-05 12:26ZalewaStatusneeds review => needs testing
2023-01-14 13:20ZalewaNote Added: 0022694
2023-01-14 13:20ZalewaStatusneeds testing => resolved
2023-01-14 13:20ZalewaFixed in Version => 1.4.0
2023-01-14 13:20ZalewaResolutionopen => fixed
2024-11-03 19:14ZalewaStatusresolved => closed

Notes
(0022621)
Zalewa   
2023-01-02 13:32   
This commit installs a fail-safe to migrate the configs only when the current config dirs are the defaults (--basedir didn't change them):'https://bitbucket.org/Doomseeker/doomseeker/commits/36ee27420f812ddd9ecc4a53cd20781ce5832798 [^]'

This subsequent commit removes the migration code altogether:'https://bitbucket.org/Doomseeker/doomseeker/commits/a59481c02c15bcb462e615c00579dd3e27533864 [^]'
(0022658)
Zalewa   
2023-01-05 12:26   
Beta package for Windows available at the beta auto-update channel and at:
'https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.3~beta-230105-1140_windows.zip [^]'

Please test if a fresh start of Doomseeker with no configuration doesn't cause any problems now.
(0022694)
Zalewa   
2023-01-14 13:20   
Seems good: when you open Doomseeker without the configuration, it will pop-up the welcome box and then open the config box. It will also start refreshing the servers. Everything is as expected.