Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003957DoomseekerIP2Cpublic2021-12-23 12:052022-03-22 11:11
ReporterZalewa 
Assigned ToZalewa 
PrioritynormalSeveritytextReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.3.2 
Target Version1.3.3Fixed in Version1.3.3 
Summary0003957: Doomseeker should know country codes and names by heart.
DescriptionCurrently the country codes and names that Doomseeker knows come from the IP2C database. This is no longer viable, as the country codes need to be presented in the interface for the proper handling of sv_country (0003938).

Since the list of the ISO 3166-1 alpha-3 codes is somewhat standard, I think we can hardcode them in Doomseeker. This will also enable to translate the names of the countries.
Attached Files

- Relationships
related to 0003938closedZalewa Update Zandronum dmflags for Zandronum 3.1 

-  Notes
User avatar (0021997)
WubTheCaptain (reporter)
2021-12-23 12:14
Quote from Zalewa
I think we can hardcode them in Doomseeker.

Not really opposed to the general idea, but there's LGPLv2.1+ licensed iso-codes package with already-translated gettext strings available. I don't support the idea of maintaining our own work for this, or at very least I think it should be maintained as a general purpose library when available.
User avatar (0021998)
WubTheCaptain (reporter)
2021-12-23 12:16

 See also isoquery by toddy15 on GitHub. The README says GPLv3-only, but file copyright headers say GPLv3+.
User avatar (0021999)
Zalewa (developer)
2021-12-23 12:54

 Done:'https://bitbucket.org/Doomseeker/doomseeker/commits/5de522eda3dd6273f6ffc7304fc48faf84b8e6e2 [^]'
User avatar (0022001)
WubTheCaptain (reporter)
2021-12-23 13:21

 Re: commit, I don't approve this for long-term but you already knew it.
User avatar (0022006)
Zalewa (developer)
2021-12-23 19:48

 Testing build released:'https://devbuilds.drdteam.org/doomseeker/doomseeker-1.3.2~beta-211223-1915_windows.zip [^]'

No translations yet - all names will be in English.
User avatar (0022007)
Blzut3 (administrator)
2021-12-23 20:12

 I'm wondering if we could avoid having to do translations by mapping country codes to QLocale::Country and then using QLocale::countryToString? Qt doesn't have three letter country code support so that seems to be the most help we could get leveraging Qt.
User avatar (0022008)
Zalewa (developer)
2021-12-23 21:04

 Good tip. I'll check that out.
User avatar (0022009)
Zalewa (developer)
2021-12-25 09:00
Quote from Blzut3

I'm wondering if we could avoid having to do translations by mapping country codes to QLocale::Country and then using QLocale::countryToString?

That's a no go. QLocale::countryToString() doesn't seem to be translated.
User avatar (0022103)
Zalewa (developer)
2022-01-18 17:57

 Marking as resolved for the release of Doomseeker 1.3.3. Names of some countries are untranslated in the Polish translation but I really didn't want to wear myself down for that.
User avatar (0022109)
WubTheCaptain (reporter)
2022-01-18 18:38
Quote from Zalewa
Names of some countries are untranslated in the Polish translation but I really didn't want to wear myself down for that.

Reported as a new issue 0003970.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: WubTheCaptain

- Issue History
Date Modified Username Field Change
2021-12-23 12:05 Zalewa New Issue
2021-12-23 12:06 Zalewa Assigned To => Zalewa
2021-12-23 12:06 Zalewa Status new => assigned
2021-12-23 12:06 Zalewa Relationship added related to 0003938
2021-12-23 12:14 WubTheCaptain Note Added: 0021997
2021-12-23 12:16 WubTheCaptain Note Added: 0021998
2021-12-23 12:54 Zalewa Note Added: 0021999
2021-12-23 12:54 Zalewa Status assigned => needs review
2021-12-23 13:21 WubTheCaptain Note Added: 0022001
2021-12-23 19:48 Zalewa Note Added: 0022006
2021-12-23 19:48 Zalewa Status needs review => needs testing
2021-12-23 20:12 Blzut3 Note Added: 0022007
2021-12-23 21:04 Zalewa Note Added: 0022008
2021-12-23 21:04 Zalewa Status needs testing => assigned
2021-12-25 09:00 Zalewa Note Added: 0022009
2021-12-25 09:00 Zalewa Status assigned => needs testing
2022-01-18 17:57 Zalewa Note Added: 0022103
2022-01-18 17:57 Zalewa Status needs testing => resolved
2022-01-18 17:57 Zalewa Fixed in Version => 1.3.3
2022-01-18 17:57 Zalewa Resolution open => fixed
2022-01-18 18:38 WubTheCaptain Note Added: 0022109
2022-03-22 11:11 WubTheCaptain Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker