| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0003818 | Doomseeker | [All Projects] Cleanup | public | 2020-06-07 07:18 | 2020-06-07 21:04 |
|
| Reporter | WubTheCaptain | |
| Assigned To | | |
| Priority | none | Severity | trivial | Reproducibility | random |
| Status | confirmed | Resolution | open | |
| Platform | | OS | | OS Version | |
| Product Version | 1.3.1 | |
| Target Version | | Fixed in Version | | |
|
| Summary | 0003818: Boolean expressions involving boolean constants (instead of expressing the boolean expression directly) |
| Description | Elementary and pedantic about code style.
if (b == true) becomes if (b), and so on. This has been quite well followed, with only a few exceptions.
I will also agree something like bool ZandronumVersion::operator> (const ZandronumVersion &other) const is better written the way it is. |
| Steps To Reproduce | These are difficult to find with a text search and due to rarity, so I'll just point out one.
src/core/tests/testdatapaths.cpp: } while (bEntryDoesExist == true);
Fortunately (or unfortunately), that's also part of the code that has rotten un(der)utilized.
Maybe this:
Quote from src/core/fileutils.cpp
bool FileUtils::containsPath(const QStringList &candidates, const QString &path)
{
for (const QString &candidate : candidates)
{
if (QFileInfo(candidate) == QFileInfo(path))
return true;
}
return false;
}
Few more that I could find with grep -B 2 -A 2 -r 'return false' src/ | less. |
| Additional Information | 'https://clang.llvm.org/extra/clang-tidy/checks/readability-simplify-boolean-expr.html [^]' |
|
| Attached Files | |
|
Chat on our Discord Server
Get the latest version: 3.2.1
Relationships 
Relationships 
(0021392)
ZDoom
Doom Wiki
id Software
Doomworld
Odamex
Doomseeker
Internet Doom Explorer
The Sentinel's Playground Servers