Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002397Zandronum[All Projects] Bugpublic2015-08-10 11:562018-09-30 21:40
ReporterIvan 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version2.1 
Target Version2.2Fixed in Version2.2 
Summary0002397: Tag property does not work with shared keys
DescriptionSome mods may want to replace the key actors to use different pickup sounds or new animations. However, it will display the decorate name. It'd be very useful if it'd instead display the Tag value of the actor if provided, this way the decorate name can be hidden from the users.
Attached Files

- Relationships

-  Notes
User avatar (0013188)
Dusk (developer)
2015-08-10 11:57
edited on: 2015-08-10 12:42

 It should be doing this right now. If it doesn't, it's a bug.

EDIT: 2.0 indeed appears to be using the wrong way of getting the actor tag.
User avatar (0013212)
Dusk (developer)
2015-08-11 19:20

 'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-requests/5 [^]'

Why didn't ZDoom get rid of AMETA_StrifeName when use of it was dropped? It caused the tag lookup to just silently fail. o_O
User avatar (0013241)
cobalt (updater)
2015-08-19 19:36

 Issue addressed by commit 6b9df59e2e76: Fixed: shared keys no longer respected actor tags as of the ZDoom upgrade in 2.0.
Committed by Teemu Piippo [Dusk] on Tuesday 11 August 2015 22:24:51

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/dobjtype.cpp | 11 -----------
 src/dobjtype.h | 6 ------
 src/g_shared/a_pickups.cpp | 2 +-
 src/sv_main.cpp | 7 ++++++-
 5 files changed, 8 insertions(+), 19 deletions(-)
User avatar (0013253)
Ru5tK1ng (updater)
2015-08-23 18:46
edited on: 2015-08-23 18:52

 I did a small test with Doom and Heretic and the tag name was displayed properly when provided rather than the actor name.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2015-08-10 11:56 Ivan New Issue
2015-08-10 11:57 Dusk Note Added: 0013188
2015-08-10 12:42 Dusk Note Edited: 0013188 View Revisions
2015-08-10 12:42 Dusk Status new => confirmed
2015-08-10 12:42 Dusk Category Suggestion => Bug
2015-08-10 12:42 Dusk Summary Option to use the actor Tag property for shared keys => Tag property does not work with shared keys
2015-08-11 19:20 Dusk Note Added: 0013212
2015-08-11 19:20 Dusk Assigned To => Dusk
2015-08-11 19:20 Dusk Status confirmed => needs review
2015-08-19 19:02 Torr Samaho Status needs review => needs testing
2015-08-19 19:36 cobalt Target Version => 2.1
2015-08-19 19:36 cobalt Note Added: 0013241
2015-08-23 18:46 Ru5tK1ng Note Added: 0013253
2015-08-23 18:52 Ru5tK1ng Note Edited: 0013253 View Revisions
2015-08-25 10:00 Dusk Status needs testing => resolved
2015-08-25 10:00 Dusk Fixed in Version => 2.2
2015-08-25 10:00 Dusk Resolution open => fixed
2015-08-25 10:01 Dusk Target Version 2.1 => 2.2
2018-09-30 21:40 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker