MantisBT - Zandronum
View Issue Details
0002397Zandronum[All Projects] Bugpublic2015-08-10 11:562018-09-30 21:40
Ivan 
Dusk 
normalminorN/A
closedfixed 
MicrosoftWindowsXP/Vista/7
2.1 
2.22.2 
0002397: Tag property does not work with shared keys
Some mods may want to replace the key actors to use different pickup sounds or new animations. However, it will display the decorate name. It'd be very useful if it'd instead display the Tag value of the actor if provided, this way the decorate name can be hidden from the users.
No tags attached.
Issue History
2015-08-10 11:56IvanNew Issue
2015-08-10 11:57DuskNote Added: 0013188
2015-08-10 12:42DuskNote Edited: 0013188bug_revision_view_page.php?bugnote_id=13188#r7873
2015-08-10 12:42DuskStatusnew => confirmed
2015-08-10 12:42DuskCategorySuggestion => Bug
2015-08-10 12:42DuskSummaryOption to use the actor Tag property for shared keys => Tag property does not work with shared keys
2015-08-11 19:20DuskNote Added: 0013212
2015-08-11 19:20DuskAssigned To => Dusk
2015-08-11 19:20DuskStatusconfirmed => needs review
2015-08-19 19:02Torr SamahoStatusneeds review => needs testing
2015-08-19 19:36cobaltTarget Version => 2.1
2015-08-19 19:36cobaltNote Added: 0013241
2015-08-23 18:46Ru5tK1ngNote Added: 0013253
2015-08-23 18:52Ru5tK1ngNote Edited: 0013253bug_revision_view_page.php?bugnote_id=13253#r7940
2015-08-25 10:00DuskStatusneeds testing => resolved
2015-08-25 10:00DuskFixed in Version => 2.2
2015-08-25 10:00DuskResolutionopen => fixed
2015-08-25 10:01DuskTarget Version2.1 => 2.2
2018-09-30 21:40Blzut3Statusresolved => closed

Notes
(0013188)
Dusk   
2015-08-10 11:57   
(edited on: 2015-08-10 12:42)
It should be doing this right now. If it doesn't, it's a bug.

EDIT: 2.0 indeed appears to be using the wrong way of getting the actor tag.

(0013212)
Dusk   
2015-08-11 19:20   
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-requests/5 [^]'

Why didn't ZDoom get rid of AMETA_StrifeName when use of it was dropped? It caused the tag lookup to just silently fail. o_O
(0013241)
cobalt   
2015-08-19 19:36   
Issue addressed by commit 6b9df59e2e76: Fixed: shared keys no longer respected actor tags as of the ZDoom upgrade in 2.0.
Committed by Teemu Piippo [Dusk] on Tuesday 11 August 2015 22:24:51

Changes in files:

 docs/zandronum-history.txt | 1 +
 src/dobjtype.cpp | 11 -----------
 src/dobjtype.h | 6 ------
 src/g_shared/a_pickups.cpp | 2 +-
 src/sv_main.cpp | 7 ++++++-
 5 files changed, 8 insertions(+), 19 deletions(-)

(0013253)
Ru5tK1ng   
2015-08-23 18:46   
(edited on: 2015-08-23 18:52)
I did a small test with Doom and Heretic and the tag name was displayed properly when provided rather than the actor name.