Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code

View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001900Zandronum[All Projects] Suggestionpublic2014-07-29 00:272014-07-29 00:27
ReporterZzZombo 
Assigned To 
PrioritylowSeverityminorReproducibilityN/A
StatusnewResolutionopen 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0001900: Redudant check in A_CustomFireBullets()
Descriptionsrc/thingdef/thingdef_codeptr.cpp contains the following code
void A_CustomFireBullets( AActor *self,
                          angle_t Spread_XY,
                          angle_t Spread_Z,
                          int NumberOfBullets,
                          int DamagePerBullet,
                          const PClass * PuffType,
                          int Flags,
                          fixed_t Range,
                          const bool pPlayAttacking = true ){
      if ( self->player == NULL)
        return;

    if (!self->player) return;
...
I guess the line "if (!self->player) return;" isn't needed there.
Additional InformationNot sure if this counts as a bug since the code isn't faulty.
Attached Files

- Relationships

-  Notes
There are no notes attached to this issue.

Issue Community Support
Only registered users can voice their support. Click here to register, or here to log in.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2014-07-29 00:27 ZzZombo New Issue






Questions or other issues? Contact Us.

Links


Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker