MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001900Zandronum[All Projects] Suggestionpublic2014-07-29 00:272014-07-29 00:27
ReporterZzZombo 
Assigned To 
PrioritylowSeverityminorReproducibilityN/A
StatusnewResolutionopen 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0001900: Redudant check in A_CustomFireBullets()
Descriptionsrc/thingdef/thingdef_codeptr.cpp contains the following code
void A_CustomFireBullets( AActor *self,
                          angle_t Spread_XY,
                          angle_t Spread_Z,
                          int NumberOfBullets,
                          int DamagePerBullet,
                          const PClass * PuffType,
                          int Flags,
                          fixed_t Range,
                          const bool pPlayAttacking = true ){
      if ( self->player == NULL)
        return;

    if (!self->player) return;
...
I guess the line "if (!self->player) return;" isn't needed there.
Steps To Reproduce
Additional InformationNot sure if this counts as a bug since the code isn't faulty.
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-07-29 00:27ZzZomboNew Issue

There are no notes attached to this issue.