Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001785Zandronum[All Projects] Bugpublic2014-04-21 17:022018-09-30 22:43
ReporterWaTaKiD 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.2 
Target Version1.3Fixed in Version 
Summary0001785: Spectating can cause monsters to "go dormant"
Descriptiondrawing agro and spectating can put monsters to sleep, allowing dead players to respawn and continue without agro (atleast from the monsters that the spectated player had agro for, so if u encounter monsters that have not been disturbed yet, they will act normal)
Steps To Reproduce1. player 1 dies (or stays hidden and doesnt shoot, to not draw agro)
2. player 2 shoots to draw agro and spectates (can also die between shooting and spectating, if that matters)
3. player 1 runs around agro free (respawn first, if necessary)
Additional Informationuploaded a quick demo showing the bug in the doom2 cooperative gamemode, this can also happen in survival/invasion/survival invasion in all the major iwads in 1.2 and 2.0-140112-1124

players that connect to the server after or were spectators during this will also "benefit", as long as the player in step 2 doesnt leave the server, rejoin the game, or if someone else shoots
Attached Files? file icon 2014.04.21_07.43.57_newtextcolours1_170pk3.cld [^] (73,748 bytes) 2014-04-21 17:02

- Relationships

-  Notes
User avatar (0008625)
Frits (reporter)
2014-04-21 22:07

 I can confirm this.
User avatar (0008672)
Dusk (developer)
2014-05-02 23:18

 fixed
User avatar (0008674)
Torr Samaho (administrator)
2014-05-03 08:31
edited on: 2014-05-03 08:32

 Please see my comment in the bitbucket pull request.
User avatar (0008681)
Dusk (developer)
2014-05-04 01:01

 'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/26/fixed-monsters-would-not-clear-their/diff [^]'
User avatar (0008684)
Torr Samaho (administrator)
2014-05-04 08:32
edited on: 2014-05-04 08:32

 Thanks! I added your patch, but had to make two small changes:
- "if ( not PLAYER_IsValidPlayer( ulPlayer ))" does not compile for me, so I had to change it to "if ( PLAYER_IsValidPlayer( ulPlayer ) == false )"
- I made the sector->SoundTarget clearing independent of COMPATF_SOUNDTARGET. Otherwise the fix wouldn't work properly if the flagged is toggled during the game.
User avatar (0008687)
Dusk (developer)
2014-05-04 11:26
Quote

- "if ( not PLAYER_IsValidPlayer( ulPlayer ))" does not compile for me, so I had to change it to "if ( PLAYER_IsValidPlayer( ulPlayer ) == false )"

Oops, I use the 'not' keyword in my own code and I guess the habit slipped through. Strange that it specifically fails compile though, the stuff is right in the standard...

Quote

- I made the sector->SoundTarget clearing independent of COMPATF_SOUNDTARGET. Otherwise the fix wouldn't work properly if the flagged is toggled during the game.

Oh yeah, good catch.
User avatar (0008799)
Dusk (developer)
2014-05-16 15:59

 re: alternative operators: turns out one needs to add a switch to msvc to enable them:'http://stackoverflow.com/questions/555505/c-alternative-tokens [^]'
So that's why the 'not' keyword was causing a compiler error.
User avatar (0008821)
Arco (updater)
2014-05-24 21:01

 Issue fixed in v1.3 r140413-2324M

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2014-04-21 17:02 WaTaKiD New Issue
2014-04-21 17:02 WaTaKiD File Added: 2014.04.21_07.43.57_newtextcolours1_170pk3.cld
2014-04-21 22:07 Frits Note Added: 0008625
2014-04-22 15:41 Arco Status new => confirmed
2014-05-02 21:39 Dusk Assigned To => Dusk
2014-05-02 21:39 Dusk Status confirmed => assigned
2014-05-02 23:18 Dusk Note Added: 0008672
2014-05-02 23:18 Dusk Status assigned => needs review
2014-05-03 08:31 Torr Samaho Note Added: 0008674
2014-05-03 08:31 Torr Samaho Status needs review => feedback
2014-05-03 08:32 Torr Samaho Note Edited: 0008674 View Revisions
2014-05-03 08:32 Torr Samaho Note Revision Dropped: 8674: 0004695
2014-05-03 13:17 Dusk Status feedback => assigned
2014-05-04 01:01 Dusk Note Added: 0008681
2014-05-04 01:01 Dusk Status assigned => needs review
2014-05-04 08:32 Torr Samaho Note Added: 0008684
2014-05-04 08:32 Torr Samaho Note Edited: 0008684 View Revisions
2014-05-04 08:32 Torr Samaho Note Revision Dropped: 8684: 0004697
2014-05-04 08:32 Torr Samaho Status needs review => needs testing
2014-05-04 08:32 Torr Samaho Target Version => 1.3
2014-05-04 11:26 Dusk Note Added: 0008687
2014-05-16 15:59 Dusk Note Added: 0008799
2014-05-24 21:01 Arco Note Added: 0008821
2014-05-24 21:01 Arco Status needs testing => resolved
2014-05-24 21:01 Arco Resolution open => fixed
2018-09-30 22:43 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker