MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001785Zandronum[All Projects] Bugpublic2014-04-21 17:022018-09-30 22:43
ReporterWaTaKiD 
Assigned ToDusk 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version1.2 
Target Version1.3Fixed in Version 
Summary0001785: Spectating can cause monsters to "go dormant"
Descriptiondrawing agro and spectating can put monsters to sleep, allowing dead players to respawn and continue without agro (atleast from the monsters that the spectated player had agro for, so if u encounter monsters that have not been disturbed yet, they will act normal)
Steps To Reproduce1. player 1 dies (or stays hidden and doesnt shoot, to not draw agro)
2. player 2 shoots to draw agro and spectates (can also die between shooting and spectating, if that matters)
3. player 1 runs around agro free (respawn first, if necessary)
Additional Informationuploaded a quick demo showing the bug in the doom2 cooperative gamemode, this can also happen in survival/invasion/survival invasion in all the major iwads in 1.2 and 2.0-140112-1124

players that connect to the server after or were spectators during this will also "benefit", as long as the player in step 2 doesnt leave the server, rejoin the game, or if someone else shoots
TagsNo tags attached.
Relationships
Attached Files? 2014.04.21_07.43.57_newtextcolours1_170pk3.cld (73,748) 2014-04-21 17:02
/tracker/file_download.php?file_id=1203&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-04-21 17:02WaTaKiDNew Issue
2014-04-21 17:02WaTaKiDFile Added: 2014.04.21_07.43.57_newtextcolours1_170pk3.cld
2014-04-21 22:07FritsNote Added: 0008625
2014-04-22 15:41ArcoStatusnew => confirmed
2014-05-02 21:39DuskAssigned To => Dusk
2014-05-02 21:39DuskStatusconfirmed => assigned
2014-05-02 23:18DuskNote Added: 0008672
2014-05-02 23:18DuskStatusassigned => needs review
2014-05-03 08:31Torr SamahoNote Added: 0008674
2014-05-03 08:31Torr SamahoStatusneeds review => feedback
2014-05-03 08:32Torr SamahoNote Edited: 0008674bug_revision_view_page.php?bugnote_id=8674#r4696
2014-05-03 08:32Torr SamahoNote Revision Dropped: 8674: 0004695
2014-05-03 13:17DuskStatusfeedback => assigned
2014-05-04 01:01DuskNote Added: 0008681
2014-05-04 01:01DuskStatusassigned => needs review
2014-05-04 08:32Torr SamahoNote Added: 0008684
2014-05-04 08:32Torr SamahoNote Edited: 0008684bug_revision_view_page.php?bugnote_id=8684#r4698
2014-05-04 08:32Torr SamahoNote Revision Dropped: 8684: 0004697
2014-05-04 08:32Torr SamahoStatusneeds review => needs testing
2014-05-04 08:32Torr SamahoTarget Version => 1.3
2014-05-04 11:26DuskNote Added: 0008687
2014-05-16 15:59DuskNote Added: 0008799
2014-05-24 21:01ArcoNote Added: 0008821
2014-05-24 21:01ArcoStatusneeds testing => resolved
2014-05-24 21:01ArcoResolutionopen => fixed
2018-09-30 22:43Blzut3Statusresolved => closed

Notes
(0008625)
Frits   
2014-04-21 22:07   
I can confirm this.
(0008672)
Dusk   
2014-05-02 23:18   
fixed
(0008674)
Torr Samaho   
2014-05-03 08:31   
(edited on: 2014-05-03 08:32)
Please see my comment in the bitbucket pull request.
(0008681)
Dusk   
2014-05-04 01:01   
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/26/fixed-monsters-would-not-clear-their/diff [^]'
(0008684)
Torr Samaho   
2014-05-04 08:32   
Thanks! I added your patch, but had to make two small changes:
- "if ( not PLAYER_IsValidPlayer( ulPlayer ))" does not compile for me, so I had to change it to "if ( PLAYER_IsValidPlayer( ulPlayer ) == false )"
- I made the sector->SoundTarget clearing independent of COMPATF_SOUNDTARGET. Otherwise the fix wouldn't work properly if the flagged is toggled during the game.
(0008687)
Dusk   
2014-05-04 11:26   
Quote

- "if ( not PLAYER_IsValidPlayer( ulPlayer ))" does not compile for me, so I had to change it to "if ( PLAYER_IsValidPlayer( ulPlayer ) == false )"

Oops, I use the 'not' keyword in my own code and I guess the habit slipped through. Strange that it specifically fails compile though, the stuff is right in the standard...

Quote

- I made the sector->SoundTarget clearing independent of COMPATF_SOUNDTARGET. Otherwise the fix wouldn't work properly if the flagged is toggled during the game.

Oh yeah, good catch.
(0008799)
Dusk   
2014-05-16 15:59   
re: alternative operators: turns out one needs to add a switch to msvc to enable them:'http://stackoverflow.com/questions/555505/c-alternative-tokens [^]'
So that's why the 'not' keyword was causing a compiler error.
(0008821)
Arco   
2014-05-24 21:01   
Issue fixed in v1.3 r140413-2324M