Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001236Zandronum[All Projects] Suggestionpublic2012-12-30 19:232018-09-30 20:19
ReporterKonar6 
Assigned ToDusk 
PrioritynoneSeverityfeatureReproducibilityN/A
StatusclosedResolutionfixed 
Platform*OSOS Version
Product Version1.0 
Target Version1.1Fixed in Version1.1 
Summary0001236: Suggestions for client console notify lines
Description1]
The number of console notify lines is hardcoded to 4 in c_console.cpp:204.
I imagine that it originates from the old Doom days when it was sufficient for the few players Doom had supported + monitor resolutions were low, but today we have 64 players support and a lot more stuff is printed in the console, and we have monitors with huge resolutions.
Personally I've doubled the number of notify lines, and I thought it would be a blast if this value was user-configurable via some con_notifylines CVAR, just like there is con_notifytime for adjusting the time for the messages to stay on screen.
I would have provided a patch, but I don't know how I would go about changing that constant to CVAR variable since it's used in arrays :(.
Attached Filespng file icon Screenshot_Doom_20121230_231654.png [^] (141,915 bytes) 2012-12-30 23:00

- Relationships
related to 0001377feedback Suggestions for client console notify lines, part 2 

-  Notes
User avatar (0005626)
Torr Samaho (administrator)
2012-12-30 21:38
Quote from Konar6
I would have provided a patch, but I don't know how I would go about changing that constant to CVAR variable since it's used in arrays :(.
One possibility is to replace the fixed size C array with ZDoom's TArray and then to dynamically change the size of the TArray whenever the user changes the proposed CVAR.

Quote from Konar6
Why is C_FlushDisplay() called in g_level.cpp:1022 and g_level.cpp:1579 (ie. on level finished and level start)?

g_level.cpp:1022 was already in the source of ST 97c2, so it was added to Skulltag before I took care of the source, g_level.cpp:1579 is inherited from ZDoom. I don't know the motivation of either.
User avatar (0005627)
Dusk (developer)
2012-12-30 22:25
edited on: 2013-06-23 14:48

 SURPRISE COMMIT

Maybe con_numnotifies would be a better cvar name?
User avatar (0005628)
Konar6 (reporter)
2012-12-30 22:49
edited on: 2012-12-30 23:01

 Very good!

I like con_notifylines since it's consistent with existing con_notifytime.

EDIT: updated a screenshot showing the effect of removing C_FlushDisplay() on level start, which I personally find pretty cool :P.
User avatar (0005629)
Dusk (developer)
2012-12-30 22:56

 Renamed, updated commit link
User avatar (0005634)
Torr Samaho (administrator)
2012-12-31 09:50
Quote from Dusk
SURPRISE COMMIT

I'd say it's safer to use NotifyStrings.Size() instead of con_numnotifylines.GetGenericRep(CVAR_Int).Int to determine NUMNOTIFIES. If for whatever reason the former should be smaller than the latter, code using the latter to access NotifyStrings will crash. And as always: Please mark any changes to ZDoom code with a comment.
User avatar (0005639)
Dusk (developer)
2012-12-31 11:04
edited on: 2013-06-23 14:48

 I actually had just thought of the same.. let's see here.

EDIT: How's this?
User avatar (0005641)
Torr Samaho (administrator)
2012-12-31 12:11

 Looks good! If you rebase and collapse it, I'll pull it, or I can also do the rebasing / collapsing. The only thing I still wonder is whether we should enforce a reasonable maximum for con_notifylines. Setting this in the thousands certainly doesn't make any sense.
User avatar (0005646)
Dusk (developer)
2013-01-01 11:07

 Alright, here is this
User avatar (0005648)
Torr Samaho (administrator)
2013-01-02 09:13
edited on: 2013-01-02 10:41

 Thanks! Pulled and rebased. I also prevented con_notifylines from being set to anything bigger than 50. If somebody really wants to set it to something bigger, we can raise the limit.

EDIT: We still need to decide what to do with C_FlushDisplay().
User avatar (0006149)
Watermelon (developer)
2013-03-20 04:42

 Is it significant if we enter in a negative number for the time it stays on the screen? When I enter in -1 it holds -1 as a value. I don't know if we want to (like the other cvar) just hold it at 0 if someone goes negative or not.
User avatar (0006167)
Torr Samaho (administrator)
2013-03-24 13:39

 The way con_notifytime is handled is inherited from ZDoom. We shouldn't change this unless it's changed in ZDoom.
User avatar (0006180)
Watermelon (developer)
2013-03-28 17:18

 I'd say then that this is a resolved ticket as it worked for me on my end. I'll let you be the one to decide this since I don't know if you want any more testing, I entered as many weird numbers as I could and tried to crash it... it did not which is great.
In addition it worked as it was supposed to.
User avatar (0006181)
Dusk (developer)
2013-03-28 17:48
Quote from Torr Samaho
We still need to decide what to do with C_FlushDisplay().

I guess we should resolve this first?
User avatar (0006273)
Dusk (developer)
2013-04-08 22:42

 con_notifylines confirmed to work by Arco, there's just the C_FlushDisplay problem now. What do?
User avatar (0006414)
Qent (updater)
2013-06-11 01:54
edited on: 2013-06-11 01:55

 Make it optional with con_flushonlevelchange? I would like to keep the display uninterrupted (mostly for not missing chat messages online), but I could totally see someone wanting to keep a more vanilla feel (e.g. does it carry pickup messages into the intermission in singleplayer?).
User avatar (0006487)
Dusk (developer)
2013-06-23 14:50

 I've split the C_FlushDisplay stuff into 0001377, since it's a different issue entirely. Since con_numnotifies works, I'll mark this as fixed.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: ZzZombo
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2012-12-30 19:23 Konar6 New Issue
2012-12-30 21:38 Torr Samaho Note Added: 0005626
2012-12-30 22:25 Dusk Note Added: 0005627
2012-12-30 22:25 Dusk Assigned To => Dusk
2012-12-30 22:25 Dusk Status new => needs review
2012-12-30 22:29 Dusk Note Edited: 0005627 View Revisions
2012-12-30 22:49 Konar6 Note Added: 0005628
2012-12-30 22:56 Dusk Note Edited: 0005627 View Revisions
2012-12-30 22:56 Dusk Note Added: 0005629
2012-12-30 23:00 Konar6 File Added: Screenshot_Doom_20121230_231654.png
2012-12-30 23:01 Konar6 Note Edited: 0005628 View Revisions
2012-12-31 09:50 Torr Samaho Note Added: 0005634
2012-12-31 11:04 Dusk Note Added: 0005639
2012-12-31 11:04 Dusk Status needs review => assigned
2012-12-31 11:14 Dusk Note Edited: 0005639 View Revisions
2012-12-31 11:14 Dusk Status assigned => needs review
2012-12-31 12:11 Torr Samaho Note Added: 0005641
2012-12-31 12:33 Torr Samaho Status needs review => feedback
2013-01-01 11:07 Dusk Note Added: 0005646
2013-01-01 11:07 Dusk Status feedback => needs review
2013-01-02 09:13 Torr Samaho Note Added: 0005648
2013-01-02 10:41 Torr Samaho Note Edited: 0005648 View Revisions
2013-01-02 10:41 Torr Samaho Status needs review => needs testing
2013-01-02 13:10 ZzZombo Note Added: 0005655
2013-01-09 23:16 Dusk Target Version => 1.1
2013-03-20 04:42 Watermelon Note Added: 0006149
2013-03-24 13:35 Torr Samaho Note Deleted: 0005655
2013-03-24 13:39 Torr Samaho Note Added: 0006167
2013-03-28 17:18 Watermelon Note Added: 0006180
2013-03-28 17:48 Dusk Note Added: 0006181
2013-04-08 22:42 Dusk Note Added: 0006273
2013-04-08 22:42 Dusk Status needs testing => feedback
2013-06-11 01:54 Qent Note Added: 0006414
2013-06-11 01:55 Qent Note Edited: 0006414 View Revisions
2013-06-23 14:48 Dusk Note Edited: 0005627 View Revisions
2013-06-23 14:48 Dusk Note Edited: 0005639 View Revisions
2013-06-23 14:49 Dusk Relationship added related to 0001377
2013-06-23 14:49 Dusk Description Updated View Revisions
2013-06-23 14:50 Dusk Note Added: 0006487
2013-06-23 14:50 Dusk Status feedback => resolved
2013-06-23 14:50 Dusk Fixed in Version => 1.1
2013-06-23 14:50 Dusk Resolution open => fixed
2018-09-30 20:19 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker