Zandronum Chat on our Discord Server Get the latest version: 3.2
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0001098Zandronum[All Projects] Suggestionpublic2012-10-04 04:442018-09-30 22:39
Reporterunknownna 
Assigned ToWatermelon 
PrioritylowSeveritytweakReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.0 
Target Version1.3Fixed in Version 
Summary0001098: Don't award medals during warm-up countdown sequences
DescriptionYou're not awarded the First Frag medal during warm-up countdown sequences. IMHO, it would be better if none of the medals were awarded during the sequences. The warm-up is not even a part of the game. And it looks odd when other players have a medal icon above their sprite when the actual round begins.
Attached Files

- Relationships

-  Notes
User avatar (0008745)
Watermelon (developer)
2014-05-09 01:19
edited on: 2014-05-09 01:26

 Interestingly other medals are awarded in countdown, but not first frag. I assume this is desired to be global.

Is this worth fixing?

EDIT: Medals persist after countdown, which probably shouldn't happen...

Two solutions:
1) Deny medals during countdown
2) Wipe all medals after countdown is done for all players

Which option to do?
User avatar (0008752)
Leonard (developer)
2014-05-09 10:33

 I see the countdown as a "simulation" of a real game for either training or just getting ready so being awarded medals should be possible.
I vote for wiping all the medals after countdown.
User avatar (0008880)
Watermelon (developer)
2014-06-07 21:18

 'https://bitbucket.org/ChrisKOmg/zandronum/commits/d8bea80e2a76ae9f9ac6858258907c0571000833 [^]'

Covers all medals properly.
User avatar (0008887)
Dusk (developer)
2014-06-07 22:46

 The padding style is off..
User avatar (0008894)
Watermelon (developer)
2014-06-08 00:25
edited on: 2014-06-08 00:29

 What do you mean? (Tab indents?)
User avatar (0008905)
Torr Samaho (administrator)
2014-06-08 08:19

 I think he means that

if (GAMEMODE_IsGameInCountdown())

should be

if ( GAMEMODE_IsGameInCountdown() )


The change itself looks ok, we just have to keep in mind that this will not completely stop all the medal relevant counters from being changed during the countdown. Since these counters are supposed to be reset after the countdown ends, this should matter though. In this light, the added check in MEDAL_PlayerDied can possibly moved to medal_GiveMedal. This way it's also guaranteed that the server won't send out any "give medal" commands that will be ignored by the client due to the countdown.

And of course the changeset is missing a history entry.
User avatar (0008929)
Watermelon (developer)
2014-06-08 17:56

 Updated padding, implemented your suggestion, added history change:

'https://bitbucket.org/ChrisKOmg/zandronum/commits/f8bbffbab6aa774f81d232f3c9e6ed7bf98b7eee [^]'
User avatar (0008954)
Torr Samaho (administrator)
2014-06-09 10:01

 I went ahead and transplanted+compressed your patch to 1.3.
User avatar (0009818)
Arco (updater)
2014-07-01 20:13

 Works correctly in v1.3 140610-2242.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Combinebobnt Qent Hypnotoad
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2012-10-04 04:44 unknownna New Issue
2013-09-18 16:48 Watermelon Assigned To => Watermelon
2013-09-18 16:48 Watermelon Status new => assigned
2014-05-05 22:32 Watermelon Note Added: 0008711
2014-05-09 01:18 Watermelon Note Deleted: 0008711
2014-05-09 01:19 Watermelon Note Added: 0008745
2014-05-09 01:22 Watermelon Note Edited: 0008745 View Revisions
2014-05-09 01:22 Watermelon Assigned To Watermelon =>
2014-05-09 01:22 Watermelon Status assigned => new
2014-05-09 01:25 Watermelon Note Edited: 0008745 View Revisions
2014-05-09 01:26 Watermelon Note Edited: 0008745 View Revisions
2014-05-09 10:33 Leonard Note Added: 0008752
2014-06-07 21:18 Watermelon Note Added: 0008880
2014-06-07 21:19 Watermelon Assigned To => Watermelon
2014-06-07 21:19 Watermelon Status new => needs review
2014-06-07 22:46 Dusk Note Added: 0008887
2014-06-08 00:25 Watermelon Note Added: 0008894
2014-06-08 00:29 Watermelon Note Edited: 0008894 View Revisions
2014-06-08 08:19 Torr Samaho Note Added: 0008905
2014-06-08 08:20 Torr Samaho Status needs review => feedback
2014-06-08 17:56 Watermelon Note Added: 0008929
2014-06-08 17:56 Watermelon Status feedback => needs review
2014-06-09 10:01 Torr Samaho Note Added: 0008954
2014-06-09 10:01 Torr Samaho Status needs review => needs testing
2014-06-09 10:01 Torr Samaho Target Version => 1.3
2014-07-01 20:13 Arco Note Added: 0009818
2014-07-01 20:13 Arco Status needs testing => resolved
2014-07-01 20:13 Arco Resolution open => fixed
2018-09-30 22:39 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2025 MantisBT Team
Powered by Mantis Bugtracker