MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0001098Zandronum[All Projects] Suggestionpublic2012-10-04 04:442018-09-30 22:39
Reporterunknownna 
Assigned ToWatermelon 
PrioritylowSeveritytweakReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version1.0 
Target Version1.3Fixed in Version 
Summary0001098: Don't award medals during warm-up countdown sequences
DescriptionYou're not awarded the First Frag medal during warm-up countdown sequences. IMHO, it would be better if none of the medals were awarded during the sequences. The warm-up is not even a part of the game. And it looks odd when other players have a medal icon above their sprite when the actual round begins.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-10-04 04:44unknownnaNew Issue
2013-09-18 16:48WatermelonAssigned To => Watermelon
2013-09-18 16:48WatermelonStatusnew => assigned
2014-05-05 22:32WatermelonNote Added: 0008711
2014-05-09 01:18WatermelonNote Deleted: 0008711
2014-05-09 01:19WatermelonNote Added: 0008745
2014-05-09 01:22WatermelonNote Edited: 0008745bug_revision_view_page.php?bugnote_id=8745#r4729
2014-05-09 01:22WatermelonAssigned ToWatermelon =>
2014-05-09 01:22WatermelonStatusassigned => new
2014-05-09 01:25WatermelonNote Edited: 0008745bug_revision_view_page.php?bugnote_id=8745#r4730
2014-05-09 01:26WatermelonNote Edited: 0008745bug_revision_view_page.php?bugnote_id=8745#r4731
2014-05-09 10:33LeonardNote Added: 0008752
2014-06-07 21:18WatermelonNote Added: 0008880
2014-06-07 21:19WatermelonAssigned To => Watermelon
2014-06-07 21:19WatermelonStatusnew => needs review
2014-06-07 22:46DuskNote Added: 0008887
2014-06-08 00:25WatermelonNote Added: 0008894
2014-06-08 00:29WatermelonNote Edited: 0008894bug_revision_view_page.php?bugnote_id=8894#r4829
2014-06-08 08:19Torr SamahoNote Added: 0008905
2014-06-08 08:20Torr SamahoStatusneeds review => feedback
2014-06-08 17:56WatermelonNote Added: 0008929
2014-06-08 17:56WatermelonStatusfeedback => needs review
2014-06-09 10:01Torr SamahoNote Added: 0008954
2014-06-09 10:01Torr SamahoStatusneeds review => needs testing
2014-06-09 10:01Torr SamahoTarget Version => 1.3
2014-07-01 20:13ArcoNote Added: 0009818
2014-07-01 20:13ArcoStatusneeds testing => resolved
2014-07-01 20:13ArcoResolutionopen => fixed
2018-09-30 22:39Blzut3Statusresolved => closed

Notes
(0008745)
Watermelon   
2014-05-09 01:19   
(edited on: 2014-05-09 01:26)
Interestingly other medals are awarded in countdown, but not first frag. I assume this is desired to be global.

Is this worth fixing?

EDIT: Medals persist after countdown, which probably shouldn't happen...

Two solutions:
1) Deny medals during countdown
2) Wipe all medals after countdown is done for all players

Which option to do?
(0008752)
Leonard   
2014-05-09 10:33   
I see the countdown as a "simulation" of a real game for either training or just getting ready so being awarded medals should be possible.
I vote for wiping all the medals after countdown.
(0008880)
Watermelon   
2014-06-07 21:18   
'https://bitbucket.org/ChrisKOmg/zandronum/commits/d8bea80e2a76ae9f9ac6858258907c0571000833 [^]'

Covers all medals properly.
(0008887)
Dusk   
2014-06-07 22:46   
The padding style is off..
(0008894)
Watermelon   
2014-06-08 00:25   
(edited on: 2014-06-08 00:29)
What do you mean? (Tab indents?)
(0008905)
Torr Samaho   
2014-06-08 08:19   
I think he means that

if (GAMEMODE_IsGameInCountdown())

should be

if ( GAMEMODE_IsGameInCountdown() )


The change itself looks ok, we just have to keep in mind that this will not completely stop all the medal relevant counters from being changed during the countdown. Since these counters are supposed to be reset after the countdown ends, this should matter though. In this light, the added check in MEDAL_PlayerDied can possibly moved to medal_GiveMedal. This way it's also guaranteed that the server won't send out any "give medal" commands that will be ignored by the client due to the countdown.

And of course the changeset is missing a history entry.
(0008929)
Watermelon   
2014-06-08 17:56   
Updated padding, implemented your suggestion, added history change:

'https://bitbucket.org/ChrisKOmg/zandronum/commits/f8bbffbab6aa774f81d232f3c9e6ed7bf98b7eee [^]'
(0008954)
Torr Samaho   
2014-06-09 10:01   
I went ahead and transplanted+compressed your patch to 1.3.
(0009818)
Arco   
2014-07-01 20:13   
Works correctly in v1.3 140610-2242.